[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

kristof.beyls added inline comments. Comment at: clang/lib/Headers/ptrauth.h:19-37 + /* A process-independent key which can be used to sign code pointers. + Signing and authenticating with this key is a no-op in processes + which disable ABI pointer authentication. */ +

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/AST/ExprConstant.cpp:10617 +// copying the data, which is wasteful. +for (const unsigned N : {1u, FinalSize}) { + unsigne

[PATCH] D113390: [clangd] Dont include file version in task name

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will drop fil

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Sorry for the delayed response! LGTM modulo the unit test comment. Please let me know if you don't have commit access and you need me to push on your behalf. Comment

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Comment.cpp:337 + if (Kind == TypedefKind) +Kind = FunctionKind; ParamVars = FTL.getParams(); Phabr

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 updated this revision to Diff 385434. jansvoboda11 added a comment. Herald added a subscriber: mgrang. Fix deserialization, improve (sub)module state tracking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.ll

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

dbhaskaran added a comment. In D109885#3004269 , @JonChesterfield wrote: > Dropping PATHS /opt/rocm from the openmp parts will break people using an > existing rocm install with trunk llvm. I think it would be reasonable to look > at whatever ROCM_PATH

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

dbhaskaran updated this revision to Diff 385398. dbhaskaran added a comment. Updated with review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ https://reviews.llvm.org/D109885 Files: clang/tools/amdgpu-arch/CMakeLists.txt

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu updated this revision to Diff 385440. ChuanqiXu added reviewers: aaron.ballman, rsmith, urnathan, dblaikie. ChuanqiXu set the repository for this revision to rG LLVM Github Monorepo. ChuanqiXu added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

aaron.ballman added a comment. Before I land this, it looks like precommit CI is failing with what possibly is a related failure: [9094/9117] Linking CXX executable tools/flang/unittests/Frontend/FlangFrontendTests FAILED: tools/flang/unittests/Frontend/FlangFrontendTests : && /usr/bin/cl

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. I feel uneasy about claiming that variable decls of function type are FunctionKind for the purposes of comment parsing (even doing it for typedefs is questionable). It seems like a bet

Re: [clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

Hello! Was this code reviewed anywhere? I can't seem to spot a review for it, so wondering if I missed something. Thanks! ~Aaron On Fri, Nov 5, 2021 at 6:08 PM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2021-11-05T15:08:09-07:00 > New Revision: 62786826

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added a comment. In D113391#3115080 , @tschuett wrote: > This sounds like an enum. > > enum class ModuleKind { > C++20, > Clang, > Unsupported > } In fact, there is another value `ModuleTS`. But it looks not bad. And the variable `CP

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added inline comments. Comment at: clang/lib/Tooling/CMakeLists.txt:29-30 +if (NOT Python3_EXECUTABLE +OR WIN32 +OR APPLE +OR GENERATOR_IS_MULTI_CONFIG smeenai wrote: > I'm looking at this commit in the context of > https://bugs.llvm.org/sho

[PATCH] D111266: Comment AST: Add support for variable templates

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/warn-documentation.cpp:1348 + /** + * functionPointerField + * "functionPointerTemplateMember" Repository: r

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe updated this revision to Diff 385443. FreddyYe added a comment. address comments. add alias for 36 intrinsics in all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 Files: clang/lib/Headers/av

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. linjamaki wrote: > Anastasia wro

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/invalid-types.cl:5 +// Test declare "Other Data Type" variables in program scope. +global queue_t qt; // expected-error {{the '__global queue_t' type cannot be used to declare a program scope variable}} + ---

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray created this revision. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://wg21.link/p0849 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113393 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 385450. lichray added a comment. Document updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Dia

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 385453. ckandeler added a comment. Addressed formatting comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp Ind

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 385454. lichray added a comment. C++2y -> C++2b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 385457. ASDenysPetrov marked 7 inline comments as done. ASDenysPetrov added a comment. Updated according to the nits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654 Files: clang/lib/StaticAnalyzer

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added a comment. @steakhal Thanks for your effort! > Yeah, I'm soo bad in review. I should have proposed these previously. Sorry. No, you're not! I'm telling you. Keep it up! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654

[PATCH] D113319: [clang-format] Improve require handling

MyDeveloperDay added a comment. I feel anything you do here would be an improvement. its probably worth looking at recent issues logged around this issue at the same time https://bugs.llvm.org/show_bug.cgi?id=52401 https://bugs.llvm.org/show_bug.cgi?id=32165 When I added this support its was ba

[clang] 17d9560 - Making the code compliant to the documentation about Floating Point

Author: Zahira Ammarguellat Date: 2021-11-08T07:51:29-05:00 New Revision: 17d9560294eee1eae5e2d3ac1ab84f514318409e URL: https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e DIFF: https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added a comment. In D112230#3078231 , @azabaznov wrote: > @Anastasia, @yaxunl, do you think it's possible to refactor code generation > for blocks such that block literal for global blocks (with no captures) would > be emitted in constant addr

Re: [clang] 17d9560 - Making the code compliant to the documentation about Floating Point

Was the link to the review omitted in the commit message? On Mon, Nov 8, 2021 at 3:51 PM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2021-11-08T07:51:29-05:00 > New Revision: 17d9560294eee1eae5e2d3ac1ab84f514318409e > > URL: > https://github.com/llvm/llvm

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Szelethus updated this revision to Diff 385459. Szelethus edited the summary of this revision. Szelethus added a comment. Clarify the summary. Delete unnecessary includes. More fitting `iterator` names in the test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

mubashar_ updated this revision to Diff 385463. mubashar_ marked 6 inline comments as done. mubashar_ added a comment. Patch addresses comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/ https://reviews.llvm.org/D113256 Files: clang/docs/ReleaseNotes.rst clang/test/

[clang] 0425087 - Revert "Making the code compliant to the documentation about Floating Point"

Author: Nico Weber Date: 2021-11-08T08:32:42-05:00 New Revision: 0425087b8bac03693976ea34c156ca149482c853 URL: https://github.com/llvm/llvm-project/commit/0425087b8bac03693976ea34c156ca149482c853 DIFF: https://github.com/llvm/llvm-project/commit/0425087b8bac03693976ea34c156ca149482c853.diff LO

[clang] a10a69f - [SPIR-V] Add SPIR-V triple and clang target info.

Author: Anastasia Stulova Date: 2021-11-08T13:34:10Z New Revision: a10a69fe9c74bef3630795d9f2f516d7b84e1cd3 URL: https://github.com/llvm/llvm-project/commit/a10a69fe9c74bef3630795d9f2f516d7b84e1cd3 DIFF: https://github.com/llvm/llvm-project/commit/a10a69fe9c74bef3630795d9f2f516d7b84e1cd3.diff

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa10a69fe9c74: [SPIR-V] Add SPIR-V triple and clang target info. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 438437c - Making the code compliant to the documentation about Floating Point

Author: Zahira Ammarguellat Date: 2021-11-08T08:35:19-05:00 New Revision: 438437cbb61a39ce27b3d6218ac426b8f8a0132e URL: https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e DIFF: https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e

RE: [clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

https://reviews.llvm.org/D112963 -Original Message- From: Aaron Ballman Sent: Monday, November 8, 2021 6:51 AM To: Ammarguellat, Zahira ; Zahira Ammarguellat Cc: cfe-commits Subject: Re: [clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created Hello! Was this code re

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield requested changes to this revision. JonChesterfield added a reviewer: ronl. JonChesterfield added a comment. This revision now requires changes to proceed. Marking as request changes because: `if (DEFINED ENV{ROCM_PATH})` Looking at environment variables is strictly worse than look

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. I don't know about the MLIR parts, but replacing > find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS > /opt/rocm) with > find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS > ${ROCM_PATH}) seems an improvement,

Re: [clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

Ah, I see what went wrong. That review was never signed up to the cfe-commits mailing list, so the only people who ever saw that review were the people explicitly on the reviewers and subscribers list. Next time, please be sure to add cfe-commits to the subscribers list explicitly. ~Aaron On Mon,

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. FYI the original RFC is https://lists.llvm.org/pipermail/cfe-dev/2021-August/068603.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 ___

Re: [clang] 17d9560 - Making the code compliant to the documentation about Floating Point

The link to the review is missing and the review never made it to the cfe-commits mailing list before being landed. This was also reverted in 0425087b8bac03693976ea34c156ca149482c853 and but maybe was fixed by the changes landed in 438437cbb61a39ce27b3d6218ac426b8f8a0132e? ~Aaron On Mon, Nov 8,

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

Szelethus created this revision. Szelethus added reviewers: NoQ, steakhal, dkrupp, martong, vsavchenko, balazske. Szelethus added a project: clang. Herald added subscribers: manas, ASDenysPetrov, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, w

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14563 -if (isa(Order)) { - int ord = cast(Order)->getZExtValue(); +switch (BuiltinID) { +case AMDGPU::BI__builtin_amdgcn_atomic_inc32: RKSimon wrote: > @saiislam @arsenm

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3112315 , @v.g.vassilev wrote: > In D112349#3111927 , @erichkeane > wrote: > >> In D112349#3111873 , @ibookstein >> wrote: >> >>>

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

sdesmalen added a comment. It would be nice if the LLVM interfaces could be updated as well (could also be done in a follow-up patch) From: std::pair getVScaleRangeArgs() To: Optional getVScaleRangeMax(); unsigned getVScaleRangeMin(); Since that would simplify some of the queries to th

[PATCH] D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment.

Anastasia added a comment. Just to elaborate on the problem that is being solved. We have ended up with cycling dependencies between `LangOptions` and `TargetInfo` i.e. some language options became dependent on the target and vice versa. The quick solution has always been to mutate the target a

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Anastasia added a comment. Ping, @Topotuna do you still plan to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110184/new/ https://reviews.llvm.org/D110184 ___ cfe-commits mailing list cfe-co

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Hmm, something is still bad. F20158447: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks great. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155 -/// Look through conversion/copy constructors to find the explicit +/// Look t

[clang] a12bfac - [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

Author: Denys Petrov Date: 2021-11-08T16:17:55+02:00 New Revision: a12bfac292db2195d3461dce51467d350de865dc URL: https://github.com/llvm/llvm-project/commit/a12bfac292db2195d3461dce51467d350de865dc DIFF: https://github.com/llvm/llvm-project/commit/a12bfac292db2195d3461dce51467d350de865dc.diff

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa12bfac292db: [analyzer] Retrieve a value from list initialization of multi-dimensional array… (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

tschuett added a comment. It would enforce that there is exactly module mode live. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/ https://reviews.llvm.org/D113391 ___ cfe-commits mailing list

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Topotuna added a comment. In D110184#3115361 , @Anastasia wrote: > Ping, @Topotuna do you still plan to commit this? Ah, yes. I will commit it in the next couple of days as well as D110155 Repository: rG LLVM Githu

[clang] c3b15b7 - [NFC] Inclusive Language: change master to main for .chm files

Author: Quinn Pham Date: 2021-11-08T08:23:04-06:00 New Revision: c3b15b71ce009b3dff9fb3bd664d087057b8376e URL: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e DIFF: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e.diff LO

[clang-tools-extra] c3b15b7 - [NFC] Inclusive Language: change master to main for .chm files

Author: Quinn Pham Date: 2021-11-08T08:23:04-06:00 New Revision: c3b15b71ce009b3dff9fb3bd664d087057b8376e URL: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e DIFF: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e.diff LO

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385478. ZarkoCA retitled this revision from "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist " to "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist". ZarkoCA added a comme

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385479. ZarkoCA added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

aaron.ballman added a comment. In D113168#3114626 , @ikudrin wrote: > We've noticed binary differences in `clang` in several builds on our local > build bots, and the patch fixed that. > > As for generating the documentation, the issue can be seen, for e

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

Szelethus updated this revision to Diff 385481. Szelethus added a comment. Fix incorrect sectioning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113397/new/ https://reviews.llvm.org/D113397 Files: clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/checkers.rst ===

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 385483. hliao added a comment. Rebase and kindly PING for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/CodeGen/thinlto-distributed-newpm.

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev planned changes to this revision. kbobyrev added a comment. Will split the patch in two, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112707/new/ https://reviews.llvm.org/D112707

[clang] 2c37ae6 - [nfc] Refactor CGGPUBuiltin to help review D112680

Author: Jon Chesterfield Date: 2021-11-08T15:00:08Z New Revision: 2c37ae6d14cf263724720f56fc34b4579a6e5c1c URL: https://github.com/llvm/llvm-project/commit/2c37ae6d14cf263724720f56fc34b4579a6e5c1c DIFF: https://github.com/llvm/llvm-project/commit/2c37ae6d14cf263724720f56fc34b4579a6e5c1c.diff L

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

Szelethus updated this revision to Diff 385486. Szelethus added a comment. Add context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113397/new/ https://reviews.llvm.org/D113397 Files: clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/checkers.rst

[PATCH] D113195: [clang-tidy] Add check for initialization of `absl::Cleanup`.

CJ-Johnson marked 4 inline comments as done. CJ-Johnson added a comment. Thanks for the review! I'll apply the same fixes to the string_view diff as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113195/new/ https://reviews.llvm.org/D113195 __

[PATCH] D113195: [clang-tidy] Add check for initialization of `absl::Cleanup`.

CJ-Johnson updated this revision to Diff 385487. CJ-Johnson added a comment. Address nits and update the absl::Cleanup stub to be accurate with the real interface (with associated changes to the AST matcher) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks great. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113397/new/ https://reviews.llvm.org/D113397 ___ cfe-commits mailin

[PATCH] D113195: [clang-tidy] Add check for initialization of `absl::Cleanup`.

CJ-Johnson updated this revision to Diff 385489. CJ-Johnson added a comment. Fix documentation nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113195/new/ https://reviews.llvm.org/D113195 Files: clang-tools-extra/clang-tidy/abseil/AbseilTidyMo

RE: [PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

Thanks, Aaron. I'll check this out. -Original Message- From: Aaron Ballman via Phabricator Sent: Monday, November 8, 2021 3:48 AM To: Pagan, David ; a.bat...@hotmail.com; jdoerf...@anl.gov Cc: stefomeis...@gmail.com; cfe-commits@lists.llvm.org; llvm-comm...@lists.llvm.org; yaxun@am

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231 + VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr, Size})); +} S

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385495. CJ-Johnson added a comment. Update test file to use truncated messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tid

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Thanks for the review! Couple of helpers to split out and the rebase on main is messy, retesting now Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231 + VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr, Size})); +} --

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

thakis added a comment. This fixes tests on macOS, but I don't know if the space is there intentionally to check for presence of any attributes: % git diff diff --git a/clang/test/CodeGen/ffp-contract-option.c b/clang/test/CodeGen/ffp-contract-option.c index 04d23d5f90b7..327722f56f4e 100

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeVirtualGPU.cpp:54 + CGOpenMPRuntime::createOffloadEntry(ID, Addr, Size, Flags, Linkage); +} We should be able to get rid of this file (and the cuda/hip) version. Might be the right ti

[clang-tools-extra] 16b07c8 - [clang-tidy] Add check for initialization of `absl::Cleanup`.

Author: CJ Johnson Date: 2021-11-08T15:57:32Z New Revision: 16b07c866ae74e0d02038574fe1c37a6cb55e233 URL: https://github.com/llvm/llvm-project/commit/16b07c866ae74e0d02038574fe1c37a6cb55e233 DIFF: https://github.com/llvm/llvm-project/commit/16b07c866ae74e0d02038574fe1c37a6cb55e233.diff LOG: [c

[PATCH] D113195: [clang-tidy] Add check for initialization of `absl::Cleanup`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16b07c866ae7: [clang-tidy] Add check for initialization of `absl::Cleanup`. (authored by CJ-Johnson, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385505. JonChesterfield added a comment. - rebase, static functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. @tra Any further concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone updated this revision to Diff 385508. davidstone added a comment. Take into account Richard's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInstanti

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385512. JonChesterfield added a comment. - helper for nonscalars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp cl

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a subscriber: ronlieb. JonChesterfield added a comment. Updated. Left Builder.CreateCall alone as I've failed to think of a clean way to handle the sometimes present size argument. Tests pass locally and are a credible guess at what will pass the CI bot, but may need to rol

[clang] 190bde4 - Revert "Making the code compliant to the documentation about Floating Point"

Author: Aaron Ballman Date: 2021-11-08T11:43:49-05:00 New Revision: 190bde404c67527c0a15b1ccbcb5af025aadcdd7 URL: https://github.com/llvm/llvm-project/commit/190bde404c67527c0a15b1ccbcb5af025aadcdd7 DIFF: https://github.com/llvm/llvm-project/commit/190bde404c67527c0a15b1ccbcb5af025aadcdd7.diff

Re: [clang] 438437c - Making the code compliant to the documentation about Floating Point

FWIW, I reverted this in 190bde404c67527c0a15b1ccbcb5af025aadcdd7 as it didn't fix the bots fully. ~Aaron On Mon, Nov 8, 2021 at 8:35 AM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2021-11-08T08:35:19-05:00 > New Revision: 438437cbb61a39ce27b3d6218ac426b8

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. Ping. Does anyone know how to check the status of`-fno-strict-aliasing` flag from CSA side? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110927/new/ https://reviews.llvm.org/D110927 ___ cfe-commits mailing lis

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

erichkeane added a comment. Either this or D108453 (which were committed together!) caused this assert according to my git-bisect: https://godbolt.org/z/4rqYKfW7K NOTE that this fails in a lit-test for me, clang CodeGen/ifunc.c (though my downstream seems to

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3115814 , @erichkeane wrote: > Either this or D108453 (which were > committed together!) caused this assert according to my git-bisect: > https://godbolt.org/z/4rqYKfW7K > > NOT

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385525. JonChesterfield added a comment. - fold nvptx and openmp printf into one call - Drop ReturnValue argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D1126

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Folded EmitOpenMPDevicePrintfCallExpr and EmitNVPTXDevicePrintfCallExpr into asserts plus one line call into a common function. Leaving amdgpu alone in this patch as it's doing something odd with getScalarVal and I don't want to run this through the internal CI

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-stringview-nullptr.cpp:84 + +(void)(std::string_view({nullptr})) /* a3 */; +// CHECK-MESSAGES: :[[@LINE-1]]:29: warning: constructing basic_string_view from null is undefin

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385530. CJ-Johnson added a comment. Add AST matcher support and tests for {{}} case where a null pointer is implicitly created Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385531. CJ-Johnson added a comment. Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidy

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385532. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D113264: [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I'd appreciate if you'd fix the clang-format issues when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113264

[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from commenting nit. Comment at: clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp:235 - // std::string IncludeArg = Twine("-I" + WorkingDi

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2db66f8d48be: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833

[clang] 2db66f8 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-11-08T17:43:51Z New Revision: 2db66f8d48beeea835cb9a6940e25bc04ab5d941 URL: https://github.com/llvm/llvm-project/commit/2db66f8d48beeea835cb9a6940e25bc04ab5d941 DIFF: https://github.com/llvm/llvm-project/commit/2db66f8d48beeea835cb9a6940e25bc04ab5d941.diff L

[clang] 8d3b28e - [NFC] Fix lit test failures for clang/CodegenCoroutines

Author: hyeongyu kim Date: 2021-11-09T02:47:16+09:00 New Revision: 8d3b28e7547aac842ed177050ac2a9d25de0f2e9 URL: https://github.com/llvm/llvm-project/commit/8d3b28e7547aac842ed177050ac2a9d25de0f2e9 DIFF: https://github.com/llvm/llvm-project/commit/8d3b28e7547aac842ed177050ac2a9d25de0f2e9.diff

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1845 + if (auto *Call = dyn_cast(U)) +FAM.invalidate(*Call->getParent()->getParent(), FuncPA); +} nikic wrote: > Do we need to worry about indirect references h

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385539. aeubanks added a comment. address comments [argpromo] only invalidate direct callers that call the function, not if the function is a parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113304/new/

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385541. ibookstein added a comment. clang-format + fastforward rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. @craig.topper - ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

  1   2   >