JonChesterfield added a comment.
I don't know about the MLIR parts, but replacing
> find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS
> /opt/rocm)
with
> find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS
> ${ROCM_PATH})
seems an improvement, where ROCM_PATH is ideally a CMake variable spelled the
same way in other components, such that someone can build an LLVM with the
components all hooked into a specific ROCm location
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109885/new/
https://reviews.llvm.org/D109885
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
