JonChesterfield added a comment.
Thanks for the review! Couple of helpers to split out and the rebase on main is
messy, retesting now
================
Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231
+ VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr,
Size}));
+}
----------------
jdoerfert wrote:
> Suggestion: I feel this could be in a helper to avoid the duplication with
> the nvptx version. All but the extra argument is the same, no?
Nice spot, yes - the tails of the two functions can fold.
> // We don't know how to emit non-scalar varargs.
the block starting with that occurs three times in the files as of this diff,
probably also worth splitting out
================
Comment at: openmp/libomptarget/DeviceRTL/src/Debug.cpp:61
+}
}
----------------
jdoerfert wrote:
> Namespace above should include _OMP, be anonymous or the functions should be
> static.
Sure, will patch. I thought the DeviceRTL had an internalize call as part of
the build process which cuts out all the internal symbols but I might be
imagining that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112680/new/
https://reviews.llvm.org/D112680
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
