steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land.
Looks great. ================ Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155 -/// Look through conversion/copy constructors to find the explicit +/// Look through conversion/copy constructors and operators to find the explicit /// initialization expression, returning it is found. ---------------- I think it's called //conversion member functions//. ================ Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h:278 // General functions used by ForLoopIndexUseVisitor and LoopConvertCheck. -const Expr *digThroughConstructors(const Expr *E); +const Expr *digThroughConstructorsConversions(const Expr *E); bool areSameExpr(ASTContext *Context, const Expr *First, const Expr *Second); ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
