ChuanqiXu added a comment.
In D113391#3115080 <https://reviews.llvm.org/D113391#3115080>, @tschuett wrote:
> This sounds like an enum.
>
> enum class ModuleKind {
> C++20,
> Clang,
> Unsupported
> }
In fact, there is another value `ModuleTS`. But it looks not bad. And the
variable `CPlusPlusModules` and `ClangModules` comes from options directly (See
Options.td for details). So it looks like we couldn't eliminate
`CPlusPlusModules` and `ClangModules` after we introduce this enum. So the
overall complexity didn't get decreased to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113391/new/
https://reviews.llvm.org/D113391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
