JonChesterfield requested changes to this revision.
JonChesterfield added a reviewer: ronl.
JonChesterfield added a comment.
This revision now requires changes to proceed.
Marking as request changes because:
`if (DEFINED ENV{ROCM_PATH})`
Looking at environment variables is strictly worse than looking at cmake
variables. I think we should replace /opt/rocm with a cmake variable that
points to somewhere to find rocr/roct, and have no strong feelings about what
the cmake variable should be called
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109885/new/
https://reviews.llvm.org/D109885
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
