[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 370174. kito-cheng marked an inline comment as done. kito-cheng added a comment. Changes: - Check feature combination is valid. - Change return type of parseFeatures to llvm::Expected>. - Set default extension version in getExtensionVersion. Repository:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng marked 2 inline comments as done. kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:387 +ExtensionInfoIterator->Version.Minor); + if (ExtName == "e") +HasE = true; Jim wrote: > Does

[PATCH] D107547: [CodeGen] More bits for calling convention

Xinglong updated this revision to Diff 370177. Xinglong retitled this revision from "[CodeGen] Align calling convention bit-width to bitcode" to "[CodeGen] More bits for calling convention". Xinglong edited the summary of this revision. Xinglong added a comment. Some patch broken the single 32-bi

[PATCH] D107547: [CodeGen] More bits for calling convention

Xinglong marked an inline comment as done. Xinglong added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:562 /// The clang::CallingConv that this was originally created with. - unsigned ASTCallingConvention : 6; + unsigned ASTCallingConvention : 10

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

lkail added a comment. This looks has broken build if `-DBUILD_SHARED_LIBS=On` is specified. CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): "LLVMFrontendOpenMP" of type SHARED_LIBRARY depends on "LLVMPasses" (weak) "LLV

[PATCH] D109137: [clang] NFC: Remove duplicate DependentSizedMatrixType methods

c-rhodes created this revision. c-rhodes added a reviewer: fhahn. c-rhodes requested review of this revision. Herald added a project: clang. Inherited from MatrixType. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109137 Files: clang/include/clang/AST/Type.h Index: clang/

[PATCH] D107547: [CodeGen] More bits for calling convention

Xinglong updated this revision to Diff 370185. Xinglong marked an inline comment as done. Xinglong added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107547/new/ https://reviews.llvm.org/D107547 Files: clang/include/clang/CodeGen/CGFunctionInfo.h Index: clang/inc

[PATCH] D109137: [clang] NFC: Remove duplicate DependentSizedMatrixType methods

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109137/new/ https://reviews.llvm.org/D109137

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

lkail created this revision. lkail added reviewers: PowerPC, hubert.reinterpretcast, jsji, cebowleratibm, Jake-Egan. Herald added subscribers: jfb, kbarton, nemanjai. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://reviews

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

david-arm added a comment. Hi, this has broken the build for me too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107764/new/ https://reviews.llvm.org/D107764 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske updated this revision to Diff 370192. balazske added a comment. Using again bug type dependent note tag messages. Some new tests are added. The planned debug functions are not added yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106262/

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

avogelsgesang added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015 + "coroutine_traits defined in std::experimental namespace is deprecated. " + "Considering update libcxx and include instead of .">, + InGroup; Considerin

[PATCH] D108975: [clangd] Omit default template arguments from type hints

kadircet added a comment. thanks, lgtm! Comment at: clang-tools-extra/clangd/InlayHints.cpp:353 const HeuristicResolver *Resolver; PrintingPolicy TypeHintPolicy; + PrintingPolicy StructuredBindingPolicy; can we document why we need to policies here, prob

[libunwind] f5b997e - [Unwind] Harmonise exception class for EHABI spec.

Author: Daniel Kiss Date: 2021-09-02T11:31:03+02:00 New Revision: f5b997e6b7061323fff13fafcc0c311d9e78e848 URL: https://github.com/llvm/llvm-project/commit/f5b997e6b7061323fff13fafcc0c311d9e78e848 DIFF: https://github.com/llvm/llvm-project/commit/f5b997e6b7061323fff13fafcc0c311d9e78e848.diff L

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:683-685 + /// between \p CallEnterN and \p CallExitEndN. Mind that the stack frame + /// retrieved from a CallEnter is the *caller's* stack frame! The inlined

[libunwind] d212bdf - [libunwind] Compile with -Wunused-but-set-variable

Author: Daniel Kiss Date: 2021-09-02T11:43:20+02:00 New Revision: d212bdf82883c8880da5a2ee67ce6b7b9a239f88 URL: https://github.com/llvm/llvm-project/commit/d212bdf82883c8880da5a2ee67ce6b7b9a239f88 DIFF: https://github.com/llvm/llvm-project/commit/d212bdf82883c8880da5a2ee67ce6b7b9a239f88.diff L

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki created this revision. Herald added subscribers: Naghasan, dexonsmith, wenlei, Anastasia, arphaman, hiraditya. linjamaki requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add new architectures ‘spirv32’, ‘spirv64’

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam updated this revision to Diff 370219. saiislam added a comment. Added test cases for compatibility old and new formats of bundle entry id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 Files:

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:968 +// fixed one to make sure tests passes on different platform. +TU.ExtraArgs.push_

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015 + "coroutine_traits defined in std::experimental namespace is deprecated. " + "Considering update libcxx and include instead of .">, + InGroup; avogelsgesang

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! My concerns are addressed, looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D108695

[clang] 9722e8f - [clang] NFC: Remove duplicate DependentSizedMatrixType methods

Author: Cullen Rhodes Date: 2021-09-02T10:46:20Z New Revision: 9722e8ff9eab9ec9c0d8fc0008fd368f93210ba5 URL: https://github.com/llvm/llvm-project/commit/9722e8ff9eab9ec9c0d8fc0008fd368f93210ba5 DIFF: https://github.com/llvm/llvm-project/commit/9722e8ff9eab9ec9c0d8fc0008fd368f93210ba5.diff LOG:

[PATCH] D109137: [clang] NFC: Remove duplicate DependentSizedMatrixType methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9722e8ff9eab: [clang] NFC: Remove duplicate DependentSizedMatrixType methods (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There are some questions to answer here before proceeding: 1. Why do we not get paired vector loads and stores in the back end test cases for either little or big endian and rega

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a day or so before landing in case @rsmith spots something I've missed (the only change I wasn't 100% certain on was lifting the assert predicate; it seems

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Please update the description and commit message as to why this is being added. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -t

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna updated this revision to Diff 370237. Topotuna added a comment. Boolean variable renamed to `IsOpenCLC30Compatible`. `FIXME` comment added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109002/new/ https://reviews.llvm.org/D109002 Files: clang/lib/Sema/SemaType.cpp clang/t

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

jansvoboda11 updated this revision to Diff 370238. jansvoboda11 added a comment. Switch to unique_ptr, leave -fno-intergrated-cc1 behind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108918/new/ https://reviews.llvm.org/D108918 Files: clang/inc

[clang] 555a817 - [clang] NFC: Extract DiagnosticOptions parsing

Author: Jan Svoboda Date: 2021-09-02T14:37:14+02:00 New Revision: 555a817d1dac5d88fdb445cd7c93cf66b769bc37 URL: https://github.com/llvm/llvm-project/commit/555a817d1dac5d88fdb445cd7c93cf66b769bc37 DIFF: https://github.com/llvm/llvm-project/commit/555a817d1dac5d88fdb445cd7c93cf66b769bc37.diff L

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG555a817d1dac: [clang] NFC: Extract DiagnosticOptions parsing (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is disallowed in OpenCL C to declare static kernel functions and C++

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. Generally LGTM! I only have one suggestion regarding testing - I feel that it makes more sense to just omit the tests that are not specific to the target itself. This is mainly because SPIR-V is now inherited from SPIR so the same logic applies in most of places. I t

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2270-2274 + if (UseNewCC1Process) +*UseNewCC1Process = +Args.hasFlag(clang::driver::options::OPT_fno_integrated_cc1, + clang::driver::options::OPT_fintegrate

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added subscribers: svenvh, bader. Anastasia added a comment. CC: @bader @svenvh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 ___ cfe-commits mailin

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 added a comment. I think `ToolInvocation` is somewhat well-suited for the dependency scanner. It takes care of the `DiagnosticOptions` setup, running the driver, extracting source-reading cc1 command-line, creating `CompilerInvocation` and invoking the action itself. This is what w

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:281-288 /// Tells if the callee is one of the builtin new/delete operators, including /// placement operators and other standard overloads. static bool isStandardNewDelete(const Fu

[PATCH] D108976: [clang][tooling] Allow providing custom diagnostic options to ToolInvocation

jansvoboda11 updated this revision to Diff 370257. jansvoboda11 added a comment. Reorder patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108976/new/ https://reviews.llvm.org/D108976 Files: clang/include/clang/Tooling/Tooling.h clang/lib

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

jansvoboda11 added a comment. Tests that cover this functionality were moved into a follow-up patch D108974 . The reason is to avoid temporary regression pointed out here . Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108982: [clang][deps] Avoid creating diagnostic serialization file, add test

jansvoboda11 updated this revision to Diff 370260. jansvoboda11 added a comment. Split out tests into a separate patch in order to avoid temporary regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D10898

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, nice! Comment at: llvm/include/llvm/ADT/StringMap.h:301 + /// is inserted . + template void insert(InputIt First, InputIt Last) { +for (InputIt It = First; It != Las

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

jansvoboda11 updated this revision to Diff 370262. jansvoboda11 added a comment. Shuffling patches around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108974/new/ https://reviews.llvm.org/D108974 Files: clang/lib/Tooling/Tooling.cpp clang/un

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109085/new/ https://reviews.llvm.org/D109085 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea created this revision. labrinea added reviewers: llvm-commits, momchil.velikov. Herald added subscribers: dang, hiraditya, kristof.beyls. labrinea requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Recently a vulnerability issue

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

thakis marked an inline comment as done. thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109105/new/ https://reviews.llvm.org/D109105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

lei added a comment. Is it really necessary to add the BE checks in this patch if they are the same as LE checks? Why not just add it later when there is a diff seen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.

[clang] 9735198 - [clang-cl] Emit nicer warning on unknown /arch: arguments

Author: Nico Weber Date: 2021-09-02T10:37:32-04:00 New Revision: 973519826edb7690270261a5b3512f32ae64063c URL: https://github.com/llvm/llvm-project/commit/973519826edb7690270261a5b3512f32ae64063c DIFF: https://github.com/llvm/llvm-project/commit/973519826edb7690270261a5b3512f32ae64063c.diff LO

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG973519826edb: [clang-cl] Emit nicer warning on unknown /arch: arguments (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D109105?vs=370128&id=370267

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D107775#2967134 , @dgoldman wrote: >> I put a case for it in the declprinter so it is handled appropriately so it >> would get the pointee type, whereas before this was neglected. >> >> Other than that, there should be no

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch tests code in D108976 . This split

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

jansvoboda11 added a comment. Thanks for the reviews. I had to split out the tests from this patch into D109158 to prevent the temporary regression you pointed out. Your remarks should be addressed there. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 7d0e62b - [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Author: Kristóf Umann Date: 2021-09-02T16:56:32+02:00 New Revision: 7d0e62bfb773c68d2bc8831fddcc8536f4613190 URL: https://github.com/llvm/llvm-project/commit/7d0e62bfb773c68d2bc8831fddcc8536f4613190 DIFF: https://github.com/llvm/llvm-project/commit/7d0e62bfb773c68d2bc8831fddcc8536f4613190.diff

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d0e62bfb773: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus). Changed prior to commit: https:

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/54991/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D1086

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added a comment. In D104386#2977302 , @nemanjai wrote: > The idea with putting all of these in a separate function was to: > > 1. Make it easy to limit it to specific targets as I suggested above > 2. Have them all in one place to easily identify whic

[clang] 3891b45 - Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it"

Author: Kristóf Umann Date: 2021-09-02T17:19:49+02:00 New Revision: 3891b45a06f9192b7185d03269717cd60dfdea13 URL: https://github.com/llvm/llvm-project/commit/3891b45a06f9192b7185d03269717cd60dfdea13 DIFF: https://github.com/llvm/llvm-project/commit/3891b45a06f9192b7185d03269717cd60dfdea13.diff

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

arphaman added a comment. Could you add a test case for this change? Maybe a unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108976/new/ https://reviews.llvm.org/D108976 ___ cfe-commits mailing

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

arphaman added a comment. In D108976#2979867 , @arphaman wrote: > Could you add a test case for this change? Maybe a unit test? Ah I see, you mentioned that the tests are in a follow-up patch. Sorry about that. Repository: rG LLVM Github Monorepo C

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

arphaman accepted this revision. arphaman added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D108982 ___ cfe-commits mailing list cfe-commits

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Hi, Could anyone please review this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105092: [RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 370285. HsiangKai added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: llvm/include/llvm/IR/IntrinsicsRISCV.td llvm/lib/Target/RISCV/

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov updated this revision to Diff 370284. ASDenysPetrov retitled this revision from "[analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration." to "[analyzer] Retrieve a value from list initialization of constant array declaration in a globa

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

peixin added a comment. @Meinersbur Thanks a lot for your review and accepting this patch. BTW, I finished the implementation of the codegen of ordered construct for LLVM Flang and the OpenMP IRBuilder of ordered construct in this patch also works well for LLVM Flang. Is it OK to land this patc

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added a comment. Now this patch supports only one-dimensional arrays. Previously there were a bug when didn't take into account array's dimension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 _

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

peixin added a comment. Here is the PR for codegen of ordered construct for LLVM Flang: https://github.com/flang-compiler/f18-llvm-project/pull/1027. I create the PR on fir-dev branch since the test of lowering parse-tree to MLIR for LLVM Flang is still not supported in upstream llvm-project.

[PATCH] D109127: Use python 3 in add_new_check.py and rename_check.py

kbobyrev added a comment. Hey, thanks for noticing! Ugh, I think that's not good, I was trying to make sure the `io.open` piece really works with Python 2 and Python 3 as this was the purpose fo the patch :( I need t check that again, I think it's really unfortunate to lose Python 2 support if

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

kiranchandramohan added a comment. Thanks @peixin. I am going through the patch today and will accept or provide some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430 ___ cfe-commits mailin

[PATCH] D109128: [VFS] Use original path when falling back to external FS

varungandhi-apple added a comment. cc @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 123f811 - Try to unbreak Win build after 973519826edb76

Author: Nico Weber Date: 2021-09-02T12:06:53-04:00 New Revision: 123f811fe5b0ba33f271c1c6172e6dff1463717a URL: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a DIFF: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a.diff LO

[clang-tools-extra] e1bb54b - [clangd, llvm] Remove redundant calls to c_str() (NFC)

Author: Kazu Hirata Date: 2021-09-02T09:07:13-07:00 New Revision: e1bb54b5930544b48c3a94069c037648a6adfc65 URL: https://github.com/llvm/llvm-project/commit/e1bb54b5930544b48c3a94069c037648a6adfc65 DIFF: https://github.com/llvm/llvm-project/commit/e1bb54b5930544b48c3a94069c037648a6adfc65.diff L

[clang] e5438f3 - clang/win: Add __readfsdword to intrin.h

Author: Nico Weber Date: 2021-09-02T12:22:07-04:00 New Revision: e5438f386854136d848989315f53788808afa37a URL: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a DIFF: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a.diff LO

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5438f386854: clang/win: Add __readfsdword to intrin.h (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 370293. salman-javed-nz added a comment. Add additional checks in `test/clang-tidy/infrastructure/nolintbeginend.cpp` to check that error suppressions in one file are carried over when the file is `#included` in another file. Repository: rG LLVM

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +addSystemInclude(DriverArgs, CC1Args, PathCPP.str()); +CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__"); +return; Maybe a comment as to why we need this, somethin

[libunwind] 1bc175d - [Unwind] Cast exception class pointer for strcpy

Author: Hans Wennborg Date: 2021-09-02T19:01:30+02:00 New Revision: 1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f URL: https://github.com/llvm/llvm-project/commit/1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f DIFF: https://github.com/llvm/llvm-project/commit/1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f.diff

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl created this revision. jozefl added reviewers: asl, atrosinenko. Herald added a subscriber: hiraditya. jozefl requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. clang::driver::tools::getCPUName can now infer the CPU be

[clang] 37f23ea - [AIX][PowerPC] Define __powerpc and __PPC macros

Author: Jake Egan Date: 2021-09-02T13:32:35-04:00 New Revision: 37f23ea97fdef4484ef33877c6d8464beafd3b0f URL: https://github.com/llvm/llvm-project/commit/37f23ea97fdef4484ef33877c6d8464beafd3b0f DIFF: https://github.com/llvm/llvm-project/commit/37f23ea97fdef4484ef33877c6d8464beafd3b0f.diff LOG

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG37f23ea97fde: [AIX][PowerPC] Define __powerpc and __PPC macros (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://re

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang created this revision. Herald added subscribers: hoy, dexonsmith, wenlei, dang, guansong, yaxunl. weiwang requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. There are cases where no target c

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. gentle ping @tejohnson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. Our internal codebase never uses the target directive. Once the deferred diags is bypassed, we observed 18% e2e build time improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D10

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM too, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D108982 __

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108974/new/ https://reviews.llvm.org/D108974 __

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

dexonsmith accepted this revision. dexonsmith added a comment. In D108976#2979598 , @jansvoboda11 wrote: > Tests that cover this functionality were moved into a follow-up patch D108974 > . The reason is to avoid tempora

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. I'm guessing the tests were not pass on buildbot but passed on the author's side is due to the assertion was disabled on the author's side. Here is the patch for avoiding all the assertion errors and I'm able to get all the metadirective tests passed (and no regression for

[PATCH] D107547: [CodeGen] More bits for calling convention

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107547/new/ https://reviews.llvm.org/D107547 ___ cfe-commits mailing list cfe-commi

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. Hmm, I'm not sure that the limitations you outline in the description are the only problems that cause us to define the macro in the first place (though the lack of libc implementation was part of it). I'll try to dig up the original issues. Repository: rG LLVM Git

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

lebedev.ri added a comment. In D109175#2980333 , @weiwang wrote: > Our internal codebase never uses the target directive. Once the deferred > diags is bypassed, we observed 18% e2e build time improvement. Is that with `-fopenmp` or without? That seems,

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei created this revision. lei added reviewers: hubert.reinterpretcast, nemanjai, power-llvm-team. Herald added a subscriber: shchenz. lei requested review of this revision. Herald added a project: clang. Update clang to treat vector unsigned long long and friends as invalid for AlttiVec without V

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we obse

[clang] 5881dcf - Try to unbreak Win build differently after 973519826edb76

Author: Nico Weber Date: 2021-09-02T14:45:56-04:00 New Revision: 5881dcff7e76a68323edc8bb3c6e14420ad9cf7c URL: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c DIFF: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c.diff LO

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5881dcff7e76: Try to unbreak Win build differently after 973519826edb76 (authored by thakis). Herald added a project: clang. Herald added a subscribe

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei updated this revision to Diff 370349. lei added a comment. fix spelling in commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109178/new/ https://reviews.llvm.org/D109178 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370350. jozefl added a comment. Rebased onto current upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files: clang/include/clang/Basic/DiagnosticDriverKinds

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. I'm seeing a build failure coming out of this: > llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference to > type 'llvm::StringRef' cannot bind to a temporary of type 'llvm::StringRef' > > for (auto &feature : used.keys()) { Looks like pre-merg

[clang] df052e1 - Revert "Try to unbreak Win build differently after 973519826edb76"

Author: Geoffrey Martin-Noble Date: 2021-09-02T12:05:33-07:00 New Revision: df052e1732ab57f5d9c684ceeaed3ab39073cd9f URL: https://github.com/llvm/llvm-project/commit/df052e1732ab57f5d9c684ceeaed3ab39073cd9f DIFF: https://github.com/llvm/llvm-project/commit/df052e1732ab57f5d9c684ceeaed3ab39073cd

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

thakis added a comment. In D109167#2980560 , @GMNGeoffrey wrote: > I'm seeing a build failure coming out of this: > >> llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference >> to type 'llvm::StringRef' cannot bind to a temporary of

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey created this revision. Herald added subscribers: dexonsmith, mgrang. GMNGeoffrey requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Build should be fixed by https://github.com/llvm/llvm-project/commit/9d22754389

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 370353. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fixed minor formatting issue. 😅 (Perhaps this should be in the tests included with check-clang?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109181/new/ https://reviews.llvm.org/D109181

  1   2   >