Xinglong marked an inline comment as done. Xinglong added inline comments.
================ Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:562 /// The clang::CallingConv that this was originally created with. - unsigned ASTCallingConvention : 6; + unsigned ASTCallingConvention : 10; ---------------- rjmccall wrote: > At some point, these bit-fields fit into a single 32-bit unit. There's > currently 33 bits, so that hasn't been true for a while, and we might as well > make all three of these fields 16 bits. > > It doesn't look like there's a good opportunity to pack the struct because > we're at an odd number of 32-bit chunks overall, so that'll do for now. Yes, 32-bit unit is broken, here use 16 bits is better and llvm backend need a patch to align to 16 bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107547/new/ https://reviews.llvm.org/D107547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
