hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, nice!
================
Comment at: llvm/include/llvm/ADT/StringMap.h:301
+ /// is inserted .
+ template <class InputIt> void insert(InputIt First, InputIt Last) {
+ for (InputIt It = First; It != Last; ++It)
----------------
nit: i think typename is more common than class in llvm code
unittests/ADT/StringMapTest.cpp has tests for the insert methods, maybe it's
worth adding one for this too (or the initializer_list one perhaps) even though
it's pretty trivial?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109105/new/
https://reviews.llvm.org/D109105
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
