kito-cheng marked 2 inline comments as done.
kito-cheng added inline comments.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:387
+ ExtensionInfoIterator->Version.Minor);
+ if (ExtName == "e")
+ HasE = true;
----------------
Jim wrote:
> Does this need to check it is invalid if XLen is 64?
Add check, and parseFeatures might return Error now.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:394
+ if (!HasE)
+ ISAInfo->addExtension("i", 2, 0);
+
----------------
Jim wrote:
> Why not get the version of i from SupportedExtensions?
Updated :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105168/new/
https://reviews.llvm.org/D105168
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
