nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. Please update the description and commit message as to why this is being 
added.



================
Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5
+// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \
+// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE
 
----------------
qiucf wrote:
> Seems just adding `%clang_cc1 -O3 -triple powerpc64-unknown-unknown 
> -target-cpu pwr10 -emit-llvm %s -o - | FileCheck %s` also makes the test 
> pass. `CHECK` and `CHECK-BE` contents are the same.
The existing builtins produce the same IR but I think this is done in 
preparation for https://reviews.llvm.org/D107647 which will add builtins very 
similar to these but that produce different IR on LE and BE. The description of 
the patch should probably mention that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109126/new/

https://reviews.llvm.org/D109126

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to