[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:100-101 Dyld += "tsan/"; +if (SanArgs.needsHwasanRt() && SanArgs.needsSharedRt()) + Dyld += "hwasan/"; Dyld += "ld.so.1"; Nit: can you move this above TSan so i

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:169 "bugprone-terminating-continue"); +CheckFactories.registerCheck( +"bugprone-thread-canceltype-asynchronous"); aaron.ballman wrote: >

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Hopefully it would be useful for new developers. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96944 Files: clang/docs/InternalsManual.

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:474 +// +// fu^(42) -> function(42); +if (Snippet->front() == '<') { -

[PATCH] D96838: CodeGen: Set !retain metadata on UsedAttr definitions for FreeBSD/Fuchsia/Linux

arichardson added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2071 + const llvm::Triple &T = getTarget().getTriple(); + if (T.isOSFreeBSD() || T.isOSLinux()) +GO->setMetadata(llvm::LLVMContext::MD_retain, phosek wrote: > Would it be pos

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

david-arm closed this revision. david-arm added a comment. Merged to LLVM Release 12.x branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96270/new/ https://reviews.llvm.org/D96270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 780ead4 - [Syntax] No crash on OpaqueValueExpr.

Author: Haojian Wu Date: 2021-02-18T10:32:04+01:00 New Revision: 780ead41e075eb7875874633cd9c6f2d5ceab95e URL: https://github.com/llvm/llvm-project/commit/780ead41e075eb7875874633cd9c6f2d5ceab95e DIFF: https://github.com/llvm/llvm-project/commit/780ead41e075eb7875874633cd9c6f2d5ceab95e.diff LO

[PATCH] D96112: [Syntax] No crash on OpaqueValueExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG780ead41e075: [Syntax] No crash on OpaqueValueExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

theraven added inline comments. Comment at: clang/include/clang/Driver/Options.td:2113 +def fno_objc_encode_cxx_class_template_spec : + Flag<["-"], "fno-objc-encode-cxx-class-template-spec">, Group; defm objc_convert_messages_to_runtime_calls : BoolFOption<"objc-convert-messag

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

kadircet added a comment. LG for the `blockUntilIdle` update, but feels like two patches wind up together :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96856/new/ https://reviews.llvm.org/D96856 ___

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:893 + for (llvm::Optional Timeout : + {TimeoutSeconds, TimeoutSeconds, llvm::Optional(0)}) { +if (!CDB.blockUntilIdle(timeoutSeconds(Timeout))) this is extending the

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM as well, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96568/new/ https://reviews.llvm.org/D96568 ___ cfe-commits mailing

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324582. lightmelodies added a comment. Change behavior of template and add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/

[clang] 5a4a014 - [OpenCL] Move printf declaration to opencl-c-base.h

Author: Sven van Haastregt Date: 2021-02-18T11:27:19Z New Revision: 5a4a01460f1a8f29db9aa3581097dd8bc105425c URL: https://github.com/llvm/llvm-project/commit/5a4a01460f1a8f29db9aa3581097dd8bc105425c DIFF: https://github.com/llvm/llvm-project/commit/5a4a01460f1a8f29db9aa3581097dd8bc105425c.diff

[PATCH] D96789: [OpenCL] Move printf declaration to opencl-c-base.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a4a01460f1a: [OpenCL] Move printf declaration to opencl-c-base.h (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Move any remaining preprocessor defines from `opencl-c.h` to `opencl-c-base.h`, such

[clang] 4bd08da - [flang][driver] Add debug dump options

Author: Faris Rehman Date: 2021-02-18T11:33:24Z New Revision: 4bd08dab5ff99d094513f4adf4bf16bbce8f5a1f URL: https://github.com/llvm/llvm-project/commit/4bd08dab5ff99d094513f4adf4bf16bbce8f5a1f DIFF: https://github.com/llvm/llvm-project/commit/4bd08dab5ff99d094513f4adf4bf16bbce8f5a1f.diff LOG:

[PATCH] D96716: [flang][driver] Add debug dump options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bd08dab5ff9: [flang][driver] Add debug dump options (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.org/D96716?vs=324352

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

stuij updated this revision to Diff 324589. stuij added a comment. added unit tests for the cmdline args Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96784/new/ https://reviews.llvm.org/D96784 Files: clang/lib/Driver/ToolChains/Clang.cpp clan

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

stuij added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525 +void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs) { + if (!Args.hasFlag(options::OPT_faapcs_bitfield_width, DavidSpickett wrote: > Name this AddA

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman updated this revision to Diff 324590. FarisRehman added a comment. Rebase off main Rebase off main and add a comment to MeasurementVisitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96884/new/ https://reviews.llvm.org/D96884 Files

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia updated this revision to Diff 324591. Anastasia added a comment. Added corrections from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96616/new/ https://reviews.llvm.org/D96616 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersMa

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console svenvh wrote: > I wonder if we need to keep this example? You're not referring to it from > the text and it's not demonstrating any special flags anymor

[PATCH] D96906: [AMDGPU] gfx90a support

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8d9d50762c4: [AMDGPU] gfx90a support (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D96906?vs=324434&id=

[PATCH] D96906: [AMDGPU] gfx90a support

tra added a comment. This is a pretty huge patch, with no details in the commit log. One hour between sending the patch out and landing it is not sufficient for anyone to meaningfully review the patch and there are no mentions of the review done anywhere else. While the code only changes AMDGP

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added a comment. In D96906#2570086 , @tra wrote: > This is a pretty huge patch, with no details in the commit log. > > One hour between sending the patch out and landing it is not sufficient for > anyone to meaningfully > review the patch and th

[PATCH] D96906: [AMDGPU] gfx90a support

tra added a comment. In D96906#2570095 , @rampitec wrote: > It's a year of work necessarily downstream. Every line there was reviewed and > tested in the downstream. I understand no one can reasonably review something > that big, although I cannot break

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG766ee1096f0b: [Clang][RISCV] Define RISC-V V builtin types (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96884: [flang][driver] Add more -fdebug options

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for working on this @FarisRehman ! This semantics implemented here are identical to what `f18` does. `-fdebug-instrumented-parse` from `f18` becomes `-fdebug-parsing-log` in

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske updated this revision to Diff 324592. balazske added a comment. Moving to module `concurrency` from `bugprone`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/ https://reviews.llvm.org/D96719 Files: clang-tools-extra/clang-tidy

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev updated this revision to Diff 324593. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 Files: clang-too

[clang-tools-extra] 19db870 - [clangd] Drop template argument lists from completions followed by

Author: Kirill Bobyrev Date: 2021-02-18T13:06:11+01:00 New Revision: 19db870a0dd1416b2d4a346e2cb17be197193a94 URL: https://github.com/llvm/llvm-project/commit/19db870a0dd1416b2d4a346e2cb17be197193a94 DIFF: https://github.com/llvm/llvm-project/commit/19db870a0dd1416b2d4a346e2cb17be197193a94.diff

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19db870a0dd1: [clangd] Drop template argument lists from completions followed by < (authored by kbobyrev). Repository: rG LLVM Github Monorepo CH

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

DavidSpickett added a comment. LGTM with /// for the comments in the test. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525 +void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs) { + if (!Args.hasFlag(options::OPT_faapcs_bitfield_width, --

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

kadircet added a comment. thanks! i think this mostly looks great, leaving a couple of suggestions and questions in comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g

[PATCH] D96561: [clang-tidy] add -use-color option to clang-tidy-diff.py

ottojo added a comment. I can't commit this myself, as i don't have commit access to the repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96561/new/ https://reviews.llvm.org/D96561 ___ cfe-commits mai

[clang] b80357d - [PowerPC] Add option for ROP Protection

Author: Stefan Pintilie Date: 2021-02-18T12:15:50Z New Revision: b80357d46e229ace904a8580e0a93e3f9b91720b URL: https://github.com/llvm/llvm-project/commit/b80357d46e229ace904a8580e0a93e3f9b91720b DIFF: https://github.com/llvm/llvm-project/commit/b80357d46e229ace904a8580e0a93e3f9b91720b.diff LO

[PATCH] D96512: [PowerPC] Add option for ROP Protection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb80357d46e22: [PowerPC] Add option for ROP Protection (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder abandoned this revision. tbaeder added a comment. Thanks for the input everyone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96070/new/ https://reviews.llvm.org/D96070 ___ cfe-commits mailing l

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324599. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/test/symbols.test clang-tools-extra/clangd/unittests/FindSymbolsTest

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 ___ cfe-commits mailing list

[PATCH] D96950: [clang][CodeComplete] Ensure there are no crashes when completing with ParenListExprs as LHS

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96950 Files: clang/lib/Sema/SemaCodeComplete.

[PATCH] D94355: [Passes] Add relative lookup table generator pass

hans added a comment. Thanks for pushing this forward! I think this will be a nice transformation once all the details are worked out. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1

[PATCH] D96950: [clang][CodeComplete] Ensure there are no crashes when completing with ParenListExprs as LHS

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5258 // Peel off the ParenListExpr by chosing the last one, as they don't have a // predefined type. I think we should merge the two comments, something like... ``` /// If L

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

ASDenysPetrov added a comment. @steakhal > Could you please give a few links to some documentation about the functions > you are trying to model? Yes, you a re right. I've edited the summary with the link. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87146/new/ https://reviews.llvm.

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2568084 , @ASDenysPetrov wrote: > @jhenderson > >> @ASDenysPetrov, could you provide your link command-line for one of the >> tools that produces the failing message, please, e.g. llvm-ar? > > Here is ou

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

sammccall accepted this revision. sammccall added reviewers: rsmith, kadircet. sammccall added a comment. This revision is now accepted and ready to land. I've reviewed this previously and am happy with how it ended up. But Kadir's comments are good, and we should also wait a few days in case oth

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 324606. arnamoy10 added a comment. Added some setters to work with. Modified the test case to include `flang-new -fc1` as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files: clang/include/clang

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added inline comments. Comment at: flang/test/Semantics/mod-file-rewriter.f90:9 +! RUN: %flang-new -fsyntax-only -fdebug-module-writer %p/Inputs/mod-file-unchanged.f90 2>&1 | FileCheck %s --check-prefix CHECK_UNCHANGED +! RUN: %flang-new -fsyntax-only -fdebug-module-w

[PATCH] D35137: [Driver] Honor -isysroot for Linux targets

yan12125 abandoned this revision. yan12125 added a comment. Seems the issue has been fixed in https://reviews.llvm.org/D31495 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35137/new/ https://reviews.llvm.org/D35137 ___

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2569436 , @aeubanks wrote: > In D96803#2568179 , @zatrazz wrote: > >> In D96803#2566322 , @aeubanks wrote: >> >>> why is this now a module

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

awarzynski added a comment. Thank you for submitting this @arnamoy10 ! Comments inline. Comment at: clang/include/clang/Driver/Options.td:4232-4233 HelpText<"Use INTEGER(KIND=8) for the result type in size-related intrinsics.">; +def fdebug_module_writer : Flag<["-"],"fdebu

[PATCH] D96751: [clangd] Populate detail field in document symbols

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! This looks good to land as-is, I just have some suggestions where we may want to mark behavior to revisit later, and some places where we could trim the tests a bit. Do you have c

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev abandoned this revision. kbobyrev added a comment. Yeah this does indeed already work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commits ma

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ThreadCanceltypeAsynchronousCheck.cpp:38 +}; +const auto TryExpandAsInteger = +[](Preprocessor::macro_iterator It) -> Optional { balazske wrote: > aaron.ballma

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

sammccall updated this revision to Diff 324609. sammccall added a comment. Revert unintended changes, add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96856/new/ https://reviews.llvm.org/D96856 Files: clang-tools-extra/clangd/ClangdServer

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

sammccall added a comment. Doh, sorry about the garbled patch Comment at: clang-tools-extra/clangd/ClangdServer.cpp:893 + for (llvm::Optional Timeout : + {TimeoutSeconds, TimeoutSeconds, llvm::Optional(0)}) { +if (!CDB.blockUntilIdle(timeoutSeconds(Timeout))) ---

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:114 "cert-pos44-c"); + CheckFactories.registerCheck( +"cert-pos47-c"); 80-col issue? Comment at: clang-tools-extra/clang

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4232-4233 HelpText<"Use INTEGER(KIND=8) for the result type in size-related intrinsics.">; +def fdebug_module_writer : Flag<["-"],"fdebug-module-writer">, Group, + HelpText<"Enables showing d

[clang-tools-extra] af06ff1 - add -use-color option to clang-tidy-diff.py

Author: Jonas Otto Date: 2021-02-18T09:12:48-05:00 New Revision: af06ff1cf87ecd387a65a6f7d4d00e0b06e983fb URL: https://github.com/llvm/llvm-project/commit/af06ff1cf87ecd387a65a6f7d4d00e0b06e983fb DIFF: https://github.com/llvm/llvm-project/commit/af06ff1cf87ecd387a65a6f7d4d00e0b06e983fb.diff LO

[PATCH] D96561: [clang-tidy] add -use-color option to clang-tidy-diff.py

aaron.ballman closed this revision. aaron.ballman added a comment. In D96561#2571193 , @ottojo wrote: > I can't commit this myself, as i don't have commit access to the repo. Thanks for letting me know -- I've commit on your behalf in af06ff1cf87ecd387a6

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein updated this revision to Diff 324616. hokein marked 4 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96944/new/ https://reviews.llvm.org/D96944 Files: clang/docs/Inte

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein added inline comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g. when the "declaration" part of the declaration contains semantic kadircet wrote:

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

DavidSpickett added a comment. The approach for xar looks fine to me, matches how we handled vcvt_n_* (https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vcvt_n_). Comment at: clang/include/clang/Basic/arm_neon.td:1139 +def BCAX : SInst<"

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; ahatanak wrote: > Quuxplusone wrote: > > (Moving into a thread) > > > > > This patch doesn't prevent

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ThreadCanceltypeAsynchronousCheck.cpp:38 +}; +const auto TryExpandAsInteger = +[](Preprocessor::macro_iterator It) -> Optional { aaron.ballman wrote: > balazske wro

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D96113#2569441 , @steveire wrote: > Update Thanks for the extra context, that's useful -- LGTM! Comment at: clang/

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ThreadCanceltypeAsynchronousCheck.cpp:38 +}; +const auto TryExpandAsInteger = +[](Preprocessor::macro_iterator It) -> Optional { balazske wrote: > aaron.ballma

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:108 + Diag << Inserter.createIncludeInsertion( + Result.SourceManager->getFileID(T.Range.getBegin()), T.Replacement); break; alexfh wr

[clang] e4d5f00 - [ASTMatchers] Fix hasParent while ignoring unwritten nodes

Author: Stephen Kelly Date: 2021-02-18T15:04:03Z New Revision: e4d5f00093bec4099f1d0496181dc670c42ac220 URL: https://github.com/llvm/llvm-project/commit/e4d5f00093bec4099f1d0496181dc670c42ac220 DIFF: https://github.com/llvm/llvm-project/commit/e4d5f00093bec4099f1d0496181dc670c42ac220.diff LOG:

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d5f00093be: [ASTMatchers] Fix hasParent while ignoring unwritten nodes (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; aaron.ballman wrote: > ahatanak wrote: > > Quuxplusone wrote: > > > (Moving into a thread) > > > > > >

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske updated this revision to Diff 324629. balazske marked 3 inline comments as done. balazske added a comment. - Fixed remaining formatting and rename problems. - Removed tryExpandAsInteger, use matcher instead. - Improved test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324626. lightmelodies added a comment. Better printing for C++ constructor and destructor. Remove unnecessary test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/cla

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak updated this revision to Diff 324628. ahatanak marked 2 inline comments as done. ahatanak added a comment. - Use `BoolFOption` to define both the positive and negative options. - Enable the optimization if the ObjC runtime is a NeXT-family runtime. Repository: rG LLVM Github Monorepo

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. In D96751#2571346 , @sammccall wrote: > Nice! This looks good to land as-is, I just have some suggestions where we > may want to mark behavior to revisit later, and some places where we could > trim the tests a bit. > > Do

[PATCH] D96751: [clangd] Populate detail field in document symbols

sammccall accepted this revision. sammccall added a comment. Fantastic, thank you! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:189 +if (isa(VD)) { + std::string CCD; + llvm::raw_string_ostream OSC(CCD); I think equivalent and a little saf

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. In D96751#2571563 , @sammccall wrote: > Fantastic, thank you! Maybe WithoutVoid.consume_front("void "); CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 ___

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; Quuxplusone wrote: > aaron.ballman wrote: > > ahatanak wrote: > > > Quuxplusone wrote: > > > > (Movin

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. Hi @Anastasia , thank you for working on this! IIUC, this patch introduces: - new input types: `TY_CLCXX` and `TY_CLCXXHeader` - new language: `OpenCLCXX` Based on the attached test, this is only to remove the need for `-cl-std=clc++`. Do you expect any other benefi

[clang] 5f7715d - Pass the cmdline aapcs bitfield options to cc1

Author: Ties Stuij Date: 2021-02-18T15:41:20Z New Revision: 5f7715d8780a1d16ad023995d282a7d94cb923a9 URL: https://github.com/llvm/llvm-project/commit/5f7715d8780a1d16ad023995d282a7d94cb923a9 DIFF: https://github.com/llvm/llvm-project/commit/5f7715d8780a1d16ad023995d282a7d94cb923a9.diff LOG: Pa

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f7715d8780a: Pass the cmdline aapcs bitfield options to cc1 (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D96784?vs=324589&id=324631#toc Repository: rG LLVM Github Monorepo

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Wow, that really simplified the implementation of the check nicely. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://reviews.llvm.org/D96816 __

[PATCH] D96751: [clangd] Populate detail field in document symbols

sammccall added a comment. In D96751#2571579 , @lightmelodies wrote: > In D96751#2571563 , @sammccall wrote: > >> Fantastic, thank you! > > Maybe WithoutVoid.consume_front("void "); Oh wow, yes... sizeof() was rea

[clang-tools-extra] 2e851c4 - [clangd] Populate detail field in document symbols

Author: lightmelodies Date: 2021-02-18T16:53:41+01:00 New Revision: 2e851c4172a35cc37fe6bf4ce8150c628fd66c0c URL: https://github.com/llvm/llvm-project/commit/2e851c4172a35cc37fe6bf4ce8150c628fd66c0c DIFF: https://github.com/llvm/llvm-project/commit/2e851c4172a35cc37fe6bf4ce8150c628fd66c0c.diff

[PATCH] D96751: [clangd] Populate detail field in document symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e851c4172a3: [clangd] Populate detail field in document symbols (authored by lightmelodies, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D96751?vs=324626&id=324639#toc Re

[PATCH] D96906: [AMDGPU] gfx90a support

foad added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.workitem.id.ll:23 + +; CO-V3: .amdhsa_system_vgpr_workitem_id 0 +; PACKED-TID: .amdhsa_system_vgpr_workitem_id 0 CO-V3 isn't tested by any RUN line. I think FileCheck might complain abou

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 324645. ldionne added a comment. Fix build on GCC (or at least I think it should) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 Files: libcxx/include/tuple libcx

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 324648. ldionne added a comment. Address Arthur's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 Files: libcxx/include/tuple libcxx/test/libcxx/utilitie

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. As far as content goes, here are my thoughts: There is a huge block of comments in the source code: https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Chec

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added a comment. LGTM other than the TargetInfo thing. Comment at: clang/include/clang/Basic/TargetInfo.h:1424 + triple.isAArch64(); + } + As I commented in the other patch, I think this would be cleaner in the long term if you just impleme

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Pos

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

tejohnson added a comment. I tend to like this approach better for the reasons listed in D96456 . @aeubanks any objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320

[clang] 46757cc - [clang] functions with the 'const' or 'pure' attribute must always return.

Author: Jeroen Dobbelaere Date: 2021-02-18T17:29:46+01:00 New Revision: 46757ccb49ab88da54ca8ddd43665d5255ee80f7 URL: https://github.com/llvm/llvm-project/commit/46757ccb49ab88da54ca8ddd43665d5255ee80f7 DIFF: https://github.com/llvm/llvm-project/commit/46757ccb49ab88da54ca8ddd43665d5255ee80f7.d

[PATCH] D96960: [clang] functions with the 'const' or 'pure' attribute must always return.

This revision was automatically updated to reflect the committed changes. Closed by commit rG46757ccb49ab: [clang] functions with the 'const' or 'pure' attribute must always return. (authored by jeroen.dobbelaere). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console Anastasia wrote: > svenvh wrote: > > I wonder if we need to keep this examp

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2571582 , @awarzynski wrote: > Hi @Anastasia , thank you for working on this! > > IIUC, this patch introduces: > > - new input types: `TY_CLCXX` and `TY_CLCXXHeader` > - new language: `OpenCLCXX` > > Based on the attach

  1   2   3   >