kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:893
+ for (llvm::Optional<double> Timeout :
+ {TimeoutSeconds, TimeoutSeconds, llvm::Optional<double>(0)}) {
+ if (!CDB.blockUntilIdle(timeoutSeconds(Timeout)))
----------------
this is extending the Deadline in theory, e.g. if user requested idleness in 10
seconds, this can now wait for up to 20 seconds. but this was possible in the
previous case too, e.g. CDB could block for 10 seconds, and then bgindex would
block for another 10 seconds, and mentioned this is only for tests, so should
be fine (but might be worth mentioning in the comments.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96856/new/
https://reviews.llvm.org/D96856
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
