arichardson added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2071 + const llvm::Triple &T = getTarget().getTriple(); + if (T.isOSFreeBSD() || T.isOSLinux()) + GO->setMetadata(llvm::LLVMContext::MD_retain, ---------------- phosek wrote: > Would it be possible to also include Fuchsia? Why does the IR metadata depend on the OS? Shouldn't this decision happen later? Alternatively maybe the check should be for ELF? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96838/new/ https://reviews.llvm.org/D96838 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
