svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console ---------------- Anastasia wrote: > svenvh wrote: > > I wonder if we need to keep this example? You're not referring to it from > > the text and it's not demonstrating any special flags anymore. > it's still demonstrating the use of default clang driver invocation i.e. > there are no flags needed to compile the code that uses BIFs. Okay, if you want to make that explicit then I would suggest to add a line like: ```The following example shows how an OpenCL program that calls various standard builtin functions can be compiled without the need for any explicit includes or compiler flags.``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96616/new/ https://reviews.llvm.org/D96616 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits