[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

balazske added a comment. I did not like this solution so I like it if we can omit this change and apply another fix (D69726 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D867

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

sdesmalen added inline comments. Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13 + +; ERR-NOT: TypeSize is not scalable + After your changes, what line causes this warning to be emitted? Does this test also pass with asserts enable

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 314329. serge-sans-paille added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D37479: run-clang-tidy: Report progress

florian.berchtold added a comment. This looks like a cool feature, why is it blocked? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37479/new/ https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] e43b3d1 - Revert "[Sema] Fix deleted function problem in implicitly movable test"

Author: Yang Fan Date: 2021-01-04T17:21:19+08:00 New Revision: e43b3d1f5e05c6e5e07cff054df193cf0d0c6583 URL: https://github.com/llvm/llvm-project/commit/e43b3d1f5e05c6e5e07cff054df193cf0d0c6583 DIFF: https://github.com/llvm/llvm-project/commit/e43b3d1f5e05c6e5e07cff054df193cf0d0c6583.diff LOG:

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm added inline comments. Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13 + +; ERR-NOT: TypeSize is not scalable + sdesmalen wrote: > After your changes, what line causes this warning to be emitted? Does this > test al

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added a comment. Does anyone have any feedback before I expand this to cover all the SSE2/AVX equivalents? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93597/new/ https://reviews.llvm.org/D93597 __

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

steven.zhang added a comment. Some code style comments. Comment at: clang/include/clang/Driver/Options.td:2603 def mno_spe : Flag<["-"], "mno-spe">, Group; +def mefpu2 : Flag<["-"], "mefpu2">, Group; def mabi_EQ_vec_extabi : Flag<["-"], "mabi=vec-extabi">, Group, Flags<[CC1O

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 314349. achieveartificialintelligence marked 2 inline comments as done. achieveartificialintelligence added a comment. Including Zfinx, zdinx. Zfhinx. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llv

[PATCH] D94011: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In implicitly movable test, a two-stage overload resolution is performed. If the first overload resolution selects a deleted function, Clang dire

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:983 + } + return Match_InvalidOperand; It seems like that this function is not useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https:/

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. I don't really have any objections to this, but if there is a similar options to GCC, I would hope that they are the same. Please add a comment in the commit message to that end. Other tha

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. In D93298#2457925 , @kito-cheng wrote: > Do you have implement register pair for rv32ifd_zfinx? I didn't saw the > related implementation, but I

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. Your tests look like copies of the F/D/Zfh tests with not all the comments updated and instances of tests that just don't make sense for Zfinx. I only skimmed them and picked up a few issues, I haven't gone through them thoroughly, please do that yourself. ===

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis updated this revision to Diff 314354. joechrisellis marked 2 inline comments as done. joechrisellis added a comment. Address @c-rhodes's comments. - Make comment clearer. - Change structure of the if statements for better readability. - Drop superfluous `this->`. Repository: rG

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 314356. DavidTruby added a comment. Refactor based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/ABIInfo.h clang/li

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby marked an inline comment as done. DavidTruby added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5158-5160 // For compatibility with GCC, ignore empty bitfields in C++ mode. if (getContext().getLangOpts().CPlusPlus && FD->isZero

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp:493 +struct Empty {}; +// A class with a base is returned in standard registers by MSVC +struct HasEmptyBase : public Empty { rnk wrote: > This comment doesn't se

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. In D93298#2477105 , @jrtc27 wrote: > Your tests look like copies of the F/D/Zfh tests with not all the comments > updated and instances of tests that just don't make sense for Zfinx. I only > skimmed them an

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch added a comment. Regarding similar GCC options: AFAIK GCC has had the spe options -msingle-float and -mdouble-float until spe support was dropped after version 8.3. These options would kind of match here, but they are already used as MIPS subtarget features in LLVM and I was not able to

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1663 +OperandMatchResultTy RISCVAsmParser::parseGPRasFPR(OperandVector &Operands) { + switch (getLexer().getKind()) { jrtc27 wrote: > Why can't you just use parseR

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 314357. DavidTruby added a comment. Switch from CHECK to CHECK-LABEL in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1663 +OperandMatchResultTy RISCVAsmParser::parseGPRasFPR(OperandVector &Operands) { + switch (getLexer().getKind()) { StephenFan wrote: > jrtc27 wrote: > > Why can

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return MarshallingInfo:

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314361. tinloaf added a comment. Address reviewer comments, noteworthy changes: - Add an option to span alignment only across comments, not across newlines - Factor out spanning options to `AlignTokens` to an enum Repository: rG LLVM Github Monorepo CH

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

c-rhodes accepted this revision. c-rhodes added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCall.cpp:2706 + ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector( +VecTyTo, Coerced, Ze

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 5 inline comments as done. tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:130 +/// \endcode +ACA_AcrossComments + }; MyDeveloperDay wrote: > tinloaf wrote: > > MyDeveloperDay wrote: > > > Is there a case for

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis updated this revision to Diff 314365. joechrisellis added a comment. Address @c-rhodes's comment. - Use name `castFixedSve` instead of `castScalableSve`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92762/new/ https://reviews.llvm.o

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis marked an inline comment as done. joechrisellis added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2671-2673 + // See if this is a VLST coerced to a VLAT at the function boundary and + // the types match up. If so, use llvm.experimental.vector

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 added a comment. This will make more sense after looking at D84673 . In short: parsing of diagnostic options can happen outside of `CompilerInvocation::createFromArgs`, that's why `ParseDiagnosticArgs` is a free function. Ideally, we'd like to reuse

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2468424 , @jrtc27 wrote: >> However, that's not the same as whether we're on an x86_64 system or on an >> x32 system determines which GNU triplet to use and which include and library >> search paths are our primary one

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT, ME

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2674 + // perform the conversion. + if (Ty->getAs()) { +auto *Coerced = Fn->getArg(FirstIRArg); joechrisellis wrote: > c-rhodes wrote: > > Do we want to check `VT->getVecto

[PATCH] D93637: [libTooling] Add support for smart pointers to releveant Transformer `Stencil`s.

tdl-g added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:273 + std::string Snippet = R"cc( +Smart x; +x; You're only testing the "QuacksLike" case. I suspect you should have tests that validate the "KnownSmartPointers". Admitte

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins.c:815 +// Test constexpr handling. +#if defined(__cplusplus) && (__cplusplus >= 201103L) +constexpr __m128 test_constexpr_mm_add_ps(__m128 A, __m128 B) { What are these tests testing f

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2470048 , @vsavchenko wrote: > In D93630#2468853 , @aaron.ballman > wrote: > >> Yeah, I kind of figured that might be the cause. I'm not 100% convinced (one >> way or the o

[clang] 9f8c0d1 - DeclCXX - Fix getAs<> null-dereference static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2021-01-04T15:12:55Z New Revision: 9f8c0d15c7f706a124ba29e8f40dc1937cd5bd49 URL: https://github.com/llvm/llvm-project/commit/9f8c0d15c7f706a124ba29e8f40dc1937cd5bd49 DIFF: https://github.com/llvm/llvm-project/commit/9f8c0d15c7f706a124ba29e8f40dc1937cd5bd49.diff LOG:

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314377. tinloaf marked 3 inline comments as done. tinloaf added a comment. Fix bogus default case reported by clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > However, the mainstream compilers like GCC and Clang implement this as the > overflowed value, and some programmers also use this feature to do some > tricky things. hmm.. you mean if some -fwrapv flag is used right. yes I should disable this checking then.

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

JonChesterfield updated this revision to Diff 314379. JonChesterfield added a comment. - update test, fix whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93356/new/ https://reviews.llvm.org/D93356 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5]

Bdragon28 updated this revision to Diff 314247. Bdragon28 added a comment. Forcing retest again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/test/Driver/ppc-features.cpp llvm/include/ll

[PATCH] D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5]

This revision was automatically updated to reflect the committed changes. Closed by commit rG2288319733cd: [PowerPC] Enable OpenMP for powerpcle target. [5/5] (authored by Bdragon28). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for working on this @FarisRehman , LGTM! From what I can tell you also addressed the point that @tskeith raised (updated commit msg and added a dedicated test). Ccould you wa

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93356/new/ https://reviews.llvm.org/D93356 ___

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, I'm not sure if others have any further comments Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

[clang] 76bfbb7 - [libomptarget][amdgpu] Call into deviceRTL instead of ockl

Author: Jon Chesterfield Date: 2021-01-04T16:48:47Z New Revision: 76bfbb74d38b611f150e8e1a4becc11be95703da URL: https://github.com/llvm/llvm-project/commit/76bfbb74d38b611f150e8e1a4becc11be95703da DIFF: https://github.com/llvm/llvm-project/commit/76bfbb74d38b611f150e8e1a4becc11be95703da.diff L

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76bfbb74d38b: [libomptarget][amdgpu] Call into deviceRTL instead of ockl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

fhahn updated this revision to Diff 314389. fhahn added a comment. Add comment to tblgen change, remove trailing whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93014/new/ https://reviews.llvm.org/D93014 Files: clang/include/clang/Basi

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1911 +// vcmlaq{ROT}_lane +def : SOpInst<"vcmla" # ROT # "_lane", "...qI", "Q" # type, Op<(call "vcmla" # ROT, $p0, $p1, + (bitcast $p0, (dup_typed laneqty , (call "vget_lane"

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314393. hoy added a comment. Replacing linkage names for debug declaration as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoM

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. I left a few nits, but otherwise LGTM! Comment at: clang/lib/Driver/ToolChains/Flang.cpp:25 Args.AddAllArgs(CmdArgs, {options::OPT_D, options::OPT_U}); + Args.AddAllArgs(CmdArgs, options::OPT_I); } [nit] This probably can be mer

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2477383 , @MyDeveloperDay wrote: > Ideally we should add a comment to the release notes, (which you could do via > a separate NFC commit if you wanted) Thank, I'll do that. But before that, I will create a revision tha

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93232/new/ https://reviews.llvm.org/D93232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg marked an inline comment as done. thezbyg added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins.c:815 +// Test constexpr handling. +#if defined(__cplusplus) && (__cplusplus >= 201103L) +constexpr __m128 test_constexpr_mm_add_ps(__m128 A, __m128 B) { pengfei wrote: > What are thes

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:478-487 +} else if (auto *LE = dyn_cast(S)) { + + for (unsigned I = 0, N = LE->capture_size(); I != N; ++I) { +const auto *C = LE->capture_begin() + I; +{ +

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jdoerfert added a comment. 2021 ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93785/new/ https://reviews.llvm.org/D93785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check

aaron.ballman added a comment. In D91000#2469898 , @lebedev.ri wrote: > I think the question is, *why* are these checks being implemented? > Just to claim that for some particular rule there is a check, and cross it > off a list? > Or for them to be actua

[PATCH] D93765: [NFC, Refactor] Modernize StorageClass from Specifiers.h to a scoped enum (II)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/include/clang/AST/Decl.h:1078 -return getStorageClass() >= SC_Auto; +return getStorageClass() >= St

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up to D93656 , I'm switching the Clang UniqueInternalLinkageNamesPass scheduling

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

aaron.ballman added a comment. Could you give me a bit more background about why you want to make this change? There are tests which I would expect to match in any traversal mode (e.g., `EXPECT_TRUE(matches("class X {};", traverse(TK_AsIs, HasClassX)));`) so there's a part of me that wonders if

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5681 + trusted compute base (TCB) does not call out of the TCB. This generates a + warning everytime a function not marked with an enforce_tcb attribute is + called from a function with the

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. This seems reasonable to me, but I wonder if there's a way we can add test coverage for the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-commits maili

[PATCH] D94021: [OpenCL] Add clang extension for function pointers

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, kerbowa, yaxunl, nhaehnle, jvesely, jholewinski. Anastasia requested review of this revision. This feature is primarily important in C++ mode because it opens up more opportunities to desc

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 314413. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:858 +def err_pragma_pack_invalid_alignment : Error< + "expected #pragma pack parameter to be '1', '2', '4', '8', or '16'">; def warn_pragma_pack_non_default_at_include : Warning< -

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

dmajor added a comment. Before the revert, our bots hit the following issue where we only error out when `-Wall` is given, so there's definitely something strange going on. Also happens with @Quuxplusone's suggested change applied. $ cat test.cpp template < class > class RefPtr { public:

[clang] 4034f92 - Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

Author: Hongtao Yu Date: 2021-01-04T12:04:46-08:00 New Revision: 4034f9273edacbb1c37acf19139594a226c8bdac URL: https://github.com/llvm/llvm-project/commit/4034f9273edacbb1c37acf19139594a226c8bdac DIFF: https://github.com/llvm/llvm-project/commit/4034f9273edacbb1c37acf19139594a226c8bdac.diff LO

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4034f9273eda: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:34 +std::is_base_of, T>::value +&&std::is_base_of::value; + Comment at: clang-tools-extra/clang-tidy/misc/Mi

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

rnk added a comment. Thank for the update, apologies for not providing these suggestions the first time. Comment at: clang/lib/CodeGen/CGCXXABI.cpp:320-321 + // No virtual functions + // Additionally, we need to ensure that there is a trivial copy assignment + // operator

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314431. Conanap marked 4 inline comments as done. Conanap added a comment. Addressed some comments for formatting and style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PP

[PATCH] D94027: [OpenCL] Add clang extension for variadic function

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, kerbowa, yaxunl, nhaehnle, jvesely, jholewinski. Anastasia requested review of this revision. This feature is primarily important in C++ mode because it opens up more opportunities to desc

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap marked an inline comment as done. Conanap added a comment. initialize as a form of undef instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D93986#2477474 , @tinloaf wrote: > In D93986#2477383 , @MyDeveloperDay >

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added a comment. Some minor nits while double-checking the attribute bits. Comment at: clang/include/clang/Basic/AttrDocs.td:2334 + +Here is the list of whatthis attribute supports, quoting the aformentioned +document: Comment

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1) thezbyg

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314439. Conanap added a comment. Removed unecessary ternary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/PowerPC/PPCInstrPrefix.td

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

tschuett added a comment. But LLVM is C++14: https://github.com/llvm/llvm-project/blob/main/llvm/docs/CodingStandards.rst#id13 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93597/new/ https://reviews.llvm.org/D93597 ___

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

erichkeane added a comment. In D93597#2477890 , @tschuett wrote: > But LLVM is C++14: > https://github.com/llvm/llvm-project/blob/main/llvm/docs/CodingStandards.rst#id13 The compiler _IS_ compiled with C++14, but the tests are not necessarily compiled as

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:40 + "kernel performance could be improved by unrolling this loop with a " + "#pragma unroll directive"); + break; =

[PATCH] D89490: Introduce __attribute__((darwin_abi))

emaste added a comment. > For now, only Linux/ARM64 is supported/tested. Is there any reason this is Linux-specific (as far as support; I understand if it's not easy for you to test on non-Linux arm64). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314443. Conanap added a comment. Fixed a typo that prevented successful builds CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/PowerPC/P

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added a comment. @dblaikie @MaskRay Anything else do I need to change, all good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 ___ cfe-commits mailing

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 314445. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/lib/AST

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 314446. steveire marked 2 inline comments as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMat

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added a comment. In D92936#2477764 , @dmajor wrote: > Before the revert, our bots hit the following issue where we only error out > when `-Wall` is given, so there's definitely something strange going on. https://godbolt.org/z/P1dv9f Yeah, I

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526 +TraverseStmt(LE->getTrailingRequiresClause()); + +TraverseStmt(LE->getBody()); aaron.ballman wrote: > Do we also n

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

steveire added a comment. In D93988#2477602 , @aaron.ballman wrote: > Could you give me a bit more background about why you want to make this > change? This change makes it explicit so that we can see which tests work in only one mode, and if we want t

[PATCH] D94029: [clang-tidy] Add extra tests

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By default, check_clang_tidy runs tests in c++11-or-later mode. Repos

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94030 Files: clang/include/clang/ASTMatch

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94031 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D94032: [ASTMatchers] Omit methods from explicit template instantations

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94032 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

fhahn updated this revision to Diff 314452. fhahn added a comment. Add tests for rotated lane variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93014/new/ https://reviews.llvm.org/D93014 Files: clang/include/clang/Basic/arm_neon.td clang

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

fhahn added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1911 +// vcmlaq{ROT}_lane +def : SOpInst<"vcmla" # ROT # "_lane", "...qI", "Q" # type, Op<(call "vcmla" # ROT, $p0, $p1, + (bitcast $p0, (dup_typed laneqty , (call "vget_lane", (bitc

  1   2   >