nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land.
I don't really have any objections to this, but if there is a similar options to GCC, I would hope that they are the same. Please add a comment in the commit message to that end. Other than that, LGTM. ================ Comment at: llvm/test/CodeGen/PowerPC/efpu2.ll:6 +; Single tests +; identical to tests in spe.ll + ---------------- It might make sense to just add a RUN line in that test case rather than stating in a comment that they are identical (i.e. they may not be identical if the original one changes down the road). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits