steveire marked an inline comment as done.
steveire added inline comments.
================
Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526
+ TraverseStmt(LE->getTrailingRequiresClause());
+
+ TraverseStmt(LE->getBody());
----------------
aaron.ballman wrote:
> Do we also need to traverse attributes of the lambda?
At least RAV doesn't do so. It would be a new feature which is orthogonal to
this MR/patch.
================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:3069
+
+ Code = R"cpp(
+void foo() {
----------------
aaron.ballman wrote:
> Do we have other test coverage for the rest of lambda matching, or should you
> add coverage for things like parameters, trailing requires clauses, etc?
Yep, there's other lambda-related tests higher up in this test function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93688/new/
https://reviews.llvm.org/D93688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
