aaron.ballman added a comment.

Could you give me a bit more background about why you want to make this change?

There are tests which I would expect to match in any traversal mode (e.g., 
`EXPECT_TRUE(matches("class X {};", traverse(TK_AsIs, HasClassX)));`) so 
there's a part of me that wonders if we should add helper functionality to test 
the various traversal modes as part of this change. e.g., we specify an 
explicit traversal mode for the situations where only one mode should be 
tested, and we specify a helper function that tests both traversal modes on the 
same code. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93988/new/

https://reviews.llvm.org/D93988

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to