DavidTruby added inline comments.
================
Comment at: clang/test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp:493
+struct Empty {};
+// A class with a base is returned in standard registers by MSVC
+struct HasEmptyBase : public Empty {
----------------
rnk wrote:
> This comment doesn't seem accurate to me, it's returned indirectly in memory,
> right? The test for it below uses sret. In other words, this class never hits
> the HVA codepath because the C++ ABI marks it indirect.
Yes, you're right. I wrote completely the opposite of what I meant here. I have
corrected it now!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92751/new/
https://reviews.llvm.org/D92751
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
