c-rhodes accepted this revision. c-rhodes added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/CodeGen/CGCall.cpp:2706 + ArgVals.push_back(ParamValue::forDirect(Builder.CreateExtractVector( + VecTyTo, Coerced, Zero, "castScalableSve"))); + break; ---------------- nit: I know we've used `cast<Fixed|Scalable>Sve` for `Name` in a couple of places already and it's not very descriptive, but I think it describes the type being cast to, in which case this should be `castFixedSve`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92762/new/ https://reviews.llvm.org/D92762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
