[clang] 40a3fcb - [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

Author: Djordje Todorovic Date: 2020-06-01T09:10:05+02:00 New Revision: 40a3fcb05c83c41862038277aa667c956e7cac82 URL: https://github.com/llvm/llvm-project/commit/40a3fcb05c83c41862038277aa667c956e7cac82 DIFF: https://github.com/llvm/llvm-project/commit/40a3fcb05c83c41862038277aa667c956e7cac82.d

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

This revision was automatically updated to reflect the committed changes. Closed by commit rG40a3fcb05c83: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:' (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8036

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

njames93 added a comment. This fix has expanded from preventing the crash to adding support for `CXXFoldExpr` to misc-redundant-expression. Maybe rename the revision to explain that better. If that is the case then you may as well add a test case showing a redundant fold expression

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/arm-bf16-params-returns.c:5 +// RUN: %clang_cc1 -triple aarch64-arm-none-eabi -target-abi aapcs -mfloat-abi softfp -target-feature +bf16 -target-feature +neon -emit-llvm -O2 -o - %s | opt -S -mem2reg -sroa | Fil

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

labrinea added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4493 + case NeonTypeFlags::BFloat16: +if (HasBFloat16Type) + return llvm::VectorType::get(CGF->BFloatTy, V1Ty ? 1 : (4 << IsQuad)); This is not what we should be checking for he

[PATCH] D80910: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover abandoned this revision. t.p.northover added a comment. Sorry. Keyboard decided to create diff before I'd filled everything in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80910/new/ https://reviews.llvm.org/D80910 __

[PATCH] D80910: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, jdoerfert, asbirlea, hiraditya, kristof.beyls, mcrosier. Herald added projects: clang, LLVM. t.p.northover abandoned this revision. t.p.northover added a comment. Sorry. Keyboard decided to creat

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

psmith added a comment. FWIW I'm happy for Clang to match GCC behaviour for Linux (non-Android) targets with respect to the frame pointer. Outside of Android I would expect most developers of linux applications to build with both GCC and clang so they should already have the -fno-omit-frame-poi

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover created this revision. Herald added subscribers: danielkiss, jdoerfert, asbirlea, hiraditya, kristof.beyls, mcrosier. Herald added projects: clang, LLVM. Some of the system registers readable on AArch64 & ARM platforms return different values with each read (for example a timer cou

[PATCH] D80800: Add an option to fully qualify classes and structs.

jblespiau marked an inline comment as done. jblespiau added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:326 + if (Policy.FullyQualifiedName && Policy.GlobalScopeQualifiedName && + T->isStructureOrClassType()) { +OS << "::"; jblespiau wrot

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis marked 2 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:18 +namespace no_crash { +struct Foo {}; I had to move this up as no warnings were generated in

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis updated this revision to Diff 267565. zinovy.nis added a comment. - Fix test. - Simplify the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-e

[PATCH] D80913: [update_cc_test_checks.py] Correctly skip function definitions

arichardson created this revision. arichardson added a reviewer: MaskRay. Herald added subscribers: llvm-commits, cfe-commits, kristof.beyls. Herald added projects: clang, LLVM. Function declarations can in fact have an 'inner' node that lists the ParmVarDecls. It seems like either the JSON output

[PATCH] D80914: [update_cc_test_checks.py] Handle C++ methods

arichardson created this revision. arichardson added a reviewer: MaskRay. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously the script only handled C input, this change extends the JSON parsing to to also include C++ function types such as methods,

[clang] e5b8772 - [utils] change default nameless value to "TMP"

Author: Sanjay Patel Date: 2020-06-01T06:54:45-04:00 New Revision: e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6 URL: https://github.com/llvm/llvm-project/commit/e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6 DIFF: https://github.com/llvm/llvm-project/commit/e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6.diff

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:114-115 // Convert the array length to size_t. NonLoc IndexLength = SVB.evalCast(SizeD, SizeTy, SizeE->getType()).castAs(); // Multiply the array length by the elem

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam created this revision. saiislam added reviewers: arsenm, sameerds, jdoerfert, yaxunl, b-sumner, scchan, JonChesterfield. Herald added subscribers: cfe-commits, sstefan1, kerbowa, guansong, nhaehnle, wdng, jvesely, jholewinski. Herald added a project: clang. saiislam added a parent revisi

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5b877275673: [utils] change default nameless value to "TMP" (authored by spatel). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

NoQ added a comment. I think this patch is a fairly historic moment to celebratte. > checker callback evaluation order is ensured And it will be the same for all callbacks, right? Like, we're not doing this thing yet where it intentionally goes like chk1->checkPreCall(); chk2->checkPreCall

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mati865 added a comment. Wouldn't it better fit in `AddLibGCC`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80880/new/ https://reviews.llvm.org/D80880 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

spatel reopened this revision. spatel added a comment. This revision is now accepted and ready to land. Effectively reverted (but still have the name conflict warning at least) with: rGe5b877275673 If we can change instnamer,

[PATCH] D80800: Add an option to fully qualify classes and structs.

sammccall added a comment. In D80800#2065643 , @jblespiau wrote: > I did spend a few hours, just building and finding how to run tests :( Sorry about that :-( For what it's worth, building with Ninja should be significantly faster by default: https://ll

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 267587. ASDenysPetrov added a comment. Updated due to comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Analysis/c

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! I like how it turned out, i guess let's prefer this to D79704 . Comment at: clang/include/clang/StaticAnalyzer/Core/PathSens

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mstorsjo added a comment. In D80880#2066078 , @mati865 wrote: > Wouldn't it better fit in `AddLibGCC`? `AddLibGCC` is called twice, and we already add `-lkernel32` (plus a bunch of other libraries) after the first invocation, so that would either add an

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. I don't know why `AddLibGCC` has to be called twice but that doesn't really matter for this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mstorsjo added a comment. In D80880#2066130 , @mati865 wrote: > I don't know why `AddLibGCC` has to be called twice but that doesn't really > matter for this diff. From the clang perspective, I guess it's to match GCC. Originally, I guess the reason is

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

erichkeane added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:65 -bool Unset; -K = Spelling.getValueAsBitOrUnset("KnownToGCC", Unset); } Doesn't this result in 'K' being uninitialized now? CHANGES SINCE LAST ACTION https

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Szelethus added a comment. >> checker callback evaluation order is ensured > > And it will be the same for all callbacks, right? Like, we're not doing this > thing yet where it intentionally goes like > > chk1->checkPreCall(); > chk2->checkPreCall(); > chk2->checkPostCall(); > chk1->che

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Szelethus added a comment. Mind that strong dependencies also ensure the order of evaluation, but that is a //guarantee// (**either** the dependency will be evaluated before the dependency, **or** none of them will be evaluated), and this patch is about //preference// (**if** both of them are e

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

erichkeane added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:65 -bool Unset; -K = Spelling.getValueAsBitOrUnset("KnownToGCC", Unset); } aaron.ballman wrote: > erichkeane wrote: > > Doesn't this result in 'K' being uninitializ

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:65 -bool Unset; -K = Spelling.getValueAsBitOrUnset("KnownToGCC", Unset); } erichkeane wrote: > aaron.ballman wrot

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3787 + ColIdx->getType()->getScalarSizeInBits()); + llvm::Type *IntTy = llvm::IntegerType::get(getLLVMContext(), MaxWidth); + RowIdx = Bui

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 267601. fhahn added a comment. Force index types to size_t in Sema, remove code to extend index values in Codegen. Update tests to check more targeted IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman updated this revision to Diff 267603. aaron.ballman added a comment. New and improved with proper member initialization in all constructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/ https://reviews.llvm.org/D80836 Files: clang/include/clang/Basic/Attr.td

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:65 -bool Unset; -K = Spelling.getValueAsBitOrUnset("KnownToGCC", Unset); } erichkeane wrote: > Doesn't this resul

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:80 DoubleAlign = LongLongAlign = LongDoubleAlign = SuitableAlign = 32; + BFloat16Width = BFloat16Align = 16; + BFloat16Format = &llvm::APFloat::BFloat(); --

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman updated this revision to Diff 267604. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Whoops, *now* I'm properly setting the bit from the record. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/ https://reviews.llvm.org/D80836 Files:

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman added a comment. In D80836#2064181 , @erichkeane wrote: > 1 more question, how did you arrive at the 'not supported in C' list? Did > you find some GCC docs for that (if so, please put in the commit message)? > Or did you just try them al

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mati865 added a comment. Thanks, sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80880/new/ https://reviews.llvm.org/D80880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman updated this revision to Diff 267606. aaron.ballman added a comment. Sorry for the back and forth, this Monday morning is not easy it seems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/ https://reviews.llvm.org/D80836 Files: clang/include/clang/Basic/Attr.td

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

jdoerfert added a comment. First, I think the warning is strictly a good thing. Thanks for keeping that in! I don't think the options are really "complexity to the user" given a sensible default (= the old value). If a user sees a warning that says: `Name conflict, use --nameless-prefix=X,

[clang] c0303e5 - [CodeGen] remove instnamer dependency from test file; NFC

Author: Sanjay Patel Date: 2020-06-01T10:21:17-04:00 New Revision: c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0 URL: https://github.com/llvm/llvm-project/commit/c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0 DIFF: https://github.com/llvm/llvm-project/commit/c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0.diff

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. Can you summarise where we are? I.e., - float-abi=soft doesn't work. But what is the problem? Are we not simply passing i16s, is that not what we are supposed to do? Can you also update the description of this patch, I got totally confused by: - "introduces an opa

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

Anastasia accepted this revision. Anastasia added a comment. In D79781#2063440 , @PiotrFusik wrote: > Bumped the OpenCL version from 1.2 to 2.0. Great! Thanks! Feel free to go ahead and commit this! Can you please add a link to the bug describing incorr

[PATCH] D80900: [clangd] Use different FS in PreambleThread

sammccall added a comment. TL;DR: I think there are three viable paths that we should consider: A) minimal change: put the FSProvider in ParseInputs B) this patch, but with more documentation and safety C) fight to clean up VFS multithreading semantics Assuming we don't want to block on C, I'm no

[clang] 522934d - Support GCC [[gnu::attributes]] in C2x mode

Author: Aaron Ballman Date: 2020-06-01T10:42:42-04:00 New Revision: 522934da1f0c78c1de1a80d4ba14204a11f5afa8 URL: https://github.com/llvm/llvm-project/commit/522934da1f0c78c1de1a80d4ba14204a11f5afa8 DIFF: https://github.com/llvm/llvm-project/commit/522934da1f0c78c1de1a80d4ba14204a11f5afa8.diff

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added a project: clang. Clang crashes when trying to finish function body. MaybeODRUseExprs is not empty because of const static data member parsed in outer evaluation context, upon call for isTypeIdInParens() functio

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked an inline comment as done. stuij added a comment. In D76077#2066323 , @SjoerdMeijer wrote: > Can you summarise where we are? I.e., > > - float-abi=soft doesn't work. But what is the problem? Are we not simply > passing i16s, is that not what

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review, I've commit in 522934da1f0c78c1de1a80d4ba14204a11f5afa8 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80836/new/ https://r

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

labrinea created this revision. labrinea added reviewers: fpetrogalli, LukeGeeson, stuij, momchil.velikov, SjoerdMeijer, miyuki. Herald added subscribers: hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch is part of a series implementing the Bfloat16 extension of the Armv8

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

ymandel added a comment. Thanks for the changes! In D80697#2062517 , @njames93 wrote: > There are a few reasons for using the virtual method: I think I'm missing something (or I didn't explain my intention well): > - It keeps everything contained in th

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 267627. fhahn added a comment. Ping :) Updated the patch to include the feedback from D76793 (adding overloads, conversions, more targeted tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D80931: AMDGPU: Fix clang side null pointer value for private

arsenm created this revision. arsenm added reviewers: cfe-commits, cdevadas. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. The change to fold_priv_arith looks strange to me, but this was already the untested behavior for local. https://revi

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader created this revision. bader added reviewers: Anastasia, keryell, Naghasan, asavonic, Fznamznon. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. This change enables conversion between OpenCL address spaces and default address space similar to conversion

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

LukeGeeson added a comment. A few nits, it looks largely uncontroversial but I'll let someone else give the ok since an external eye is always good :) Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. > At the moment when going through the GCC compatibility driver (standard > interface), we get __bf16 is not supported on this target. If this is the current behaviour, and consistent with GCC, that sounds reasonable. Probably best to be explicit about this and doc

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

labrinea added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1854 + def VDUP_LANE_BF : WOpInst<"vdup_lane", ".qI", "bQb", OP_DUP_LN>; + def VDUP_LANEQ_BF: WOpInst<"vdup_laneq", ".QI", "bQb", OP_DUP_LN> { +let isLaneQ = 1; My local build

[PATCH] D80490: [clang-tidy] Check for rule of five and zero.

jbcoe added a comment. https://reviews.llvm.org/D16376 was written by me, I'm afraid I don't recall why I abandoned it and was surprised to see that it had not been submitted. I don't feel comfortable approving work based on my own but this patch looks great to me. Repository: rG LLVM Githu

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

stefanp accepted this revision as: stefanp. stefanp added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80757/new/ https://reviews.llvm.org/D80757 ___ cfe-commits mailing list cfe-comm

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

spatel closed this revision. spatel added a comment. In D80584#2066319 , @jdoerfert wrote: > First, I think the warning is strictly a good thing. Thanks for keeping that > in! Sure - we've been missing that for a long time. > I don't think the options

[PATCH] D80490: [clang-tidy] Check for rule of five and zero.

jbcoe added a comment. Perhaps associated is https://github.com/isocpp/CppCoreGuidelines/issues/870 which was closed but never (in my mind) resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80490/new/ https://reviews.llvm.org/D80490 _

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, curdeius, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay added a reviewer: thopre. MyDeveloperDay edited the summary of this revision. https://bugs.llvm.org/show_b

[clang] ef1d4be - [Clang][CGM] style cleanups NFC

Author: Nick Desaulniers Date: 2020-06-01T09:33:08-07:00 New Revision: ef1d4bec891b2121fffa68675e3792b2527a75ee URL: https://github.com/llvm/llvm-project/commit/ef1d4bec891b2121fffa68675e3792b2527a75ee DIFF: https://github.com/llvm/llvm-project/commit/ef1d4bec891b2121fffa68675e3792b2527a75ee.di

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. In D76077#2066520 , @SjoerdMeijer wrote: > > At the moment when going through the GCC compatibility driver (standard > > interface), we get __bf16 is not supported on this target. > > If this is the current behaviour, and consisten

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: lei, stefanp, nemanjai, saghir, power-llvm-team. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. Herald added projects: clang, LLVM. amyk updated this revision to Diff 267648. amyk added a comment. Updated a typo within the

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk updated this revision to Diff 267648. amyk added a comment. Updated a typo within the comment in `llvm/test/CodeGen/PowerPC/p10-bit-manip-ops.ll`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80935/new/ https://reviews.llvm.org/D80935 Files

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

thopre added a comment. That was a speedy patch! I can confirm that my non reduced testcase (git diff -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b ^ 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = &llvm::cl::TokenizeWindowsCommandLine; Testing the triple is a functional

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

probinson added a comment. In D80242#2045362 , @nickdesaulniers wrote: > For C++, I'd imagine: > > class foo {}; > using my_foo = foo; > template > struct baz { > bar my_bar; > }; > > > but it seems that `g++` doesn't emit debug info the fo

[PATCH] D80840: [Clang][CGM] style cleanups NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGef1d4bec891b: [Clang][CGM] style cleanups NFC (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.o

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

jdoerfert added a comment. > I think we're good enough. I agree. If this doesn't bother anyone anymore there is no need for any options ;) Thanks for the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80584/new/ https://reviews.llvm.org/D80

RE: [clang-tools-extra] 8e325cf - [clangd] Work around PS4 -fno-exceptions, easier than disabling tests?

> -Original Message- > From: cfe-commits On Behalf Of Sam > McCall via cfe-commits > Sent: Thursday, May 28, 2020 11:15 AM > To: cfe-commits@lists.llvm.org > Subject: [clang-tools-extra] 8e325cf - [clangd] Work around PS4 -fno- > exceptions, easier than disabling tests? > > > Author: S

[clang] 7968981 - [SVE] Eliminate calls to default-false VectorType::get() from Clang

Author: Christopher Tetreault Date: 2020-06-01T10:02:14-07:00 New Revision: 796898172c48a475f27f038e587c35dbba9ab7a6 URL: https://github.com/llvm/llvm-project/commit/796898172c48a475f27f038e587c35dbba9ab7a6 DIFF: https://github.com/llvm/llvm-project/commit/796898172c48a475f27f038e587c35dbba9ab7

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. If the variables must be globalized in OpenMP mode (local automatic variable, GPU compilation mode, the variable may escape its declaration conte

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

arsenm added inline comments. Comment at: clang/include/clang/Basic/OpenMPGridValues.h:96 +256, // GV_Slot_Size +64, // GV_Warp_Size +6,// GV_Warp_Size_Log2 What about wave32? Comment at: clang/include/clang/Basic

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG796898172c48: [SVE] Eliminate calls to default-false VectorType::get() from Clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = &llvm::cl::TokenizeWindowsCommandLine; -

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

tra added a comment. Hmm. I'm pretty sure tensorflow is using std::complex for various types. I'm surprised that we haven't seen these functions missing. Plain CUDA (e.g. https://godbolt.org/z/Us6oXC) code appears to have no references to `__mul*` or `__div*`, at least for optimized builds, but

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added a comment. Narrowly this seems to fix the immediate problem, but I feel like we're in trouble if tentative parsing is changing the semantic context in ways that persist. In particular, I'm concerned that we could end up tentatively parsing an ODR use as part of an expression and

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

MyDeveloperDay added a comment. In D80933#2066648 , @thopre wrote: > That was a speedy patch! I can confirm that my non reduced testcase (git diff > -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b >

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: clang/lib/CodeGen/CGExpr.cpp:3787 + ColIdx->getType()->getScalarSizeInBits()); + llvm::Type *IntTy = llvm::Intege

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267663. nickdesaulniers added a comment. - add Android target triple handling, see https://developer.android.com/ndk/guides/other_build_systems#overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D808

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22 #include "InputInfo.h" +#include "MSP430.h" #include "PS4CPU.h" Note to reviewers: the linter really wanted to touch th

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. As a functional change it should definitely have a functional test. Let me double-check on how our stuff behaves, I may be mis-remembering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPGridValues.h:134 +} // namespace clang +#endif Can we move this into llvm core (subfolder `Frontend/OpenMP/`)? We probably need this during OpenMPOpt, and for Flang as well. Repositor

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Indeed I am mis-remembering, sorry about that! We use gnu-style command-line options but we change RSPQuoting from Default to Windows; assuming getProcessTriple() is the host not the target, your change should have the same effect. I'll try removing our private patc

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:565 +case llvm::Triple::thumbeb: + if (Triple.getEnvironment() == llvm::Triple::Android) +return true; Triple.isAndroid() is more clear. Comment a

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=46159 Linux Kernel code using is try as a variable name (as its 'C' code they can), they int

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a subscriber: rnk. probinson added a comment. I was about to add @rnk who I remember has been in Windows driver behavior discussions in the past; except he has cleverly left a note that he's away June-Sept. Oh well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, lei, stefanp, saghir, power-llvm-team, hfinkel. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. This patch implements builtins for the following prototypes: unsigned long long __

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev added a comment. In D80925#2066728 , @rjmccall wrote: > Narrowly this seems to fix the immediate problem, but I feel like we're in > trouble if tentative parsing is changing the semantic context in ways that > persist. In particular, I'm concern

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: lld/ELF/LTO.cpp:79 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent `--lto-basic-block-sections` I thin

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

amccarth accepted this revision. amccarth added a comment. Yowza. Mingw still links against MSVCRT?! Anyway, I think the patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80880/new/ https://reviews.llvm.org/D80880 __

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

lebedev.ri added a comment. Why not lower it to `@llvm.cttz(and(a, b))`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 ___ cfe-commits mailing list cfe-commit

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Clang side of these changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

  1   2   >