LukeGeeson added a comment. A few nits, it looks largely uncontroversial but I'll let someone else give the ok since an external eye is always good :)
================ Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" || ---------------- I always wondered why we need special treatment for cvt intrinsics here, is there a better place to put this? ================ Comment at: llvm/test/CodeGen/ARM/bf16-intrinsics-nofp16.ll:1 +; RUN: llc < %s -verify-machineinstrs -mtriple=armv8.6a-arm-none-eabi -mattr=+neon -mattr=+bf16 | FileCheck %s + ---------------- These files are very small, it's almost not worth having them on their own, can you merge them into 1 file unless we need 2 for a specific reason ================ Comment at: llvm/test/CodeGen/ARM/bf16-intrinsics.ll:1 +; RUN: llc < %s -verify-machineinstrs -mtriple=armv8.6a-arm-none-eabi -mattr=+fullfp16 -mattr=+neon -mattr=+bf16 | FileCheck %s + ---------------- same here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
