> -----Original Message----- > From: cfe-commits <cfe-commits-boun...@lists.llvm.org> On Behalf Of Sam > McCall via cfe-commits > Sent: Thursday, May 28, 2020 11:15 AM > To: cfe-commits@lists.llvm.org > Subject: [clang-tools-extra] 8e325cf - [clangd] Work around PS4 -fno- > exceptions, easier than disabling tests? > > > Author: Sam McCall > Date: 2020-05-28T17:14:23+02:00 > New Revision: 8e325cfc1456820e2253909e4aa0c3014f1e050c > > URL: https://github.com/llvm/llvm- > project/commit/8e325cfc1456820e2253909e4aa0c3014f1e050c > DIFF: https://github.com/llvm/llvm- > project/commit/8e325cfc1456820e2253909e4aa0c3014f1e050c.diff > > LOG: [clangd] Work around PS4 -fno-exceptions, easier than disabling > tests? > > Added: > > > Modified: > clang-tools-extra/clangd/unittests/XRefsTests.cpp > > Removed: > > > > ########################################################################## > ###### > diff --git a/clang-tools-extra/clangd/unittests/XRefsTests.cpp b/clang- > tools-extra/clangd/unittests/XRefsTests.cpp > index b73a310e95fb..e260285a179c 100644 > --- a/clang-tools-extra/clangd/unittests/XRefsTests.cpp > +++ b/clang-tools-extra/clangd/unittests/XRefsTests.cpp > @@ -245,7 +245,9 @@ TEST(HighlightsTest, ControlFlow) { > }; > for (const char *Test : Tests) { > Annotations T(Test); > - auto AST = TestTU::withCode(T.code()).build(); > + auto TU = TestTU::withCode(T.code()); > + TU.ExtraArgs.push_back("-fexceptions"); // FIXME: stop testing on > PS4.
Yeah, sorry for the inconvenience. We haven't tried evaluating clangd for a PS4 environment but in the meantime it feels like more coverage is a good thing? Thanks, --paulr > + auto AST = TU.build(); > EXPECT_THAT(findDocumentHighlights(AST, T.point()), > HighlightsFrom(T)) > << Test; > } > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
