jdoerfert added a comment.

First, I think the warning is strictly a good thing. Thanks for keeping that in!

I don't think the options are really "complexity to the user" given a sensible 
default (= the old value). If a user sees a warning that says: `Name conflict, 
use --nameless-prefix=XXXXX, where XXXXX is a string not otherwise used in your 
IR`, they will happily do so. The UTC_ARGS extension makes it permanent and no 
one needs to worry about this until they see a warning again. (If we can "hide" 
the option from the help message, I'm fine with that too.)

Adding a test is just something we should do as it is easy to accidentally 
break functionality like the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80584/new/

https://reviews.llvm.org/D80584



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to