mstorsjo added a comment.

In D80880#2066078 <https://reviews.llvm.org/D80880#2066078>, @mati865 wrote:

> Wouldn't it better fit in `AddLibGCC`?


`AddLibGCC` is called twice, and we already add `-lkernel32` (plus a bunch of 
other libraries) after the first invocation, so that would either add another 
extra `-lkernel32` or require touching that code.

Also, with the other issue pointer out in 
https://github.com/msys2/MINGW-packages/pull/6539, I'm not sure if we also 
should try to another instance of `-lgcc` after `-lmingwex`, or move 
`-lmingwex` before `-lgcc` (as mingwex easily can contain references to libgcc 
builtins like division helper routines).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80880/new/

https://reviews.llvm.org/D80880



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to