[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) aaron.ballman wrote: > Can you also add tests for: > ``` > int vla_unevaluated(int x) { > // Eval

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) balazske wrote: > aaron.ballman wrote: > > Can you also add tests for: > > ``` > > int vla_unevalua

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

lebedev.ri added a comment. Herald added subscribers: phosek, mgehre. IMHO we should proceed with this patch. There's been several patches recently that seem to not care about false-positive rate, and in this case the cost of true-positive can be humongous, as i/we've been finding lots of bugs e

[clang] fd7a341 - [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.

Author: Bevin Hansson Date: 2020-04-17T10:09:02+02:00 New Revision: fd7a34186137168064ffe2ca536823559b92d939 URL: https://github.com/llvm/llvm-project/commit/fd7a34186137168064ffe2ca536823559b92d939 DIFF: https://github.com/llvm/llvm-project/commit/fd7a34186137168064ffe2ca536823559b92d939.diff

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 +for (auto &FixIt : FixIts) { + // Allow fixits within a single macro-arg expansion to be applied. + if (FixIt.RemoveRange.getBegin().isMacroID() && I feel a bit

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar marked an inline comment as done. grimar added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if ((Req.IsDefaultChe

[PATCH] D78294: [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd7a34186137: [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI. (authored by ebevhan). Changed prior to commit: https://reviews.llvm.org/D78294?vs=258033&id=258251#toc Rep

[clang] 0642e5e - [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

Author: Matthias Gehre Date: 2020-04-17T10:37:24+02:00 New Revision: 0642e5e7a7e54a11120262cfafea0193e3a75faf URL: https://github.com/llvm/llvm-project/commit/0642e5e7a7e54a11120262cfafea0193e3a75faf DIFF: https://github.com/llvm/llvm-project/commit/0642e5e7a7e54a11120262cfafea0193e3a75faf.diff

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

mgehre added inline comments. Comment at: test/clang-tidy/bugprone-map-subscript-operator-lookup.cpp:60 +} + +void noWarning() { We often have code like ``` auto &V = Map[Idx]; if (!V) { V = init(); } use(V); ``` Would that be flagged by this check? Could you a

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rG0642e5e7a7e5: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 258268. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. fix clangd test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files:

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein updated this revision to Diff 258268. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. hokein added subscribers: ebevhan, hubert.reinterpretcast. fix

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov marked 9 inline comments as done. ASDenysPetrov added a comment. @baloghadamsoftware > However, please still extend the current tests I've looked for some appropriate tests to extend, but haven't found. What would you advise to use instead of mine? @steakhal Thanks for the comment

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 258269. fhahn marked 9 inline comments as done. fhahn added a comment. Update wordings as suggested, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clan

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein added subscribers: ebevhan, hubert.reinterpretcast. hokein added a comment. @ebevhan, @hubert.reinterpretcast, the patch is based on fd7a34186137168064ffe2ca536823559b92d939 , it should contain all the fixes. it would b

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + rjmccall wrote: > This is kindof an unnecessarily unreadable example. I know you haven't > decided on calling convention treatment yet, but maybe th

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

NoQ added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) balazske wrote: > balazske wrote: > > aaron.ballman wrote: > > > Can you also add tests for: > > > ``` > > > int vla_unevaluated(int x) { > > > /

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

balazske added a comment. I am not sure if this is the best approach: In a similar case (no opening function encountered) it is possible that the stream is already "escaped", there could be references to it from outside the analyzed function (to which it was passed, or got from another non-anal

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

balazske added a comment. The new option will simply list the (found) functions that have a summary based check enabled. (The term "Loaded" may be misleading in the current implementation, somebody can think if it is loaded from file?) A more detailed output would be better (display the signatu

[PATCH] D78190: Add Bfloat IR type

stuij marked 2 inline comments as done. stuij added a comment. Marked all comments as having been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Hi Kadir, I noticed in our buildbots that run with sanitizers that we got a new complaint with this commit. It's still there on current top-of-tree now so the fixes you pushed after this patch doesn't seem to address this one: ==89727==ERROR: LeakSanitizer: detected memory leaks Direct leak of 1

[PATCH] D78338: [clangd] Enable diagnostic fixes within macro argument expansions.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 +for (auto &FixIt : FixIts) { + // Allow fixits within a single macro-arg expansion to be applied. + if (FixIt.RemoveRange.getBegin(

[PATCH] D78359: [clangd] Do not store BaseOf relations for missing subjects

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78359 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp Index:

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun marked an inline comment as done. khuttun added a comment. In D46317#1988261 , @lebedev.ri wrote: > IMHO we should proceed with this patch. > There's been several patches recently that seem to not care about > false-positive rate, > and in this

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

aaron.ballman added a comment. In D46317#1988261 , @lebedev.ri wrote: > IMHO we should proceed with this patch. > There's been several patches recently that seem to not care about > false-positive rate, I don't think that's accurate. We still care abou

[PATCH] D77938: [clangd] Extend YAML Serialization

mnauw updated this revision to Diff 258292. mnauw added a comment. As suggested, existing (YAML) Serialization test has been extended. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 Files: clang-tools-extra/clangd/index/YAMLSerialization.cpp

[clang-tools-extra] 4503cf5 - [clangd] Drop dangling relations while sharding

Author: Kadir Cetinkaya Date: 2020-04-17T13:57:32+02:00 New Revision: 4503cf5f231368d6e11af724b78f1371463d86a6 URL: https://github.com/llvm/llvm-project/commit/4503cf5f231368d6e11af724b78f1371463d86a6 DIFF: https://github.com/llvm/llvm-project/commit/4503cf5f231368d6e11af724b78f1371463d86a6.dif

[clang-tools-extra] 66b54d5 - [clangd] Fix memory leak in FileIndexTest

Author: Kadir Cetinkaya Date: 2020-04-17T14:00:34+02:00 New Revision: 66b54d586fa73499714e2bfef3cedffeabb08f34 URL: https://github.com/llvm/llvm-project/commit/66b54d586fa73499714e2bfef3cedffeabb08f34 DIFF: https://github.com/llvm/llvm-project/commit/66b54d586fa73499714e2bfef3cedffeabb08f34.dif

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Thanks Mikael, 66b54d586fa73499714e2bfef3cedffeabb08f34 should fix this. On Fri, Apr 17, 2020 at 2:42 PM Mikael Holmén wrote: > Hi Kadir, > > I noticed in our buildbots that run with sanitizers that we got a new > complaint with this commit. It's still there on current top-of-tree now > so the

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

On Fri, 2020-04-17 at 15:02 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, > > 66b54d586fa73499714e2bfef3cedffeabb08f34 should fix this. > Yep, now it runs without complaints. Thanks! /Mikael > On Fri, Apr 17, 2020 at 2:42 PM Mikael Holmén < > mikael.hol...@ericsson.com> wrote: > > Hi Kadir, >

[PATCH] D78359: [clangd] Do not store BaseOf relations for missing subjects

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4503cf5f2313: [clangd] Drop dangling relations while sharding (authored by kadircet). Changed prior to commit: https://

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) NoQ wrote: > balazske wrote: > > balazske wrote: > > > aaron.ballman wrote: > > > > Can you also add tests for: > > > > ``` > > > > int v

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. Let's have a look at an example. Do we allow this? template int x = [](T = T()){ return 0; }(args...); template int x; // Uses default argument int() = 0. struct S { S(int); }; template int x; // Default argument not well-formed, but not needed. Curr

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 258300. ASDenysPetrov added a comment. Refined Negate function. Divided by steps for clarity. Made some changes in comments due to guideline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 Files: cl

[clang] a7afb21 - [clang][AST] Support AST files larger than 512M

Author: Dmitry Polukhin Date: 2020-04-17T06:17:33-07:00 New Revision: a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 URL: https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 DIFF: https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1.dif

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7afb211dc46: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if ((Req.IsDefaultChe

[PATCH] D67052: Add reference type transformation builtins

miscco added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:416 static bool isTypeRep(TST T) { -return (T == TST_typename || T == TST_typeofType || -T == TST_underlyingType || T == TST_atomic); +return (TST_typename <= T <= TST_atomic);

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. fixes https://github.com/clangd/clangd/issues/330 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78365 Files: clang/

[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. This is guaranteed to be a no-op without the preamble, so should be a no-op with it too. Partially fixes https

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

arsenm added a comment. In D77910#1981828 , @b-sumner wrote: > In D77910#1981429 , @arsenm wrote: > > > In D77910#1976171 , @b-sumner > > wrote: > > > > > I don't think we c

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, intended to accept this (with the comment above) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78365/new/ https://reviews.llvm.org/D

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

sammccall added a comment. Nice! Yet another case of "do we need to stop here" though. Do you have a doc or bug or somewhere to collect the different directions we could/should extend in? Comment at: clang/lib/Sema/SemaDecl.cpp:11852 + // There are unresolved typos in In

[clang] b639091 - Change users of CreateShuffleVector to pass the masks as int instead of Constants

Author: Benjamin Kramer Date: 2020-04-17T16:34:29+02:00 New Revision: b639091c02df31954899c8107709597947e33364 URL: https://github.com/llvm/llvm-project/commit/b639091c02df31954899c8107709597947e33364 DIFF: https://github.com/llvm/llvm-project/commit/b639091c02df31954899c8107709597947e33364.dif

[clang] f89abd6 - [SYCL] Update __builtin_unique_stable_name for other backends.

Author: Erich Keane Date: 2020-04-17T07:54:18-07:00 New Revision: f89abd6923bcc0839288af4b96113a0cb4fa4edd URL: https://github.com/llvm/llvm-project/commit/f89abd6923bcc0839288af4b96113a0cb4fa4edd DIFF: https://github.com/llvm/llvm-project/commit/f89abd6923bcc0839288af4b96113a0cb4fa4edd.diff L

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

Quuxplusone added inline comments. Comment at: test/clang-tidy/bugprone-map-subscript-operator-lookup.cpp:48 + int getter() const; + void setter(int); +}; Besides mgehre's request for `auto&` test cases, I'd like to see some test cases involving these member f

[PATCH] D77938: [clangd] Extend YAML Serialization

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access, or would you like me to land this and D78038 for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7793

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Functions fread

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 258337. ilinpv marked an inline comment as done. ilinpv edited the summary of this revision. ilinpv added a comment. More patterns added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit dmgreen wrote: > Should

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. This change breaks the lldb build with lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: enumeration values 'DependentExtInt' and 'ExtInt' not handled in switch [-Werror,-Wswitch] switch (qual_type->getTypeClass()) { ^ lldb/source

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

b-sumner added a comment. In D77910#1988807 , @arsenm wrote: > In D77910#1981828 , @b-sumner wrote: > > > In D77910#1981429 , @arsenm wrote: > > > > > In D77910#1976171

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989145 , @saugustine wrote: > This change breaks the lldb build with > > lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: > enumeration values 'DependentExtInt' and 'ExtInt' not handled in swi

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei marked an inline comment as done. lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfea

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. Reverted in a4b88c044980337bb14390be654fe76864aa60ec . Happy to approve an updated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ h

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989145 , @saugustine wrote: > This change breaks the lldb build with > > lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: > enumeration values 'DependentExtInt' and 'ExtInt' not handled in swi

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

probinson added a comment. I'm just reading this review for the first time, and my thought was, why is this interacting with implicit-check-not? I think specifying a `--check-prefix=FOO` with no uses of FOO should be diagnosed. I can't say I recall the previous discussion in detail, but that's

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 258368. saiislam marked an inline comment as done. saiislam added a comment. 1. Moved test case to clang/test/CodeGenCXX. 2. Added a failing test case with invalid sync scope, which gets detected by implementation of fence instruction. 3. Updated the change

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Already relanded here: 5f0903e9bec9 @saugustine I checked the buildbots, every one with LLDB in its name stayed green, and I cannot see the warning in any of their STDIO. Can you point out how I

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258375. lei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Driver/ppc-depend

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji accepted this revision. jsji added a comment. LGTM. Since there is an improvement for multi errors, we should remove `[NFC]` in title and commit messages. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.o

[PATCH] D78390: [dfsan] Add dataflow option to LLVM_USE_SANITIZER

zbrid created this revision. zbrid added a reviewer: morehouse. Herald added subscribers: libcxx-commits, cfe-commits, mgorny. Herald added projects: clang, libc++. Herald added a reviewer: libc++. zbrid added a reviewer: EricWF. zbrid edited the summary of this revision. This patch add the datafl

Re: [PATCH] D73967: Implement _ExtInt as an extended int type specifier.

Sorry for the trouble. I think many buildbots don't build lldb--not enough of them anyway. I found this myself. As I understand it, the switch-cover warning is supposed to be enabled everywhere when built in release mode, so it looks like the lldb builders (what few there are) aren't building in r

RE: [PATCH] D73967: Implement _ExtInt as an extended int type specifier.

No problem, thanks for the response! Phab emails are apparently about 30 minutes delayed for me apparently, which is unfortunate or I would have had the fix ready before your revert 😊 Let me know if you run into any more issues, but I’m 99% sure I got it right this time. Thanks -Erich From: S

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Oh I found some lit tests that fail by running `check-cxx`. I'll address that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 ___ cfe-co

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. In D77233#1977671 , @erik.pilkington wrote: > LGTM (after fixing those tests). Thanks for cleaning this up! Can this be a LGTM again @erik.pilkington @arphaman? I have managed to undo any unintended C API changes. Tests appear

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

rnk added subscribers: tstellar, hans, rnk. rnk added a comment. We ran into three distinct issues with this change. We updated the compiler and break some VS std::map visualizers: https://crbug.com/1068394 I haven't 100% confirmed that this caused the issue, but looking at the code suggests tha

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258383. zbrid added a comment. Herald added a subscriber: broadwaylamb. Update config.py to support data flow sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Fi

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258393. ctetreau added a comment. fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp llvm/include/llvm/IR/Deriv

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tambre created this revision. tambre added a reviewer: tra. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. tambre edited the summary of this revision. tambre edited the summary of this revision. tra added inline comments. Comment at: clang/lib/Heade

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:44 #include // Preserve common macros that will be changed below by us or by CUDA We should undef __CUDACC__ here to make sure it does not affect anything else in the he

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258392. ctetreau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. catch stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D7727

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

morehouse added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:24 +How to build + + Let's add some explanation here about why we want to build libc++ with dfsan. Comment at: clang/docs/DataFlowSanitizer.rst:26 + +Buil

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

tra updated this revision to Diff 258396. tra added a comment. Undef __CUDACC__ after the standard headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78392/new/ https://reviews.llvm.org/D78392 Files: clang/lib/Headers/__clang_cuda_runtime_wr

[clang] 8e20516 - [CUDA] Define __CUDACC__ before standard library headers

Author: Raul Tambre Date: 2020-04-17T12:56:13-07:00 New Revision: 8e20516540444618ad32dd11e835c05804053697 URL: https://github.com/llvm/llvm-project/commit/8e20516540444618ad32dd11e835c05804053697 DIFF: https://github.com/llvm/llvm-project/commit/8e20516540444618ad32dd11e835c05804053697.diff L

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. The tests look good, but I can't see the implementation in this diff. Maybe a file missing from the patch? Can be hard to tell with phabricator, the error may be at my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D78392: [CUDA] Define __CUDACC__ before standard library headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e2051654044: [CUDA] Define __CUDACC__ before standard library headers (authored by tambre, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 10b60dd - [PowerPC] Refactor ppcUserFeaturesCheck()

Author: Lei Huang Date: 2020-04-17T15:19:46-05:00 New Revision: 10b60dde767011c250649dc6a305379034c5b5c5 URL: https://github.com/llvm/llvm-project/commit/10b60dde767011c250649dc6a305379034c5b5c5 DIFF: https://github.com/llvm/llvm-project/commit/10b60dde767011c250649dc6a305379034c5b5c5.diff LOG

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a subscriber: dblaikie. sammccall added a comment. Sorry about the problems here, and thanks for letting me know... In D76801#1989421 , @rnk wrote: > We updated the compiler and break some VS std::map visualizers: > https://crbug.com/1068

[PATCH] D77278: Remove asserting getters from base Type

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258411. ctetreau added a comment. catch straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp llvm/include/llvm/IR/Deriv

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258409. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. rebase the patch on the D78045 and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1496 + +MCSymbol *Name = getSymbol(&F); +if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) { hubert.reinte

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

This revision was automatically updated to reflect the committed changes. lei marked an inline comment as done. Closed by commit rG10b60dde7670: [PowerPC] Refactor ppcUserFeaturesCheck() (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] c858deb - Remove asserting getters from base Type

Author: Christopher Tetreault Date: 2020-04-17T14:03:31-07:00 New Revision: c858debebc1308e748de882c745e179b1a398fa0 URL: https://github.com/llvm/llvm-project/commit/c858debebc1308e748de882c745e179b1a398fa0 DIFF: https://github.com/llvm/llvm-project/commit/c858debebc1308e748de882c745e179b1a398f

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]. Some ACLE builtins leave out

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

sdesmalen updated this revision to Diff 258416. sdesmalen retitled this revision from "[SveEmitter] Add ExpandOp1SVALL and builtin for svptrue" to "[SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]". sdesmalen edited the summary of this revision. sdesmalen added a comment.

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

rnk added a subscriber: amccarth. rnk added a comment. In D76801#1989641 , @sammccall wrote: > I've got a sinking feeling that I misunderstood the implications of updating > CodeGenCXX/debug-info-template-explicit-specialization.cpp and the > Modules/*De

[PATCH] D73307: Unique Names for Functions with Internal Linkage

rnk added a subscriber: erichkeane. rnk added a comment. In D73307#1978140 , @tmsriram wrote: > In D73307#1972388 , @rnk wrote: > > > Regarding the alias attribute, it occurs to me that reimplementing this as > > a

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

ASDenysPetrov added a comment. @baloghadamsoftware I know you have much expertise here. Do you have some thoughts of how I can test exactly these cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78289/new/ https://reviews.llvm.org/D78289 __

[PATCH] D77278: Remove asserting getters from base Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc858debebc13: Remove asserting getters from base Type (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.

[clang] 7ce4e65 - [cmake] Temporarily disable building std::filesystem in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-04-18T00:29:44+03:00 New Revision: 7ce4e652312f776c2cdd1650370c8909f7cf992f URL: https://github.com/llvm/llvm-project/commit/7ce4e652312f776c2cdd1650370c8909f7cf992f DIFF: https://github.com/llvm/llvm-project/commit/7ce4e652312f776c2cdd1650370c8909f7cf992f.d

[PATCH] D78402: [AArch64] Define ACLE FP conversion intrinsics with more specific predicate.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78402/new/ https://reviews.llvm.org/D78402 ___

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

yaxunl requested review of this revision. yaxunl added a comment. We need to revive this review since we found it is very inconvenient without this. Also, nvcc only emits a warning for it https://cuda.godbolt.org/z/AzrDTt So I think maybe we even want to emit it as warning by default. Reposi

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen updated this revision to Diff 258426. sdesmalen added a comment. - Added comment to CGBuiltin explaining that the special case for IsFPConvert will be removed in a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78239/new/ https://reviews.llvm.org/D78239 Files

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a comment. In D76801#1989718 , @rnk wrote: > Hang on, I may have been too quick. We *do* have a test for this, at the end > of clang/test/CodeGenCXX/debug-info-codeview-display-names.cpp: > > https://github.com/llvm/llvm-project/blob/f84

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2144 report_fatal_error( -"Unhandled linkage when mapping linkage to StorageClass."); +"AvailableExternallyLinkage is for its first instance of linkage

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D78239#1987859 , @efriedma wrote: > I think the predicate type is something we should fix. Even if it's not > causing problems now, it seems like the sort of thing that will bite

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb created this revision. broadwaylamb added reviewers: asl, rsmith, doug.gregor, rjmccall, triton. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. This patch implements paper P0692R1

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:1035 + OS << "#define svcvtxnt_f32_x svcvtxnt_f32_m\n"; + OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\

  1   2   >