No problem, thanks for the response! Phab emails are apparently about 30 minutes delayed for me apparently, which is unfortunate or I would have had the fix ready before your revert 😊
Let me know if you run into any more issues, but I’m 99% sure I got it right this time. Thanks -Erich From: Sterling Augustine <saugust...@google.com> Sent: Friday, April 17, 2020 11:38 AM To: reviews+d73967+public+2549cbb9adffa...@reviews.llvm.org Cc: Keane, Erich <erich.ke...@intel.com>; aaron.ball...@gmail.com; m.ge...@gmx.de; Blower, Melanie I <melanie.blo...@intel.com>; Mikhail Ramalho <mikhail.rama...@gmail.com>; arichardson....@gmail.com; david.gr...@arm.com; bevin.hans...@ericsson.com; riccib...@gmail.com; Andrews, Elizabeth <elizabeth.andr...@intel.com>; samm...@gmail.com; Mikael Holmén <mikael.hol...@ericsson.com>; a.bat...@hotmail.com; Sidorov, Dmitry <dmitry.sido...@intel.com>; sabre+phabrica...@nondot.org; karl-johan.karls...@ericsson.com; git...@john.mcfarlane.name; jfbast...@apple.com; ronan-l...@keryell.fr; Richard Smith <rich...@metafoo.co.uk>; ikosa...@accesssoftek.com; rekanikol...@gmail.com; Alex L <arpha...@gmail.com>; cfe-commits <cfe-commits@lists.llvm.org>; mlek...@skidmore.edu; blitzrak...@gmail.com; Han Shen <shen...@google.com>; 1.in...@gmail.com Subject: Re: [PATCH] D73967: Implement _ExtInt as an extended int type specifier. Sorry for the trouble. I think many buildbots don't build lldb--not enough of them anyway. I found this myself. As I understand it, the switch-cover warning is supposed to be enabled everywhere when built in release mode, so it looks like the lldb builders (what few there are) aren't building in release mode. I can look into fixing that. On Fri, Apr 17, 2020 at 11:20 AM Erich Keane via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> wrote: erichkeane added a comment. Already relanded here: 5f0903e9bec9 <https://reviews.llvm.org/rG5f0903e9bec97e67bf34d887bcbe9d05790de934> @saugustine I checked the buildbots, every one with LLDB in its name stayed green, and I cannot see the warning in any of their STDIO. Can you point out how I can proactively keep an eye on this? The lldb build is broken out-of-the-box anyway for me due to the LLDB Python Wrapper having a syntax error in the SWIG bindings. bash-4.2$ swig -copyright SWIG Version 2.0.10 /workspaces/llvm-project/lldb/bindings/./python/python-typemaps.swig:496: Error: Syntax error in input(3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
