lei marked an inline comment as done.
lei added inline comments.
================
Comment at: clang/lib/Basic/Targets/PPC.cpp:243
+ bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector");
+ Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move");
+ Passed |= CheckVSXSubfeature("+float128", "-mfloat128");
----------------
jsji wrote:
> Looks like this is will cause behavior change.. And NOT NFC at all..
>
> Before refactor, we will return false when *ANY* of the subfeature is ON.
> After refactor, we will only return false, when *ALL* of the subfeature are
> ON, Passed will be set to true when any of subfeature are off .
>
> Can you please double check?
You are right... will post an update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78308/new/
https://reviews.llvm.org/D78308
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
