morehouse added inline comments.
================ Comment at: clang/docs/DataFlowSanitizer.rst:24 +How to build +============ + ---------------- Let's add some explanation here about why we want to build libc++ with dfsan. ================ Comment at: clang/docs/DataFlowSanitizer.rst:26 + +Build LLVM/Clang with `CMake <https://llvm.org/docs/CMake.html>`_. + ---------------- This sentence doesn't seem too helpful. I think most people reading this doc will know how to build LLVM/Clang. I suggest either removing this sentence or expanding it to explain that we want to build LLVM/Clang separately from libc++ since we only want dfsan instrumentation on libc++. ================ Comment at: libcxx/utils/libcxx/test/config.py:915 + self.config.available_features.add('dfsan') + self.config.available_features.add('sanitizer-new-delete') else: ---------------- I'm not 100% sure what the `sanitizer-new-delete` feature is used for, but I don't think we want it for dfsan since it doesn't use a custom allocator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
