[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D33820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sorry, when I say "One inline comment otherwise LGTM" feel free to commit after fixing :) Since you have, then LGTM. -eric Repository: rL LLVM https://reviews.llvm.org/D33820

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp:31 +class VirtualCallChecker: public Checker { + mutable std::unique_ptr BT_CT; + mutable std::unique_ptr BT_DT; Could you find more descriptive names for these BugT

[PATCH] D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

ilya-biryukov added a comment. @bruno, I've added a test to clangd, see D34755 . Repository: rL LLVM https://reviews.llvm.org/D34469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[clang-tools-extra] r306650 - [clang-tidy] follow-up on misc-definitions-in-header check.

Author: hokein Date: Thu Jun 29 01:28:45 2017 New Revision: 306650 URL: http://llvm.org/viewvc/llvm-project?rev=306650&view=rev Log: [clang-tidy] follow-up on misc-definitions-in-header check. Summary: A follow-up on D34449: * add `-std=c++11` to `.hpp` file by default. * add constexpr function t

[PATCH] D34771: [clang-tidy] follow-up on misc-definitions-in-header check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306650: [clang-tidy] follow-up on misc-definitions-in-header check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D34771 Files: clang-tools-extra/trunk/docs/clang-tidy/checks/mi

[clang-tools-extra] r306651 - [clang-tidy] Fix modernize-use-nullptr only warns the first NULL argument.

Author: hokein Date: Thu Jun 29 01:43:36 2017 New Revision: 306651 URL: http://llvm.org/viewvc/llvm-project?rev=306651&view=rev Log: [clang-tidy] Fix modernize-use-nullptr only warns the first NULL argument. Reviewers: alexfh Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits Differential

[clang-tools-extra] r306652 - [clangd] Added a test, checking that gcc install is searched via VFS.

Author: ibiryukov Date: Thu Jun 29 01:43:51 2017 New Revision: 306652 URL: http://llvm.org/viewvc/llvm-project?rev=306652&view=rev Log: [clangd] Added a test, checking that gcc install is searched via VFS. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306652: [clangd] Added a test, checking that gcc install is searched via VFS. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D34755 Files: clang-tools-extra/trunk/unittests/cl

r306653 - [OpenCL] Allow function declaration with empty argument list.

Author: bader Date: Thu Jun 29 01:44:10 2017 New Revision: 306653 URL: http://llvm.org/viewvc/llvm-project?rev=306653&view=rev Log: [OpenCL] Allow function declaration with empty argument list. Summary: does it make sense to enable K&R function declaration style for OpenCL? clang throws following

[PATCH] D34526: [clang-tidy] Fix modernize-use-nullptr only warns the first NULL argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306651: [clang-tidy] Fix modernize-use-nullptr only warns the first NULL argument. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D34526?vs=103618&id=104607#toc Repository: r

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. One last comment below: Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2880 InGroup; def note_partial_availability_silence : Note< + "annotate %0 with

[clang-tools-extra] r306656 - [clangd] Run a test, searching for gcc install, only on Unix.

Author: ibiryukov Date: Thu Jun 29 02:22:32 2017 New Revision: 306656 URL: http://llvm.org/viewvc/llvm-project?rev=306656&view=rev Log: [clangd] Run a test, searching for gcc install, only on Unix. This should fix windows buildbots. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTe

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

arphaman added a comment. In https://reviews.llvm.org/D34696#793613, @klimek wrote: > The main thing I'm concerned about is having the main code in core, but > having all tests in tools-extra. I think if we go that route we should also > move clang-rename and its tests to core. Thoughts? Woul

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

klimek added a comment. In https://reviews.llvm.org/D34696#795020, @arphaman wrote: > In https://reviews.llvm.org/D34696#793613, @klimek wrote: > > > The main thing I'm concerned about is having the main code in core, but > > having all tests in tools-extra. I think if we go that route we should

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL306659: [Tooling] FixedCompilationDatabase should be able to strip positional (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34687?vs=104161&id=104618#toc Repository: rL L

r306659 - [Tooling] FixedCompilationDatabase should be able to strip positional

Author: arphaman Date: Thu Jun 29 03:43:44 2017 New Revision: 306659 URL: http://llvm.org/viewvc/llvm-project?rev=306659&view=rev Log: [Tooling] FixedCompilationDatabase should be able to strip positional arguments when `-fsyntax-only` is used Previously, Clang failed to create a fixed compilatio

r306660 - Revert r306653, "[OpenCL] Allow function declaration with empty argument list."

Author: chapuni Date: Thu Jun 29 03:47:23 2017 New Revision: 306660 URL: http://llvm.org/viewvc/llvm-project?rev=306660&view=rev Log: Revert r306653, "[OpenCL] Allow function declaration with empty argument list." It broke bots. Removed: cfe/trunk/test/SemaOpenCL/function-no-args.cl Modified

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Reverted in https://reviews.llvm.org/rL306660. See also; http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/4926 https://reviews.llvm.org/D33681 ___

RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Hi, -Original Message- From: Blower, Melanie [mailto:melanie.blo...@intel.com] Sent: Thursday, June 29, 2017 5:35 AM To: reviews+d34158+public+125da21f27579...@reviews.llvm.org; zhangsheng...@huawei.com; olivier...@gmail.com; kalinichev.s...@gmail.com; kf...@kde.org; m...@milianw.de; Kea

[PATCH] D34810: [Sema] -Wcomma should not warn for expression that return void

arphaman created this revision. Right now -Wcomma is too strict IMO, we shouldn't warn about expressions that return void. Repository: rL LLVM https://reviews.llvm.org/D34810 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/warn-comma-operator.cpp Index: test/SemaCXX/warn-comma-operator.cpp

[PATCH] D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums

arphaman added a comment. LGTM, Thanks! Do you have commit access? https://reviews.llvm.org/D34766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you. https://reviews.llvm.org/D33932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D34749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader added a comment. @chapuni, thanks for taking care of this. I'll take a look. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31697: Check for null before using TUScope

kimgr added a comment. I did some more debugging today. This happens when we attempt to analyze llvm/Support/MathExtras.h, and only for the function templates that use Microsoft intrinsics (e.g. `_BitScanForward` in `TrailingZerosCounter`.) So there's something in the parsing of builtins/intrin

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev added a comment. @bruno ping... Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums

voskresensky.vladimir added a comment. In https://reviews.llvm.org/D34766#795087, @arphaman wrote: > LGTM, Thanks! Do you have commit access? No. Could you commit, please. Thanks! https://reviews.llvm.org/D34766 ___ cfe-commits mailing list cfe-c

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added inline comments. Comment at: include/clang/Format/Format.h:167 +/// \endcode +OAS_StrictAlign, + }; djasper wrote: > The name is not intuitive. I don't think this is any more or less strict than > the other version. It is a bit stricter in th

r306672 - [clang-format] Fix parsing of msg{field}-style proto options

Author: krasimir Date: Thu Jun 29 06:30:41 2017 New Revision: 306672 URL: http://llvm.org/viewvc/llvm-project?rev=306672&view=rev Log: [clang-format] Fix parsing of msg{field}-style proto options Summary: This patch makes the `{` in `msg_field{field: OK}` in a proto option scope be treated as an

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

This revision was automatically updated to reflect the committed changes. Closed by commit rL306672: [clang-format] Fix parsing of msg{field}-style proto options (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D34749?vs=104410&id=104632#toc Repository: rL LLVM http

r306673 - [Clang][X86][Goldmont]Adding new target-cpu: Goldmont

Author: mzuckerm Date: Thu Jun 29 06:41:04 2017 New Revision: 306673 URL: http://llvm.org/viewvc/llvm-project?rev=306673&view=rev Log: [Clang][X86][Goldmont]Adding new target-cpu: Goldmont [Clang-side] Connecting the GoldMont processor to his feature. Reviewers: 1. igorb 2. delena 3. zvi Dif

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

teemperor added a comment. Two thought from me on this: 1. I think we want to support completing both -cc1 and normal driver invocation. Most people use the driver, but for example during debugging people use the cc1 version, so both are valid use cases. I just saw we actually have the complet

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

joerg added a comment. As I said in the discussion about similar flags for GVN, I'm generally fine with. We should have a big fat warning in the Release Notes that all -fexperimental-* flags are exactly that -- temporary and not intended for long term consumption. I.e. "we can and will remove t

Re: [PATCH] D31697: Check for null before using TUScope

Might want to ask on cfe-dev or irc for more visibility since this review thread isn't getting much action On Thu, Jun 29, 2017 at 5:12 AM Kim Gräsman via Phabricator < revi...@reviews.llvm.org> wrote: > kimgr added a comment. > > I did some more debugging today. This happens when we attempt to an

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. @rjmccall, thanks for the prompt and thorough reply. In https://reviews.llvm.org/D3#793311, @rjmccall wrote: > Okay. In that case, I see two problems, one major and one potentially major. This is a very accurate di

r306680 - Fix NSAPI constants to reflect the current state of

Author: arphaman Date: Thu Jun 29 07:18:26 2017 New Revision: 306680 URL: http://llvm.org/viewvc/llvm-project?rev=306680&view=rev Log: Fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums Patch by Vladimir Voskresensky! Differential Revision: https:

[PATCH] D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums

This revision was automatically updated to reflect the committed changes. Closed by commit rL306680: Fix NSAPI constants to reflect the current state of (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34766?vs=104455&id=104643#toc Repository: rL LLVM https://revie

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 104645. krasimir added a comment. - Add initial support for <>-style message fields - Added single-line tests - Added multiline message proto tests https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 104646. krasimir added a comment. - Wrap-up this patch https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/For

[PATCH] D34441: [clang-format] Support text proto messages

krasimir added a comment. @djasper: I think this is ready for review. https://reviews.llvm.org/D34441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi updated this revision to Diff 104649. schroedersi added a comment. In https://reviews.llvm.org/D30946#792798, @rsmith wrote: > I'd be interested to see how much complexity that adds, if you're prepared to > give it a try. Thanks for your feedback :). I added a printing context and

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D29647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added a comment. In https://reviews.llvm.org/D29647#795271, @hfinkel wrote: > LGTM When you commit this, please make sure to mention in the commit message that the test cases will be associated with follow-up commits. Repository: rL LLVM https://reviews.llvm.org/D29647

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

gtbercea updated this revision to Diff 104656. gtbercea added a comment. Rebase https://reviews.llvm.org/D29339 Files: lib/Driver/ToolChains/Clang.cpp lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/Frontend/InitPreprocessor.cpp test/Driver/openmp-offload.c

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. What happens if you have multiple targets? Maybe this should be -fopenmp-targets-arch=foo,bar,whatever? Once this all lands, please make sure that you add additional test cases here. Make sure that the arch is passed through to the ptx and cuda tools as it should be. M

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi updated this revision to Diff 104655. schroedersi added a comment. I forgot to add the previous changes in Diff 104649 (it only contains the incremental diff of the printing context changes). This diff contains all changes between

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiffInternal.h:184 + + std::string getNodeValueI(NodeId Id) const; + std::string getNodeValueI(const DynTypedNode &DTN) const; `getNodeValueImpl`? Comment at: lib/To

r306689 - [OpenMP] Add support for auxiliary triple specification

Author: gbercea Date: Thu Jun 29 08:49:03 2017 New Revision: 306689 URL: http://llvm.org/viewvc/llvm-project?rev=306689&view=rev Log: [OpenMP] Add support for auxiliary triple specification Summary: Device offloading requires the specification of an additional flag containing the triple of the /

r306691 - [OpenMP] Pass -fopenmp-is-device to preprocessing and machine specific code generation stages

Author: gbercea Date: Thu Jun 29 08:59:19 2017 New Revision: 306691 URL: http://llvm.org/viewvc/llvm-project?rev=306691&view=rev Log: [OpenMP] Pass -fopenmp-is-device to preprocessing and machine specific code generation stages Summary: The preprocessing and code generation and optimization stag

r306692 - Initialize variable and silence potentially uninitialized warning.

Author: vvassilev Date: Thu Jun 29 09:08:10 2017 New Revision: 306692 URL: http://llvm.org/viewvc/llvm-project?rev=306692&view=rev Log: Initialize variable and silence potentially uninitialized warning. Patch by Liza Sakellari! Modified: cfe/trunk/include/clang/Sema/Lookup.h Modified: cfe/t

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104664. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt test/Tooling/clan

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > What happens if you have multiple targets? Maybe this should be > -fopenmp-targets-arch=foo,bar,whatever? > > Once this all lands, please make sure that you add additional test cases > here. Make sure that th

[PATCH] D34329: [clang-diff] Initial implementation.

johannes marked 2 inline comments as done. johannes added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:439 +// Computes an optimal mapping between two trees. +class ZsMatcher { + const ASTDiff::Impl &DiffImpl; arphaman wrote: > Do you know the re

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > What happens if you have multiple targets? Maybe this should be > > -fopenmp-targets-arch=foo,bar,whatever? > > > > Once this all lands, please

[clang-tools-extra] r306705 - [clangd] Check failure of Lexer::getRawToken in GoToDeclaration.

Author: ibiryukov Date: Thu Jun 29 10:11:32 2017 New Revision: 306705 URL: http://llvm.org/viewvc/llvm-project?rev=306705&view=rev Log: [clangd] Check failure of Lexer::getRawToken in GoToDeclaration. There was an access to unitialized memory because it wasn't checked. Modified: clang-tools-

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

chh requested changes to this revision. chh added a comment. This revision now requires changes to proceed. Please update the subject line and summary. The new diff shows only the renaming of check name and file names. Were the other changes for format and macro lost or are they going to be in ano

[clang-tools-extra] r306708 - [clang-tidy][Part2] Add a new module Android and three new checks

Author: yawanng Date: Thu Jun 29 10:40:57 2017 New Revision: 306708 URL: http://llvm.org/viewvc/llvm-project?rev=306708&view=rev Log: [clang-tidy][Part2] Add a new module Android and three new checks Summary: -- creat() should be replaced by open(). [android-creat-usage] Reviewers: chh, alexfh,

[clang-tools-extra] r306709 - [clang-tidy][Part3] Add a new module Android and three new checks.

Author: yawanng Date: Thu Jun 29 10:42:23 2017 New Revision: 306709 URL: http://llvm.org/viewvc/llvm-project?rev=306709&view=rev Log: [clang-tidy][Part3] Add a new module Android and three new checks. Summary: -- fopen() should include "e" in their mode string. [android-fopen-mode] Reviewers: c

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

rnk added a comment. I thought the intention of -Wcomma was to warn on practically all non-macro uses of the comma operator. I know it's silly to cast void to void, but I seem to recall that this was an intentional style-ish warning like -Wparentheses, which encourages `if ((x = y))` for intent

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

yawanng updated this revision to Diff 104689. yawanng added a comment. Pull back the previous change. For some reason it's lost. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp clan

r306715 - Fixed -Wexceptions derived-to-base false positives

Author: sberg Date: Thu Jun 29 10:58:59 2017 New Revision: 306715 URL: http://llvm.org/viewvc/llvm-project?rev=306715&view=rev Log: Fixed -Wexceptions derived-to-base false positives ...as introduced with recent "Emit warning when throw exception in destruct or d

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

sberg added a comment. see also https://reviews.llvm.org/rL306715 "Fixed -Wexceptions derived-to-base false positives" Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks for the patch! LGTM. Comment at: lib/CodeGen/CoverageMappingGen.cpp:686 +// FIXME: a break in a switch should terminate regions for all preceding +// case statements

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst tools/clang-format/ClangFormat.cpp Index: docs/ReleaseNotes.rst

[PATCH] D34633: [clang-tidy] Rename android-file-open-flag and fix a bug

chh added a comment. I think you also need to change docs/clang-tidy/checks/list.rst. https://reviews.llvm.org/D34633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r306719 - [clang-tidy] Add docs to toctree

Author: yawanng Date: Thu Jun 29 11:44:28 2017 New Revision: 306719 URL: http://llvm.org/viewvc/llvm-project?rev=306719&view=rev Log: [clang-tidy] Add docs to toctree Summary: Add .rst files to toctree. Fix buildbot error. Reviewers: chh Reviewed By: chh Subscribers: srhines, JDevlieghere, xaz

[PATCH] D34633: [clang-tidy] Rename android-file-open-flag and fix a bug

yawanng updated this revision to Diff 104709. yawanng added a comment. Change the file name in toctree. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp clang-tidy/android/CloexecOpe

r306721 - CodeGen: Fix invalid bitcast for coerced function argument

Author: yaxunl Date: Thu Jun 29 11:47:45 2017 New Revision: 306721 URL: http://llvm.org/viewvc/llvm-project?rev=306721&view=rev Log: CodeGen: Fix invalid bitcast for coerced function argument Clang assumes coerced function argument is in address space 0, which is not always true and results in i

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL306721: CodeGen: Fix invalid bitcast for coerced function argument (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D34777?vs=104505&id=104711#toc Repository: rL LLVM https://

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

This revision was automatically updated to reflect the committed changes. Closed by commit rL306722: [Sema] Issue diagnostics if a new/delete expression generates a call to (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34574?vs=104579&id=104712#toc Repository: rL

r306722 - [Sema] Issue diagnostics if a new/delete expression generates a call to

Author: ahatanak Date: Thu Jun 29 11:48:40 2017 New Revision: 306722 URL: http://llvm.org/viewvc/llvm-project?rev=306722&view=rev Log: [Sema] Issue diagnostics if a new/delete expression generates a call to a c++17 aligned allocation/deallocation function that is unavailable in the standard librar

r306724 - [OpenMP] Fix test for revision D29645. NFC

Author: gbercea Date: Thu Jun 29 11:49:16 2017 New Revision: 306724 URL: http://llvm.org/viewvc/llvm-project?rev=306724&view=rev Log: [OpenMP] Fix test for revision D29645. NFC Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL: http://ll

[clang-tools-extra] r306728 - [clang-tidy] Rename android-file-open-flag and fix a bug

Author: yawanng Date: Thu Jun 29 12:13:29 2017 New Revision: 306728 URL: http://llvm.org/viewvc/llvm-project?rev=306728&view=rev Log: [clang-tidy] Rename android-file-open-flag and fix a bug Summary: 1. Rename android-file-open-flag to android-cloexec-open. 2. Handle a case when the function is p

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Thanks Graydon https://reviews.llvm.org/D34788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r306732 - [ASTReader] Add test for previous change r306583 / 145692e.

Author: graydon Date: Thu Jun 29 12:42:35 2017 New Revision: 306732 URL: http://llvm.org/viewvc/llvm-project?rev=306732&view=rev Log: [ASTReader] Add test for previous change r306583 / 145692e. Summary: Add a test for the change to ASTReader that reproduces the logic for consolidating multiple Ob

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306732: [ASTReader] Add test for previous change r306583 / 145692e. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34788 Files: cfe/trunk/test/Modules/Inputs/lookup-assert-prot

r306733 - [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object

Author: george.karpenkov Date: Thu Jun 29 12:52:33 2017 New Revision: 306733 URL: http://llvm.org/viewvc/llvm-project?rev=306733&view=rev Log: [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object https://reviews.llvm.org/D34791 Modified: cfe/trunk/lib/D

r306734 - [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage.

Author: george.karpenkov Date: Thu Jun 29 12:58:20 2017 New Revision: 306734 URL: http://llvm.org/viewvc/llvm-project?rev=306734&view=rev Log: [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage. Without this change, additional coverage flags specified after -fsanitize=fuzzer

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

gparker42 added a comment. I thought void-returning functions were supposed to be allowed based on the description in https://reviews.llvm.org/D3976 , but later in that discussion the definition was changed to instead allow almost nothing. Repository: rL LLVM https://reviews.llvm.org/D34810

r306739 - Insert llvm_unreachable at the end of a function to silence gcc's

Author: ahatanak Date: Thu Jun 29 13:44:20 2017 New Revision: 306739 URL: http://llvm.org/viewvc/llvm-project?rev=306739&view=rev Log: Insert llvm_unreachable at the end of a function to silence gcc's -Werror=return-type error. This is an attempt to fix the following failing bot: http://lab.llvm

[PATCH] D34725: Add sample PGO integration test to cover profile annotation and inlining.

davidxl added inline comments. Comment at: test/CodeGen/pgo-sample.c:4 +// Ensure Pass SampleProfileLoader is invoked. +// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -mllvm -debug-pass=Structure -mllvm -inline-threshold=0 -emit-llvm -o - 2>&1 | FileCh

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > > > What happens if you have multiple targets? Maybe this should be > > > -fop

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

rtrieu added a comment. Reid is correct, the whitelisted expressions was greatly reduced during code review so only casts to void would disable the warning. While the last review did not have the description updated to reflect this, the committed code does have an accurate description. What i

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione created this revision. This changes CrossWindows to look for `-nostdinc` instead of `-nostdlibinc`. In addition, fixes a bug where `-isystem-after` options would be dropped when called with `-nostdinc`. https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > > > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > > > > > Wh

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione updated this revision to Diff 104750. kastiglione added a comment. fixup a test https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp test/Driver/windows-cross.c Index: test/Driver/windows-cross.c

[clang-tools-extra] r306750 - Fix some typos in the doc

Author: sylvestre Date: Thu Jun 29 15:26:06 2017 New Revision: 306750 URL: http://llvm.org/viewvc/llvm-project?rev=306750&view=rev Log: Fix some typos in the doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-forwarding-reference-overload.rst clang-tools-extra/trunk/docs/

r306751 - Fix openmp-offload.c test on Windows

Author: rnk Date: Thu Jun 29 15:31:16 2017 New Revision: 306751 URL: http://llvm.org/viewvc/llvm-project?rev=306751&view=rev Log: Fix openmp-offload.c test on Windows Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL: http://llvm.org/viewv

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

timshen updated this revision to Diff 104753. timshen added a comment. Use a cc1 flag -fdebug-pass-manager instead. https://reviews.llvm.org/D34790 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CodeGenOptions.def clang/lib/CodeGen/BackendUtil.cpp clang/lib

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen added a comment. Also add @tejohnson as a reviewer, since the LTO test changed https://reviews.llvm.org/D34790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

martell added a comment. Not quite sure how this achieves anything different from what is already in `cmake/config-ix.cmake` ? https://reviews.llvm.org/D33638 addresses the remaining changes needed to build for windows shared and static in one build. Repository: rL LLVM https://reviews.llvm

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen marked 2 inline comments as done. timshen added inline comments. Comment at: clang/include/clang/Driver/Options.td:971-973 +def fexperimental_new_pass_manager_EQ : Joined<["-"], "fexperimental-new-pass-manager=">, + Group, Flags<[CC1Option]>, + HelpText<"Enables an exp

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

chandlerc added a comment. This looks great to me with a CC1-layer flag. But check that others are happy as well, thanks! https://reviews.llvm.org/D34790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795934, @hfinkel wrote: > In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > > > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > > > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > > > > > I

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

mati865 added a comment. Sorry @martell I totally forgot about it. I'll test https://reviews.llvm.org/D33638 later today. Repository: rL LLVM https://reviews.llvm.org/D34606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This seems like a good idea. Thanks! https://reviews.llvm.org/D34839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r306753 - [ODRHash] Improve typedef handling.

Author: rtrieu Date: Thu Jun 29 15:53:04 2017 New Revision: 306753 URL: http://llvm.org/viewvc/llvm-project?rev=306753&view=rev Log: [ODRHash] Improve typedef handling. Follow typedef chains to find the root type when processing types, and also keep track of qualifiers. Modified: cfe/trunk/l

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795980, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795934, @hfinkel wrote: > > > In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > > > > > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > > > > > In

  1   2   >