Hi, -----Original Message----- From: Blower, Melanie [mailto:melanie.blo...@intel.com] Sent: Thursday, June 29, 2017 5:35 AM To: reviews+d34158+public+125da21f27579...@reviews.llvm.org; zhangsheng...@huawei.com; olivier...@gmail.com; kalinichev.s...@gmail.com; kf...@kde.org; m...@milianw.de; Keane, Erich <erich.ke...@intel.com>; Hahnfeld, Jonas <hahnf...@itc.rwth-aachen.de>; mgo...@gentoo.org; fedor.serg...@oracle.com; rich...@metafoo.co.uk; renato.go...@linaro.org Cc: cfe-commits@lists.llvm.org; kli...@google.com; simon.dar...@imgtec.com; anastasia.stul...@arm.com; arichardson....@gmail.com Subject: RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>
[...] ================ Comment at: test/Driver/gcc-predef.c:9 + #else + #if !defined( _STDC_PREDEF_H ) + #error "stdc-predef.h should be preincluded for GNU/Linux 4.8 and higher" ---------------- The driver will only include `stdc-predef.h` if it can be found in the system. With that, the current version of this test will only run on such Linux system. Maybe add a basic tree in `test/Driver/Inputs` and test that the corresponding header is included? >>>OK I understand what you mean now. To be clear here: I was thinking about running this test case on let's say Darwin/Mac OS X != GNU/Linux. But you probably figured that out of my imprecise comment already. Sorry about that. Regards, Jonas
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
