arphaman added inline comments.
================
Comment at: include/clang/Tooling/ASTDiff/ASTDiffInternal.h:184
+
+ std::string getNodeValueI(NodeId Id) const;
+ std::string getNodeValueI(const DynTypedNode &DTN) const;
----------------
`getNodeValueImpl`?
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:439
+// Computes an optimal mapping between two trees.
+class ZsMatcher {
+ const ASTDiff::Impl &DiffImpl;
----------------
Do you know the reason for the `ZsMatcher` name? I noticed that they used it in
the GumTree java implementation as well. If it's based on some paper you should
add a comment that mentions it.
https://reviews.llvm.org/D34329
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
