Author: omtcyfz
Date: Tue Aug 9 02:14:48 2016
New Revision: 278099
URL: http://llvm.org/viewvc/llvm-project?rev=278099&view=rev
Log:
[clang-rename] fix bug with initializer lists
Clang-rename is currently not able to find a symbol in initializer list. This
patch fixes described issue.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278099: [clang-rename] fix bug with initializer lists
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23193?vs=67289&id=67290#toc
Repository:
rL LLVM
https://reviews.llvm.o
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
In https://reviews.llvm.org/D21134#508511, @aaron.ballman wrote:
> Is there a reason we don't want this check to be a part of the clang
> frontend, rather than as a clang-tidy check?
I discussed this with fronte
danielmarjamaki added a comment.
In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
> I think the replacement is wrong for something like:
>
> int *arr; int offs1, offs2;
> offs1[arr + offs2] = 42;
>
>
> which I think would give:
>
> int *arr; int offs1, offs2;
> arr + offs2[offs
ioeric updated this revision to Diff 67292.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Nits fixed
https://reviews.llvm.org/D23257
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/I
Author: ioeric
Date: Tue Aug 9 02:54:49 2016
New Revision: 278101
URL: http://llvm.org/viewvc/llvm-project?rev=278101&view=rev
Log:
Fix clang-tidy crash when a single fix is applied on multiple files.
Summary:
tooling::Replacements only holds replacements for a single file, so
this patch makes F
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278101: Fix clang-tidy crash when a single fix is applied on
multiple files. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D23257?vs=67292&id=67293#toc
Repository:
rL LLVM
hokein updated this revision to Diff 67294.
hokein added a comment.
Update comments, don't mention absolute file path since this is no guarantee
about that.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext
He Petr,
This commit (and #121757) have broken a couple of builders, see:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-x86_64-linux-debian/builds/135
We are also seeing this on our downstream builders.
Cheers,
/ Asiri
On Mon, Aug 8, 2016 at 11:09 PM, Petr Hosek via cfe-commits
Author: hokein
Date: Tue Aug 9 03:26:19 2016
New Revision: 278102
URL: http://llvm.org/viewvc/llvm-project?rev=278102&view=rev
Log:
[include-fixer] Support processing multiple files in one run.
Summary:
Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to
include-fixer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278102: [include-fixer] Support processing multiple files in
one run. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23266?vs=67294&id=67296#toc
Repository:
rL LLVM
https:/
alexshap created this revision.
alexshap added reviewers: omtcyfz, alexfh.
alexshap added a subscriber: cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
nit: use isWritten and const auto *Initializer in
NamedDeclFindingA
NoQ added inline comments.
Comment at: lib/Rewrite/HTMLRewrite.cpp:304
@@ -303,2 +303,3 @@
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -1em; l
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509047, @Eugene.Zelenko wrote:
> May be this could be Clang-rename mode?
Definitely not.
I think this is in scope of `clang-tidy`.
In https://reviews.llvm.org/D23279#509076, @compnerd wrote:
> Th
omtcyfz added a comment.
And actually it makes much more sense for C than for C++. In C++ you just do
`s/struct/class/g`, insert `public:` and you're golden.
P.S. It actually breaks code. I haven't looked into that, but
bar::Foo foo = { &x, 17, 1.29, 0 }; // CHECK: bar::Foo foo = { 1.29, 0, 1
klimek added a comment.
In https://reviews.llvm.org/D23279#509568, @omtcyfz wrote:
> And actually it makes much more sense for C than for C++. In C++ you just do
> `s/struct/class/g`, insert `public:` and you're golden.
That doesn't work if you want to minimize object size, though?
Repositor
omtcyfz added a comment.
Please fix the same thing @ `USRLocFinder.cpp:47`.
Other than that, looks OK - a bit more readable. Thanks.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
alexshap updated this revision to Diff 67301.
alexshap added a comment.
Fix clang-rename/USRLocFinder.cpp:47 as well
https://reviews.llvm.org/D23298
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
Index: clang-rename/USRLocFinder.cpp
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509567, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#509047, @Eugene.Zelenko wrote:
>
> > May be this could be Clang-rename mode?
>
>
> Definitely not.
>
> I think this is in scope of `clang-tidy`.
>
> In https://reviews.llvm.org
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509570, @klimek wrote:
> In https://reviews.llvm.org/D23279#509568, @omtcyfz wrote:
>
> > And actually it makes much more sense for C than for C++. In C++ you just
> > do `s/struct/class/g`, insert `public:` and you're golden.
>
>
> Tha
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
Do you have a commit access or do you need me to land the patch?
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cf
alexshap added a comment.
> Do you have a commit access or do you need me to land the patch?
No, I don't. I will be grateful to you if you land the patch. Thanks.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.
omtcyfz added a comment.
Sure.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Tue Aug 9 05:00:23 2016
New Revision: 278110
URL: http://llvm.org/viewvc/llvm-project?rev=278110&view=rev
Log:
[analyzer] Try to fix coverity CID 1360469.
Patch by Raphael Isemann!
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Analysis/
klimek added a comment.
In https://reviews.llvm.org/D23279#509606, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#509567, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D23279#509047, @Eugene.Zelenko wrote:
> >
> > > May be this could be Clang-rename mode?
> >
> >
> > Definitely not.
> >
Author: rksimon
Date: Tue Aug 9 05:02:11 2016
New Revision: 278111
URL: http://llvm.org/viewvc/llvm-project?rev=278111&view=rev
Log:
Fix Wdocumentation unknown parameter warning
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.h
Modified: clang-tools-extra/trunk/include-fixer/In
Author: omtcyfz
Date: Tue Aug 9 05:03:33 2016
New Revision: 278112
URL: http://llvm.org/viewvc/llvm-project?rev=278112&view=rev
Log:
[clang-rename] cleanup: use isWritten
nit: use isWritten and const auto *Initializer in
NamedDeclFindingASTVisitor::VisitCXXConstructorDecl method.
Test plan: make
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278112: [clang-rename] cleanup: use isWritten (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23298?vs=67301&id=67309#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2329
omtcyfz added a comment.
FYI: I think the diff (accessible by `Download Raw Diff`) is corrupted for some
reason; at least I don't see `Index: test/clang-rename/USRLocFinder.cpp` line
in the end, which should be present, I guess.
Repository:
rL LLVM
https://reviews.llvm.org/D23298
___
xazax.hun added a comment.
In case there is a more complex condition does it only highligh the part that
influenced taking the branch?
E.g.:
if (a || b) { // HIghlight only a, if a was true and b was not evaluated
}
https://reviews.llvm.org/D23300
___
sylvestre.ledru added a comment.
To be clear, this is blocking Mozilla to use much more clang-format
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
opilarium added a comment.
It's the huge deal for my company too. It would be nice if you reconsider.
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
opilarium added a comment.
Can we just accept this merge request? It's backward compatible and helps
Mozilla to adapt clang-format.
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
djasper added a comment.
I still believe it's wrong to care about this in particular, but I also don't
want to hold clang-format hostage for my own beliefs. Obviously, enough people
care and the costs are limited.
Comment at: include/clang/Format/Format.h:356
@@ +355,3 @@
+ /
sylvestre.ledru added a comment.
Thanks. I am rebasing and updating the patch.
I don't know if poiru is still around.
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
danielmarjamaki updated this revision to Diff 67322.
danielmarjamaki added a comment.
take care of review comments
https://reviews.llvm.org/D21134
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MisplacedArrayIndexCheck.cpp
clang-tidy/readability/MisplacedArrayIndexChe
danielmarjamaki marked 4 inline comments as done.
danielmarjamaki added a comment.
as far as I see the only unsolved review comment now is about macros. if it can
be handled better.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:28-29
@@ +27,4 @@
+
filcab added a comment.
Ping!
https://reviews.llvm.org/D21695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Aug 8, 2016 at 11:36 PM, Piotr Padlewski
wrote:
>
>
> 2016-08-08 8:33 GMT-07:00 Aaron Ballman :
>>
>> aaron.ballman added inline comments.
>>
>>
>> Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61
>> @@ +58,5 @@
>> + IncludeStyle(utils::IncludeSorter::pars
aaron.ballman added inline comments.
Comment at: test/clang-tidy/readability-misplaced-array-index.cpp:31
@@ +30,3 @@
+ x[10] = 0;
+ dostuff(0[0 + ABC]);
+}
Why is this considered to be "normal syntax" and not worth getting a diagnostic?
https://reviews.llvm.o
opilarium added a comment.
> Thanks. I am rebasing and updating the patch.
Waiting for you.
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Aug 8, 2016 at 8:13 PM, Alexander Riccio wrote:
> ariccio added a comment.
>
> In https://reviews.llvm.org/D18073#504216, @dcoughlin wrote:
>
>> No. The identifier info will be null for C++ operators.
>
>
> I assume you mean `operator new/new[]/delete/delete[]
Correct.
~Aaron
>
>> > Thu
danielmarjamaki marked 2 inline comments as done.
Comment at: test/clang-tidy/readability-misplaced-array-index.cpp:31
@@ +30,3 @@
+ x[10] = 0;
+ dostuff(0[0 + ABC]);
+}
aaron.ballman wrote:
> Why is this considered to be "normal syntax" and not worth getting a
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:186
@@ +185,3 @@
+def warn_drv_argument_requires : Warning<
+ "argument '%0' requires %1">,
+ InGroup;
Given that there's only one driver option that requires this diag
vbyakovl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
}
-return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
- /*AllowBothBool*/true,
- /*AllowBool
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but I am also not well-versed in vector operations, so you may want to
wait a day or two for @uweigand or someone else to sign off as well.
Comment at: ll
omtcyf0 updated this revision to Diff 67328.
omtcyf0 added a comment.
Address comments Alex made.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/modernize-deprecated-headers-cxx
With 3.9 coming around, I'd like to suggest that we pull this warning from
3.9 and maybe trunk. It sounds like Sean found it only possible to deploy
this warning since they already had a workaround for a different compiler
bug (!). In Chromium, we can't enable this warning since one of our
(admitte
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added subscribers: cfe-commits, vsk.
One of the goals of the project was to find bugs caused by copy-pasting, which
happen when a piece of code is copied but not all variables in this piece of
cod
jroelofs added a comment.
In https://reviews.llvm.org/D21134#509522, @danielmarjamaki wrote:
> In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
>
> > I think the replacement is wrong for something like:
> >
> > int *arr; int offs1, offs2;
> > offs1[arr + offs2] = 42;
> >
> >
> > wh
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added a subscriber: cfe-commits.
So far macro-generated code was treated by the CloneDetector as normal code.
This caused that some macros where reported as false-positive clones because
their gen
omtcyf0 updated this revision to Diff 67334.
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
Address remaining comments.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/c
danielmarjamaki updated this revision to Diff 67337.
danielmarjamaki added a comment.
More generic diagnostic. Diagnose all integerType[pointerType] expressions.
https://reviews.llvm.org/D21134
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MisplacedArrayIndexCheck.cpp
danielmarjamaki updated this revision to Diff 67338.
danielmarjamaki added a comment.
ran clang-format
https://reviews.llvm.org/D21134
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MisplacedArrayIndexCheck.cpp
clang-tidy/readability/MisplacedArrayIndexCheck.h
clang
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
https://reviews.llvm.org/D21134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 67335.
sfantao marked an inline comment as done.
sfantao added a comment.
- Move CUDA C++ include path tests to cuda-detect.cu. Address other Art's
comments.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-detect.cu
Index: test/Driver/cuda-detec
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: djasper.
sylvestre.ledru added subscribers: opilarium, cfe-commits, klimek.
This is required for compliance with the Mozilla style guide.
This is a rebase+minor change of Birunthan Mohanathas's patch
https://reviews.llvm.o
sylvestre.ledru added a comment.
Done in https://reviews.llvm.org/D23317
https://reviews.llvm.org/D10807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D23317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
sylvestre.ledru added a comment.
Thanks!
I don't think you want it but do you want me to add this to the 4.0 release
notes?
https://reviews.llvm.org/D23317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: sylvestre
Date: Tue Aug 9 09:24:40 2016
New Revision: 278121
URL: http://llvm.org/viewvc/llvm-project?rev=278121&view=rev
Log:
clang-format: Add SpaceAfterTemplate
Summary:
This is required for compliance with the Mozilla style guide.
This is a rebase+minor change of Birunthan Mohanatha
compnerd added a comment.
If the argument really is that we want to minimize the tools then Id argue that
`clang-rename` also belongs in `clang-tidy` as it would be used to rename
fields to match the naming convention (tidying up your code base).
`clang-tidy` could work, but it does seem to be
omtcyfz updated this revision to Diff 67347.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Address the comments.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
test/clang-
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added subscribers: cfe-commits, vsk.
StmtDataCollector currently crashes on function calls because they don't have a
callee. This patch fixes this.
https://reviews.llvm.org/D23320
Files:
lib/An
On Mon, Aug 8, 2016 at 1:20 PM, Hans Wennborg wrote:
> I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to
> have always been trunk-svn, and it's at least not as misleading as
> having the wrong number.
>
> I wonder if PACKAGE_VERSION is actually important for anything in
> libcxx
compnerd added a comment.
Theres a frontend mangler and a backend mangler. You should try this on
Windows GNU environments :-).
https://reviews.llvm.org/D22666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
AFAIK there's no need to do that, integer types are by default initialized with
0, aren't they?
https://reviews.llvm.org/D23198
NoQ added a comment.
In https://reviews.llvm.org/D23300#509665, @xazax.hun wrote:
> In case there is a more complex condition does it only highligh the part that
> influenced taking the branch?
>
> E.g.:
>
> if (a || b) { // HIghlight only a, if a was true and b was not evaluated
> }
>
No
vmiklos added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
omtcyfz wrote:
> AFAIK there's no need to do that, integer types are by default initialized
> with 0, aren't they?
Are you sure? He
Author: mboehme
Date: Tue Aug 9 10:07:52 2016
New Revision: 278123
URL: http://llvm.org/viewvc/llvm-project?rev=278123&view=rev
Log:
[ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()
Summary: Required for D0
Reviewers: sbenza, klimek, aaron.ballman, alexfh
Subscribers: al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278123: [ASTMatchers] Add matchers canReferToDecl() and
hasUnderlyingDecl() (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23004?vs=66912&id=67353#toc
Repository:
rL LLVM
opilarium added a comment.
Thanks a lot!
https://reviews.llvm.org/D23317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:45
@@ +44,3 @@
+ for (const auto &BindingName :
+ {"return", "continue", "break", "goto", "throw"}) {
+if (Result.Nodes.getNodeAs(BindingName)) {
This won't work i
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:55
@@ +54,3 @@
+ CStyledHeaderToCxx =
+ {{"assert.h", "cassert"},
+{"complex.h", "complex"},
---
yaxunl created this revision.
yaxunl added reviewers: nhaustov, Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
https://reviews.llvm.org/D23322
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/T
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM.
https://reviews.llvm.org/D23320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
I don't think this is worth a release note.
https://reviews.llvm.org/D23317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
> If the argument really is that we want to minimize the tools then Id argue
> that `clang-rename` also belongs in `clang-tidy` as it would be used to
> rename fields to match the naming convention (tidying up
aaron.ballman added a comment.
In https://reviews.llvm.org/D23279#510002, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
>
> > If the argument really is that we want to minimize the tools then Id argue
> > that `clang-rename` also belongs in `clang-tidy` as it woul
benlangmuir added a comment.
Sorry for the delay, I apparently forgot to hit submit. Replied inline.
Comment at: lib/Frontend/CompilerInstance.cpp:1491
@@ +1490,3 @@
+false/*IsExplicit*/).first;
+Module->IsSystem = true;
+Module->IsFromModuleFile = tr
rogfer01 created this revision.
rogfer01 added reviewers: aaron.ballman, rsmith.
rogfer01 added subscribers: cfe-commits, rsmith.
This is a WIP for PR28571.
As suggested by @rsmith it introduces a new ObjectKind for PackedField's
modeled similarly in spirit to BitField's. If the reference is con
rogfer01 added inline comments.
Comment at: lib/Sema/SemaInit.cpp:4202-4204
@@ +4201,5 @@
+
+ It is not possible to bind w to a temporary of a.x because this
+ would require (recursively) invoking the copy constructor of
+ std::vector to obtain first a (properly
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510011, @aaron.ballman wrote:
> In https://reviews.llvm.org/D23279#510002, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
> >
> > > If the argument really is that we want to minimize the tools then Id
Whether enable this warning or not should be determined by user feedback.
The warning was implemented to help users in complicated cases that arise
in module-enabled builds. It seems however that it makes troubles for other
users. Based on feedback on this list I feel that it is better to make this
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:25
@@ +24,3 @@
+ forEach(ifStmt(hasThen(stmt(anyOf(
+ returnStmt().bind("return"),
+
On Tue, Aug 9, 2016 at 12:14 PM, Kirill Bobyrev
wrote:
> omtcyfz added a comment.
>
> In https://reviews.llvm.org/D23279#510011, @aaron.ballman wrote:
>
>> In https://reviews.llvm.org/D23279#510002, @omtcyfz wrote:
>>
>> > In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
>> >
>> > > If
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
vmiklos wrote:
> omtcyfz wrote:
> > AFAIK there's
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
omtcyfz wrote:
> vmiklos wrote:
> > omtcyfz wrote:
> > > AFAIK there's no need to do that, integer types are by default
> > > initi
alexshap added a comment.
First of all, many thanks for the comments & proposal of clang-refactor.
1. Regarding high-level project organization:
clang-refactor - that can be a good place for various refactoring techniques
like the existing clang-rename, my simple tool, etc - essentially what Kir
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra added inline comments.
Comment at: test/Driver/cuda-detect.cu:75-77
@@ -74,1 +74,5 @@
+// Verify that compiler accepts CUDA syntax with "-x cuda-cpp-output".
+// RUN: %clang -Werror -fsyntax-only -x cuda-cpp-output -c %s
+//
+// Verify that C++ include paths are passed for b
bcraig added a subscriber: bcraig.
bcraig added a comment.
In https://reviews.llvm.org/D23279#509017, @Eugene.Zelenko wrote:
> Do we really need standalone tool for this purpose? If I'm not mistaken,
> Static Analyzer already has clang-analyzer-optin.performance.Padding check,
> which is also a
bcraig added a comment.
It is very common for developers to put comments near a field. If this tool
doesn't move the "anchored" comments, then its utility will be severely limited.
Does this tool also reorder C++ member initializer lists? If it doesn't, then
running this tool will introduce w
alexshap added a comment.
> The excess padding checker doesn't provide a fix-it.
yup, although i think it would be useful to add one of the optimal layouts to
the report
(i have a diff for that (still in the oven), i have not sent it for code review
yet).
But as i mentioned above - it seems to
sfantao updated this revision to Diff 67366.
sfantao marked an inline comment as done.
sfantao added a comment.
- Remove redundant test - copied by mistake.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-detect.cu
Index: test/Driver/cuda-detect.cu
===
sfantao added inline comments.
Comment at: test/Driver/cuda-detect.cu:75-77
@@ -74,1 +74,5 @@
+// Verify that compiler accepts CUDA syntax with "-x cuda-cpp-output".
+// RUN: %clang -Werror -fsyntax-only -x cuda-cpp-output -c %s
+//
+// Verify that C++ include paths are passed f
jlebar updated this revision to Diff 67367.
jlebar marked an inline comment as done.
jlebar added a comment.
Address review comments, and don't abort codegen'ing a function if it has only
deferred warnings -- check specifically for errors.
https://reviews.llvm.org/D23241
Files:
clang/include/
jlebar added a comment.
Reid, I'd still like you to have a look at this one if you don't mind, since
it's outside my and Art's core competencies.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886
@@ +2885,3 @@
+ // Check if this function has diagnostics that should be emitt
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510061, @alexshap wrote:
> First of all, many thanks for the comments & proposal of clang-refactor.
>
> 1. Regarding high-level project organization: clang-refactor - that can be a
> good place for various refactoring techniques like th
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
1 - 100 of 195 matches
Mail list logo
