benlangmuir added a comment. Sorry for the delay, I apparently forgot to hit submit. Replied inline.
================ Comment at: lib/Frontend/CompilerInstance.cpp:1491 @@ +1490,3 @@ + false/*IsExplicit*/).first; + Module->IsSystem = true; + Module->IsFromModuleFile = true; ---------------- manmanren wrote: > benlangmuir wrote: > > Why do we assume this? > Thanks for reviewing so quickly! > > I was not sure about what value we should set IsSystem. Since we are mostly > prebuilding system modules, I assumed "true". Do you have any suggestion here? I guess treating it as system is the more forgiving option, so I'm okay with keeping it. It's probably worth adding a comment that this is not always the correct choice, since it can affect diagnostics, etc. https://reviews.llvm.org/D23125 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
