On Mon, Aug 8, 2016 at 1:20 PM, Hans Wennborg <h...@chromium.org> wrote:
> I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to > have always been trunk-svn, and it's at least not as misleading as > having the wrong number. > > I wonder if PACKAGE_VERSION is actually important for anything in > libcxx, libcxxabi and libunwind? At least for libcxx, the important > version is _LIBCPP_VERSION in include/__config. > I don't believe we use `PACKAGE_VERSION`. I can see it being useful though as CPack would use that value. > Thanks, > Hans > > On Mon, Aug 8, 2016 at 11:01 AM, Eugene Zelenko via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: eugenezelenko > > Date: Mon Aug 8 13:01:50 2016 > > New Revision: 278032 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=278032&view=rev > > Log: > > CMakeLists.txt cleanups: synchronize version with rest of LLVM, > consistent spacing. > > > > Differential revision: https://reviews.llvm.org/D23091 > > > > Modified: > > libcxx/trunk/CMakeLists.txt > > > > Modified: libcxx/trunk/CMakeLists.txt > > URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/ > CMakeLists.txt?rev=278032&r1=278031&r2=278032&view=diff > > ============================================================ > ================== > > --- libcxx/trunk/CMakeLists.txt (original) > > +++ libcxx/trunk/CMakeLists.txt Mon Aug 8 13:01:50 2016 > > @@ -26,10 +26,10 @@ if (LIBCXX_BUILT_STANDALONE) > > project(libcxx CXX C) > > > > set(PACKAGE_NAME libcxx) > > - set(PACKAGE_VERSION trunk-svn) > > + set(PACKAGE_VERSION 4.0.0svn) > > set(PACKAGE_STRING "${PACKAGE_NAME} ${PACKAGE_VERSION}") > > set(PACKAGE_BUGREPORT "llvm-b...@lists.llvm.org") > > -endif () > > +endif() > -- Saleem Abdulrasool compnerd (at) compnerd (dot) org
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
