danielmarjamaki marked 2 inline comments as done. ================ Comment at: test/clang-tidy/readability-misplaced-array-index.cpp:31 @@ +30,3 @@ + x[10] = 0; + dostuff(0[0 + ABC]); +} ---------------- aaron.ballman wrote: > Why is this considered to be "normal syntax" and not worth getting a > diagnostic? hmm.. I agree that it would be good to have a diagnostic for this code also.
I currently only diagnose when subscript is stringLiteral, declRefExpr or memberExpr. These are the cases when the code can be easily fixed by just replacing the expressions. I will look into writing a diagnostic for this also. https://reviews.llvm.org/D21134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
