stbuehler updated this revision to Diff 44972.
stbuehler marked an inline comment as done.
stbuehler added a comment.
- disable dervied abi tags in some recursions to fix infinite recursions
- don't emit abi tags for NestedNameSpecifier::Identifier
Repository:
rL LLVM
http://reviews.llvm.org/
a.sidorin created this revision.
a.sidorin added reviewers: klimek, aaron.ballman.
a.sidorin added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch enables matching for FunctionDecls that have bodies.
http://reviews.llvm.org/D16215
Files:
include/clang/ASTMatchers/ASTMa
petpav01 added a comment.
Ping. I would still like to address this problem. Could I please get a review
on the last version of the patch?
Thanks,
Petr
http://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: kcc, rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Fix for a case found by fuzzing PR23057 (comment #33
https://llvm.org/bugs/show_bug.cgi?id=23057#c33). Diagnose and consume
unexpected ::new and ::delete to
stbuehler updated this revision to Diff 44973.
stbuehler added a comment.
integrate patch by Stephan Bergmann :
- Fix handling of abi_tag attribute on namespaces to match GCC behavior:
- Forbid the attribute on unnamed namespaces. (GCC merely produces a warning
instead of an error for unnamed
a.sidorin updated this revision to Diff 44975.
a.sidorin added a comment.
Update comments and documentation.
http://reviews.llvm.org/D16215
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.cpp
unittests/ASTMatchers/Dy
realincubus added a comment.
ok after i checked out a recent version of clang and applied the patch
http://reviews.llvm.org/D15729 i can verify, that one does not have to add the
symbols to the libclang.exports file.
i believe the plugin mechanism was changed between the first version of my
pl
Hi Chris,
This doesn't seem to work when building clang separately from llvm. LLVMLinux
fails to build clang with:
CMake Error at CMakeLists.txt:104 (include):
include could not find load file:
VersionFromVCS
CMake Error at CMakeLists.txt:222 (add_v
a.makarov added a comment.
Thanks for review! I've understood your idea, I'm working on updating the patch.
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
foutrelis added a comment.
The latest patch still applies (relatively cleanly) to Clang 3.7.x which is
nice. The infinite recursion segfaults appear to be gone, thanks!
There are a few test failures which I assume will be need to be addressed later
on: F1315853: clang-diff-44973-test-failures.l
alexfh added a subscriber: alexfh.
alexfh added a comment.
Manuel, can you take a look at this?
http://reviews.llvm.org/D15506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
The examples and test code you use seem to imply that the isDefinition()
matcher may be all you need; is isDefinition() insufficient for some reason? If
so, can you expand the test cases to cover that particular usage? Also,
FunctionDecl::getBody() does more work
klimek added a reviewer: bkramer.
klimek added a comment.
Adding Benjamin for an additional pair of eyes.
Generally looks good.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:351
@@ +350,3 @@
+
+ // First, match the name.
+ if (!MatchNodeName(Pattern, Node))
-
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: aaron.ballman.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Allow "mode" attribute for enum types, except for vector modes, for
compatibility with GCC. Support "mode" attribute with dependent types.
http://reviews
This test fails on OS X for me:
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: libc++abi :: incomplete_type.sh.cpp (29529 of 29545)
TEST 'libc++abi :: incomplete_type.sh.cpp' FAILED
Script:
--
/Applications/Xcode.app/Contents/Developer/T
I reverted this and 322 for now in 257896.
On Fri, Jan 15, 2016 at 10:36 AM, Nico Weber wrote:
> This test fails on OS X for me:
>
>
> Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
> FAIL: libc++abi :: incomplete_type.sh.cpp (29529 of 29545)
> TEST 'libc++abi ::
Author: nico
Date: Fri Jan 15 09:44:14 2016
New Revision: 257896
URL: http://llvm.org/viewvc/llvm-project?rev=257896&view=rev
Log:
Revert r256322 (and follow-up 256323), the test it added does not pass on OS X.
Removed:
libcxxabi/trunk/test/incomplete_type.sh.cpp
Modified:
libcxxabi/trunk
NoQ added a comment.
Managed to reproduce the build error with `-fmodules` on my machine.
Committed the updated patch as r257893, the buildbot seems happy.
I hope this review is actually closed now :)
http://reviews.llvm.org/D15448
___
cfe-commits m
Author: alexfh
Date: Fri Jan 15 10:16:47 2016
New Revision: 257900
URL: http://llvm.org/viewvc/llvm-project?rev=257900&view=rev
Log:
[clang-tidy] Fix a copy-paste error.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Modified: clang-tools-extra/trunk/clang-tidy/
Ping :-)
On Mon, Jan 11, 2016 at 8:49 AM, Bruno Cardoso Lopes
wrote:
> bruno added a comment.
>
> Ping!
>
>
> http://reviews.llvm.org/D15173
>
>
>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: dergachev
Date: Fri Jan 15 09:22:05 2016
New Revision: 257893
URL: http://llvm.org/viewvc/llvm-project?rev=257893&view=rev
Log:
[analyzer] Provide .def-files and visitors for SVal/SymExpr/MemRegion, v2.
Provide separate visitor templates for the three hierarchies, and also
the `FullSValVi
Should this be merged to 3.8?
On Thu, Jan 14, 2016 at 8:36 PM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Thu Jan 14 22:36:32 2016
> New Revision: 257868
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257868&view=rev
> Log:
> PR26111: segmentation fault with __attribute__((m
On Fri, Jan 15, 2016 at 11:52 AM, Hans Wennborg via cfe-commits
wrote:
> Should this be merged to 3.8?
I can't speak to whether it severe enough to warrant it, but I think
that it is sufficiently safe to merge.
~Aaron
>
> On Thu, Jan 14, 2016 at 8:36 PM, Alexey Bataev via cfe-commits
> wrote:
Thanks for the heads up. It looks like that module is was excluded from the
LLVM install. I’ve changed that in LLVM r257909. That change should resolve
your build issue. Please let me know if you continue having problems.
Thanks,
-Chris
> On Jan 15, 2016, at 5:18 AM, Daniel Sanders wrote:
>
>
hokein updated this revision to Diff 45006.
hokein marked an inline comment as done.
hokein added a comment.
Add extension-less header file doc.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-ti
aaron.ballman added inline comments.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:48
@@ +47,3 @@
+
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+ HeaderFileExtensionsSet &HeaderFileExtensions) {
--
hokein marked 2 inline comments as done.
Comment at: clang-tidy/ClangTidyOptions.cpp:269
@@ +268,3 @@
+ SmallVector Suffixes;
+ HeaderFileExtensions.split(Suffixes, ',');
+ for (const auto& Suffix : Suffixes) {
aaron.ballman wrote:
> alexfh wrote:
> > It's rath
ahatanak added reviewers: mclow.lists, EricWF, joerg, howard.hinnant.
ahatanak added a comment.
Adding reviewers
http://reviews.llvm.org/D15897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
betulb added a comment.
ping?
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Dec 17, 2015 at 4:51 AM, Marina Yatsina via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: myatsina
> Date: Thu Dec 17 06:51:51 2015
> New Revision: 255890
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255890&view=rev
> Log:
> [ms-inline-asm] Add support for composite struct
Author: cbertol
Date: Fri Jan 15 12:50:31 2016
New Revision: 257917
URL: http://llvm.org/viewvc/llvm-project?rev=257917&view=rev
Log:
Add OpenMP dist_schedule clause to distribute directive and related regression
tests.
Added:
cfe/trunk/test/OpenMP/distribute_dist_schedule_ast_print.cpp
carlo.bertolli added a comment.
Committed revision 257917.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dws added a comment.
Ping?
http://reviews.llvm.org/D16102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Please notify of any issues.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rsmith added a comment.
This isn't quite the right way to fix this issue.
Comment at: lib/Parse/ParseDeclCXX.cpp:3206-3209
@@ -3205,6 +3205,6 @@
// we're just missing a comma.
else if (Tok.isOneOf(tok::identifier, tok::coloncolon)) {
SourceLocation Loc = PP.getL
xazax.hun updated this revision to Diff 45022.
xazax.hun added a comment.
- Address a review comment.
- Fix an assertion failure for methods that has non-identifier name e.g.:
destructors.
- Ignore qualifiers.
http://reviews.llvm.org/D16179
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
t
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
In http://reviews.llvm.org/D16179#326746, @alexfh wrote:
> > ... What about a configuration option to also report near misses when only
> > a qualifier is missing?
>
>
> Might be a useful thing. We should first check if it ma
zaks.anna added a comment.
> I see, so essentially you want to use a different approach for determining
> sanitizer availability (on OS X for now): if the library is present, then we
> support
> sanitizer, otherwise we don't: i.e. the binary distribution is the source of
> truth, not the lis
Author: cbieneman
Date: Fri Jan 15 15:21:12 2016
New Revision: 257934
URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
Log:
[CMake] Support generation of linker order files using dtrace
Summary:
This patch extends the lit-based perf-training tooling supplied for PGO data
generation t
thakis added a comment.
This test is failing again when it runs as part of llvm's tests when I
build a clang package for chromium. It passes when I run it in my regular
llvm build directory (where I ran it to test my "fix") -- this explains why
the fix didn't work when I tried it in the chrome cas
Author: cbieneman
Date: Fri Jan 15 15:30:06 2016
New Revision: 257936
URL: http://llvm.org/viewvc/llvm-project?rev=257936&view=rev
Log:
[CMake] [Order-files] Use print_function as an attempt at being forward
compatible.
Based on feedback from bogner.
Modified:
cfe/trunk/utils/perf-training/
thakis added a comment.
In http://reviews.llvm.org/D15363#321941, @samsonov wrote:
> Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
> Windows? Seems so: I don't see an XFAIL there, and it also uses
> suppressions, but with single quote, followed by double quote:
>
> %
Author: dcoughlin
Date: Fri Jan 15 15:35:40 2016
New Revision: 257938
URL: http://llvm.org/viewvc/llvm-project?rev=257938&view=rev
Log:
[analyzer] Check for return of nil in ObjC methods with nonnull return type.
Update NullabilityChecker so that it checks return statements in ObjC methods.
Previ
rtrieu added a comment.
I've fixed this issue as part of the template type diffing refactoring.
r257870 was the last of the refactoring, and includes your test case in it.
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lis
dim added a subscriber: dim.
dim added a comment.
In http://reviews.llvm.org/D16102#324395, @davide wrote:
> I'm fine with this solution but Saleem pointed out there are some changes
> that need to be made before getting this in.
@compnerd, what were these changes to be made?
http://reviews.
Author: nico
Date: Fri Jan 15 15:45:31 2016
New Revision: 257939
URL: http://llvm.org/viewvc/llvm-project?rev=257939&view=rev
Log:
Make -Wdelete-non-virtual-dtor warn on explicit `a->~A()` dtor calls too.
-Wdelete-non-virtual-dtor warns if A is a type with virtual functions but
without virtual dt
thakis closed this revision.
thakis added a comment.
r257939, thanks!
http://reviews.llvm.org/D16206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk abandoned this revision.
rnk added a comment.
Thanks!
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: joerg
Date: Fri Jan 15 16:29:34 2016
New Revision: 257947
URL: http://llvm.org/viewvc/llvm-project?rev=257947&view=rev
Log:
Avoid self-assignment of SmallString, trigger UB behavior down the road.
Modified:
cfe/trunk/tools/driver/driver.cpp
Modified: cfe/trunk/tools/driver/driver.cpp
Author: cbieneman
Date: Fri Jan 15 16:44:18 2016
New Revision: 257948
URL: http://llvm.org/viewvc/llvm-project?rev=257948&view=rev
Log:
[CMake] Fix bots broken by including order file generation in check-all
Modified:
cfe/trunk/utils/perf-training/CMakeLists.txt
Modified: cfe/trunk/utils/per
On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: joerg
> Date: Fri Jan 15 16:29:34 2016
> New Revision: 257947
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257947&view=rev
> Log:
> Avoid self-assignment of SmallString, trigger U
On Fri, Jan 15, 2016 at 11:52 PM, David Blaikie via cfe-commits
wrote:
>
>
> On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits
> wrote:
>>
>> Author: joerg
>> Date: Fri Jan 15 16:29:34 2016
>> New Revision: 257947
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=257947&view=re
On Fri, Jan 15, 2016 at 02:52:08PM -0800, David Blaikie via cfe-commits wrote:
> On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > Author: joerg
> > Date: Fri Jan 15 16:29:34 2016
> > New Revision: 257947
> >
> > URL: http://llvm.org/v
On Fri, Jan 15, 2016 at 2:56 PM, Benjamin Kramer
wrote:
> On Fri, Jan 15, 2016 at 11:52 PM, David Blaikie via cfe-commits
> wrote:
> >
> >
> > On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits
> > wrote:
> >>
> >> Author: joerg
> >> Date: Fri Jan 15 16:29:34 2016
> >> New Revi
thakis added a comment.
I figured out the difference. If I set up my environment by running
`setenv.cmd` in the windows sdk, the test fails. If I set it up by running
`vcvarsall.bat`, the test succeeds. Not clear yet why. But with the setenv.cmd
setup, the asan suppression test fails too.
Rep
On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits
wrote:
> Author: cbieneman
> Date: Fri Jan 15 15:21:12 2016
> New Revision: 257934
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
> Log:
> [CMake] Support generation of linker order files using dtrace
>
> Summary:
> This
thakis added a comment.
I re-disabled the test in 257952.
Repository:
rL LLVM
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
That should be fixed with r257948.
-Chris
> On Jan 15, 2016, at 3:19 PM, Renato Golin wrote:
>
> On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits
> wrote:
>> Author: cbieneman
>> Date: Fri Jan 15 15:21:12 2016
>> New Revision: 257934
>>
>> URL: http://llvm.org/viewvc/llvm-project?r
hans added a subscriber: hans.
hans added a comment.
I tried to printf debug with this patch:
Index: lib/sanitizer_common/sanitizer_suppressions.cc
===
--- lib/sanitizer_common/sanitizer_suppressions.cc (revision 257931)
tra added a reviewer: jlebar.
tra updated this revision to Diff 45044.
tra added a comment.
Moved initializer checks from CodeGen to Sema.
Added test cases for initializers of non-class variables.
http://reviews.llvm.org/D15305
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang
congliu added a comment.
> - Ignore qualifiers.
I don't think we should ignore qualifiers. Please see my inline comment for
line 52 of the test file.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:240
@@ -247,2 +239,3 @@
unsigned EditDistance =
-Bas
tra marked an inline comment as done.
tra added a comment.
In http://reviews.llvm.org/D15305#327226, @rsmith wrote:
> I think you missed this from my previous review:
>
> > This should be checked and diagnosed in Sema, not in CodeGen.
>
Done.
http://reviews.llvm.org/D15305
Author: dblaikie
Date: Fri Jan 15 17:43:28 2016
New Revision: 257957
URL: http://llvm.org/viewvc/llvm-project?rev=257957&view=rev
Log:
OpaquePtr: Use nullptr construction for TemplateTy OpaquePtr typedef
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
Modified: cfe/trunk/lib/Parse/ParseDeclCX
Author: dblaikie
Date: Fri Jan 15 17:43:25 2016
New Revision: 257956
URL: http://llvm.org/viewvc/llvm-project?rev=257956&view=rev
Log:
OpaquePtr: Use nullptr construction for DeclGroupPtrTy OpaquePtr typedef
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
Author: dblaikie
Date: Fri Jan 15 17:43:21 2016
New Revision: 257955
URL: http://llvm.org/viewvc/llvm-project?rev=257955&view=rev
Log:
OpaquePtr: Provide conversion-from-nullptr_t to make default construction
simpler to read/write
Modified:
cfe/trunk/include/clang/Sema/Ownership.h
Modified:
Author: dblaikie
Date: Fri Jan 15 17:43:34 2016
New Revision: 257958
URL: http://llvm.org/viewvc/llvm-project?rev=257958&view=rev
Log:
OpaquePtr: Use nullptr construction for ParsedType OpaquePtr typedef
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Parse/ParseDecl.cpp
c
On Mon, Dec 21, 2015 at 2:35 AM, Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hi David,
>
>
>
> Thank you so much for the review.
>
> I copied and pasted the diff file. Let me know if it’s OK to commit.
>
>
>
>
>
> >> Could/should this ^ just be: Opts.DebugExplicitImport =
> Tri
rsmith added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:312
@@ +311,3 @@
+ // the checks have been done in Sema by now. Whatever initializers
+ // areallowed are empty and we just need to ignore them here.
+ if (getLangOpts().CUDA && getLangOpts().CUDAIsDevice &&
--
tra added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2334
@@ -2339,1 +2333,3 @@
+ D->hasAttr())
Init = llvm::UndefValue::get(getTypes().ConvertType(ASTTy));
+ else if (!InitExpr) {
rsmith wrote:
> As this is a global variable, it should
tra updated this revision to Diff 45051.
tra marked an inline comment as done.
tra added a comment.
Typo fix.
http://reviews.llvm.org/D15305
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CodeGenModule.cpp
lib/Sema/Sem
Author: akirtzidis
Date: Fri Jan 15 18:20:02 2016
New Revision: 257968
URL: http://llvm.org/viewvc/llvm-project?rev=257968&view=rev
Log:
[libclang] Introduce APIs for evaluating a cursor and checking if a macro is
builtin/function.
rdar://24091595
Added:
cfe/trunk/test/Index/evaluate-cursor
Author: pcc
Date: Fri Jan 15 18:31:22 2016
New Revision: 257971
URL: http://llvm.org/viewvc/llvm-project?rev=257971&view=rev
Log:
Introduce -fsanitize-stats flag.
This is part of a new statistics gathering feature for the sanitizers.
See clang/docs/SanitizerStats.rst for further info and docs.
D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257971: Introduce -fsanitize-stats flag. (authored by pcc).
Changed prior to commit:
http://reviews.llvm.org/D16175?vs=44945&id=45056#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16175
Files:
This change breaks darwin fat binary support.
> ./bin/clang++ ~/dev/scratch/hello_world.cpp -arch armv7 -arch armv7s
> -isysroot
> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/
fatal error:
/Applications/Xcode.app/Contents/Developer/Toolchai
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Just to reduce number of uncategorized checks, since Clang-tidy has dedicated
cat
+Eric,
If this patch can’t be quickly fixed, can it please be reverted?
-Chris
> On Jan 15, 2016, at 4:36 PM, Chris Bieneman via cfe-commits
> wrote:
>
> This change breaks darwin fat binary support.
>
> > ./bin/clang++ ~/dev/scratch/hello_world.cpp -arch armv7 -arch armv7s
> > -isysroot
>
On Fri, Jan 15, 2016 at 4:22 PM, Artem Belevich wrote:
> tra added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenModule.cpp:2334
> @@ -2339,1 +2333,3 @@
> + D->hasAttr())
> Init = llvm::UndefValue::get(getTypes().ConvertType(ASTTy));
> + else if (!InitExpr) {
>
On Fri, Jan 15, 2016 at 5:29 PM, Richard Smith wrote:
> On Fri, Jan 15, 2016 at 4:22 PM, Artem Belevich wrote:
>> tra added inline comments.
>>
>>
>> Comment at: lib/CodeGen/CodeGenModule.cpp:2334
>> @@ -2339,1 +2333,3 @@
>> + D->hasAttr())
>> Init = llvm::UndefValue::g
I'm afk at the moment please revert and add a test case if you can?
On Fri, Jan 15, 2016, 5:24 PM Chris Bieneman wrote:
> +Eric,
>
> If this patch can’t be quickly fixed, can it please be reverted?
>
> -Chris
>
> On Jan 15, 2016, at 4:36 PM, Chris Bieneman via cfe-commits <
> cfe-commits@lists.l
If you revert this you'll have to revert three other dependent
patches. I'm looking at a fix, if you're able to sit tight for
fifteen minutes or so.
If not, I can at least contribute a testcase; that much is done.
On Fri, Jan 15, 2016 at 5:33 PM, Eric Christopher wrote:
> I'm afk at the moment
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, beanz, echristo.
Herald added a subscriber: aemerson.
It's possible to BindArch without changing the toolchain at all. For
example, armv7 and armv7s have exactly the same triple.
Therefore the code
http://reviews.llvm.org/D16250
On Fri, Jan 15, 2016 at 5:35 PM, Justin Lebar wrote:
> If you revert this you'll have to revert three other dependent
> patches. I'm looking at a fix, if you're able to sit tight for
> fifteen minutes or so.
>
> If not, I can at least contribute a testcase; that mu
jlebar accepted this revision.
jlebar added a reviewer: jlebar.
jlebar added a comment.
This revision is now accepted and ready to land.
Pushed in r257808 with echristo's lg (sorry, didn't have the right metadata in
the commit).
http://reviews.llvm.org/D15960
echristo added a comment.
Ultimately they probably shouldn't map to the same toolchain and we can use
that as a key. Looks OK for now though.
http://reviews.llvm.org/D16250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Ultimately they probably shouldn't map to the same toolchain and we can use
that as a key. Looks OK for now though.
On Fri, Jan 15, 2016, 5:48 PM Justin Lebar wrote:
> jlebar created this revision.
> jlebar added a reviewer: tra.
> jlebar added subscribers: cfe-commits, beanz, echristo.
> Herald
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
Apologies for the massively delayed review. I think this is probably good,
but here are some test cases to discuss (& I've cc'd Paul Robinson and
Adrian Prantl, both who work on debug info in LLVM as well, to get their
thoughts)
Giv
Forward to the 'new' mailing list.
-- Forwarded message --
From: David Blaikie
Date: Fri, Jan 15, 2016 at 6:08 PM
Subject: Re: [PATCH] Proposed fix for PR23076 (conditional branch debug
line info)
To: reviews+d8822+public+818b95c17195c...@reviews.llvm.org, "Robinson,
Paul" , Adrian
alexfh added a comment.
Makes sense. One comment re: documentation.
Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1
@@ -1,2 +1,2 @@
-.. title:: clang-tidy - misc-inefficient-algorithm
+.. title:: clang-tidy - performance-inefficient-algorithm
---
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1
@@ -1,2 +1,2 @@
-.. title:: clang-tidy - misc-inefficient-algorithm
+.. title:: clang-tidy - performance-inefficient-algorithm
alexfh wrote:
> I'd le
LegalizeAdulthood added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994
@@ +4993,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef
alexfh added a comment.
Makes sense. One comment re: documentation.
Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1
@@ -1,2 +1,2 @@
-.. title:: clang-tidy - misc-inefficient-algorithm
+.. title:: clang-tidy - performance-inefficient-algorithm
---
Author: akirtzidis
Date: Fri Jan 15 21:01:20 2016
New Revision: 257982
URL: http://llvm.org/viewvc/llvm-project?rev=257982&view=rev
Log:
[libclang] Add missing CINDEX_LINKAGE from some new APIs in Index.h.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.
tra added a comment.
Looks OK to me.
Perhaps BoundArch w/o toolchain is sufficient for the key as toolchain would be
derived from it.
http://reviews.llvm.org/D16250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
jlebar added a comment.
In http://reviews.llvm.org/D16250#328552, @tra wrote:
> Looks OK to me.
> Perhaps BoundArch w/o toolchain is sufficient for the key as toolchain would
> be derived from it.
Yeah, it might work, I wasn't convinced it was sound. The bound TC is derived
from the origin
Author: jlebar
Date: Fri Jan 15 21:30:08 2016
New Revision: 257983
URL: http://llvm.org/viewvc/llvm-project?rev=257983&view=rev
Log:
Respect bound archs, even when they don't alter the toolchain.
Summary:
It's possible to BindArch without changing the toolchain at all. For
example, armv7 and arm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257983: Respect bound archs, even when they don't alter the
toolchain. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16250?vs=45061&id=45064#toc
Repository:
rL LLVM
http://
Author: chapuni
Date: Fri Jan 15 21:44:52 2016
New Revision: 257984
URL: http://llvm.org/viewvc/llvm-project?rev=257984&view=rev
Log:
[Cygwin] Use -femulated-tls by default since r257718 introduced the new pass.
FIXME: Add more targets to use emutls into clang/test/Driver/emulated-tls.cpp.
FIXME:
Author: jlebar
Date: Fri Jan 15 22:50:13 2016
New Revision: 257986
URL: http://llvm.org/viewvc/llvm-project?rev=257986&view=rev
Log:
Fix buildbot bustage in Driver/darwin-multiarch-arm.c caused by r257983.
The test was too loose; "ld" was matching directories named "build" in
the path.
Modified:
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
This check looks for `return` statements at the end of a function returning
`void`:
```
void f()
{
return;
}
```
becomes
```
void f()
{
}
```
http://revie
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/RedundantReturnCheck.cpp:46-49
@@ +45,6 @@
+ auto ReturnRange = CharSourceRange::getCharRange(
+ Start, Lexer::findLocationAfterToken(
+ Return->getLocEnd(), tok::semi, *R
1 - 100 of 101 matches
Mail list logo
