alexfh added a comment.

Makes sense. One comment re: documentation.


================
Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1
@@ -1,2 +1,2 @@
-.. title:: clang-tidy - misc-inefficient-algorithm
+.. title:: clang-tidy - performance-inefficient-algorithm
 
----------------
Eugene.Zelenko wrote:
> alexfh wrote:
> > I'd leave the old documentation file with a redirect to the new one. See 
> > examples in the cert module. But instead of calling the old check name 
> > 'alias', mention that it was renamed. We also don't need the old file to 
> > appear in the index, so it should be marked `:orphan:` and the 
> > add_new_check.py script should be updated to not add orphaned files to the 
> > list.
> I searched for orphan in documentation and didn't find any. Looks like 
> documentation was always renamed in past without leaving traces to old names.
> 
> I don't know documentation specific well enough, so will be good idea if it 
> will be changed by more knowledgeable person then me.
An example of a doc file redirecting to the new location is 
docs/clang-tidy.rst. Specifically, you need to put `:orphan:` as the first line 
and then add redirection directive.


Repository:
  rL LLVM

http://reviews.llvm.org/D16248



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to