zaks.anna added a comment.

> I see, so essentially you want to use a different approach for determining 
> sanitizer availability (on OS X for now): if the library is present, then we 
> support 

>  sanitizer, otherwise we don't: i.e. the binary distribution is the source of 
> truth, not the list of sanitizers hardcoded into Clang driver source code. 
> I'm fine with 

>  that, and see why it would make sense.


Correct.

> It's just that error message looks misleading: the problem is not TSan is 
> unsupported for target, it's just unavailable in this distribution for one 
> reason or 

>  another.


The main advantage of the error message Kuba has right now is that it is user 
friendly. A sanitizer IS unsupported for the given target in the given 
distribution if the library is missing. Saying something along the lines of 
"runtime components for '-fsanitize=thread' not available" is vague. For 
example, does it mean that the user needs to install the runtime components in 
some other way?


http://reviews.llvm.org/D15225



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to