xazax.hun marked an inline comment as done. xazax.hun added a comment. In http://reviews.llvm.org/D16179#326746, @alexfh wrote:
> > ... What about a configuration option to also report near misses when only > > a qualifier is missing? > > > Might be a useful thing. We should first check if it makes sense to always > ignore a qualifier. In this iteration of the patch I made the checker ignore the qualifiers. I did not get any results from running it on clang and llvm. ================ Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:126-127 @@ -127,4 +125,4 @@ for (unsigned I = 0; I < NumParamA; I++) { - if (BaseMD->getParamDecl(I)->getType() != - DerivedMD->getParamDecl(I)->getType()) + if (getDecayedType(BaseMD->getParamDecl(I)->getType()) != + getDecayedType(DerivedMD->getParamDecl(I)->getType())) return false; ---------------- This might not be representative, but I did not get any results on the LLVM codebase. http://reviews.llvm.org/D16179 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits