aaron.ballman added inline comments.

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:48
@@ +47,3 @@
+
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+                               HeaderFileExtensionsSet &HeaderFileExtensions) {
----------------
One thing we may want to reconsider for this function is using comma as a 
delimiter. We have another in-flight review which has to use semi-colons for a 
checker option list because commas are part of the syntax for a type 
description (think Foo<A, B>). It would be really nice to have one utility for 
parsing lists of information from checker options, and for that to use the same 
delimiter everywhere so that users aren't confused by using commas in some 
places and semi-colons in others.


http://reviews.llvm.org/D16113



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to