[clang] 1623c43 - [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (#121405)

2024-12-31 Thread via cfe-commits
Author: TilakChad Date: 2025-01-01T15:50:05+08:00 New Revision: 1623c435948ae305220e638066e968cb3296e567 URL: https://github.com/llvm/llvm-project/commit/1623c435948ae305220e638066e968cb3296e567 DIFF: https://github.com/llvm/llvm-project/commit/1623c435948ae305220e638066e968cb3296e567.diff LOG

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/121405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread M. Zeeshan Siddiqui via cfe-commits
@@ -2289,6 +2289,33 @@ bool Type::isFloatingType() const { return false; } +bool Type::isCXX23StandardFloatingPointType(const ASTContext &Ctx) const { + if (!Ctx.getLangOpts().CPlusPlus23) +return false; + if (const auto *BT = dyn_cast(CanonicalType)) +return BT->g

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/121404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/121404 >From 36efaa2849ee6276be5b3c0739f295d0921d1e6e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH 1/2] [clang-format] Support globstar in .clang-format-ignore Closes #1

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] [clang] Canonicalize absolute paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser edited https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] 2feffec - [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (#120352)

2024-12-31 Thread via cfe-commits
Author: Stephen Senran Zhang Date: 2024-12-31T18:40:17-08:00 New Revision: 2feffecb8853b1cdd38a0653df63d70412e65c12 URL: https://github.com/llvm/llvm-project/commit/2feffecb8853b1cdd38a0653df63d70412e65c12 DIFF: https://github.com/llvm/llvm-project/commit/2feffecb8853b1cdd38a0653df63d70412e65c1

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Stephen Senran Zhang via cfe-commits
zsrkmyn wrote: I'd appreciate much if you can help me commit it. https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: There is a typo in the subject. Absoultify => Absolutify. That said, sth like "canonicalize absolute paths " seem more appropriate wrt the changed semantics. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
dmasloff wrote: Resolved merge conflict https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 9848394edfa4bbae9f4f2df4b3dbcecefeb72624 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/8] fix merge conflict --- clang/docs/ClangFormatStyleOptions.rst

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #55474 --- Full diff: https://github.com/llvm/llvm-project/pull/121419.diff 8 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/include/clang/Basic/DiagnosticSemaK

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2024-12-31 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/121419 Fixes #55474 >From a9fdfac9f8655b8def5f99adde75bb5f2176057a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 1 Jan 2025 01:47:17 +0200 Subject: [PATCH] [Clang] emit -Wignored-qualifiers diagnostic for

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From a4997209062fe1e2b23dcbe88ed2cdcdf8c9a0db Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jason Rice (ricejasonf) Changes This is an implementation of P1061 Structure Bindings Introduce a Pack without the ability to use packs outside of templates. There is a couple of ways the AST could have been sliced so let me know

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jason Rice (ricejasonf) Changes This is an implementation of P1061 Structure Bindings Introduce a Pack without the ability to use packs outside of templates. There is a couple of ways the AST could have been sliced so let me know

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jason Rice (ricejasonf) Changes This is an implementation of P1061 Structure Bindings Introduce a Pack without the ability to use packs outside of templates. There is a couple of ways the AST could have been sliced so let me know what yo

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2024-12-31 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf created https://github.com/llvm/llvm-project/pull/121417 This is an implementation of P1061 Structure Bindings Introduce a Pack without the ability to use packs outside of templates. There is a couple of ways the AST could have been sliced so let me know what you

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-12-31 Thread Ameer J via cfe-commits
ameerj wrote: Closing in favor of #121404 https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-12-31 Thread Ameer J via cfe-commits
https://github.com/ameerj closed https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
@@ -1493,6 +1493,22 @@ static auto computeNewlines(const AnnotatedLine &Line, Newlines = 1; } + if (Style.WrapNamespaceBodyWithEmptyLines != FormatStyle::WNBWELS_Leave) { +// Modify empty lines after TT_NamespaceLBrace. +if (PreviousLine && PreviousLine->endsWit

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 219424f9cd3477d9290c8766eaa857234a1ae387 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/7] [clang-format] Add new option: WrapNamespaceBodyWithNewlines -

[clang] [clang] Fix implicit integer conversion for opaque enum declarations in class templates (PR #121039)

2024-12-31 Thread via cfe-commits
thebrandre wrote: I added regression tests for the scoped enumeration types to make sure that these are not affected. And I also tried to improve the commit message and added comments with references to the relevant sections in the C++ standard. But I still have to think about your refactoring/

[clang] [clang] Fix implicit integer conversion for opaque enum declarations in class templates (PR #121039)

2024-12-31 Thread via cfe-commits
https://github.com/thebrandre updated https://github.com/llvm/llvm-project/pull/121039 >From 551290d313063d1e05bc665aa44e9dac1f9ff29d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Brand?= Date: Tue, 31 Dec 2024 19:54:51 +0100 Subject: [PATCH] [clang] Fix implicit integer conversion of o

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
@@ -47,4 +47,4 @@ // RUN: %clang_cc1 -D REINCLUDE -I %t -ivfsoverlay %t.yaml -Eonly %s -MTfoo -dependency-file %t.dep // RUN: cat %t.dep | FileCheck --check-prefix=CHECK-DEP %s -// CHECK-DEP-NOT: Inputs +// CHECK-DEP: Inputs MaskRay wrote: `Inputs{{..?}}exte

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
@@ -312,11 +315,22 @@ void DependencyFileGenerator::finishedMainFile(DiagnosticsEngine &Diags) { /// https://msdn.microsoft.com/en-us/library/dd9y37ha.aspx for NMake info, /// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx /// for Windows file

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Jessica Clarke via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
topperc wrote: Missing tests in test/MC/RISCV for the assembler and disassembler https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -1395,6 +1395,19 @@ def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion() def TuneMIPSP8700 : SubtargetFeature<"mips-p8700", "RISCVProcFamily", "MIPSP8700", "MIPS p8700 processor">; +def FeatureVendorMIPSCMove : Subtarge

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -0,0 +1,370 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -389,6 +390,13 @@ class RISCVPassConfig : public TargetPassConfig { DAG->addMutation(createStoreClusterDAGMutation( DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true)); } + +const RISCVSubtarget &ST = C->MF->getSubtarget(); +if (!ST.getMacroFusi

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -62,6 +62,15 @@ static cl::opt RISCVMinimumJumpTableEntries( "riscv-min-jump-table-entries", cl::Hidden, cl::desc("Set minimum number of entries to use a jump table on RISCV")); +static cl::opt +UseLoadStorePairsOpt("riscv-load-store-pairs", top

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -257,6 +257,146 @@ def simm12 : RISCVSImmLeafOp<12> { }]; } +// A 7-bit unsigned immediate where the least significant two bits are zero. topperc wrote: Why do these need to move? RISCVInstrInfoXMips.td is included after RISCVInstrInfoC.td https://gith

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -514,6 +514,78 @@ class RVInstJ +: RVInst { + bits<7> imm7; + bits<5> rs1; + bits<5> rd1; + bits<5> rd2; + + let Inst{31-27} = rd2; + let Inst{26-23} = imm7{6-3}; + let Inst{22-20} = 0b000; + let Inst{19-15} = rs1; + let Inst{14-12} = 0b100; + let Inst{11-7} = rd1

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Craig Topper via cfe-commits
topperc wrote: This still isn't broken down enough. We usually like to see assembler support in separate patches from code generation. https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang-tools-extra] [clang-tidy][NFC] optimize cache for config option (PR #121406)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Current implement will cache `OptionsSource` for each path, it will create lots of copy of `OptionsSource` when project has deep nested folder structure. New implement use vector to store `Opt

[clang-tools-extra] [clang-tidy][NFC] optimize cache for config option (PR #121406)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Current implement will cache `OptionsSource` for each path, it will create lots of copy of `OptionsSource` when project has deep nested folder structure. New implement use vector to store `OptionsSou

[clang-tools-extra] [clang-tidy][NFC] optimize cache for config option (PR #121406)

2024-12-31 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/121406 Current implement will cache `OptionsSource` for each path, it will create lots of copy of `OptionsSource` when project has deep nested folder structure. New implement use vector to store `OptionsSource` and

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/121404 >From 36efaa2849ee6276be5b3c0739f295d0921d1e6e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH] [clang-format] Support globstar in .clang-format-ignore Closes #11496

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro updated https://github.com/llvm/llvm-project/pull/121394 >From 29d22560f2987e81ea66e4c7dea42f594bda709f Mon Sep 17 00:00:00 2001 From: Djordje Todorovic Date: Thu, 26 Dec 2024 09:09:24 +0100 Subject: [PATCH] [RISCV] Add MIPS extensions Adding two extensions for MIPS

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/121404 >From 13c13f02e55c39db1376c8e8cfb1d1ab90287502 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH] [clang-format] Support globstar in .clang-format-ignore Closes #11496

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-12-31 Thread Owen Pan via cfe-commits
owenca wrote: See #121404. https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/121404 >From a1060e903d29340840cdd0a9cecf74269fc7c563 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH] [clang-format] Support globstar in .clang-format-ignore Closes #11496

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
TilakChad wrote: Alternatively, we could've make the PackIndexingExpr to be type dependent and try to verify type compatibility lazily during instantiation. It is how MSVC and GCC seems to behave. Considering that the clang seems to be eager about such type compatibility, this changes is alo

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: TilakChad (TilakChad) Changes For use of non-dependent type inside template, clang verifies eagerly that the type of variable being declared matches to that type. With this PR, we assign the type of the PackIndexingExpr to the type of the

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
https://github.com/TilakChad created https://github.com/llvm/llvm-project/pull/121405 For use of non-dependent type inside template, clang verifies eagerly that the type of variable being declared matches to that type. With this PR, we assign the type of the PackIndexingExpr to the type of the

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Owen Pan (owenca) Changes Closes #114969. --- Full diff: https://github.com/llvm/llvm-project/pull/121404.diff 4 Files Affected: - (modified) clang/docs/ClangFormat.rst (+4) - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) c

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Closes #114969. --- Full diff: https://github.com/llvm/llvm-project/pull/121404.diff 4 Files Affected: - (modified) clang/docs/ClangFormat.rst (+4) - (modified) clang/docs/ReleaseNotes.rst (+1) - (modi

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/121404 Closes #114969. >From 8b7802141853f77f3f074e6f41f416dfd25d90e4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH] [clang-format] Support globstar in .clang-format-igno

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-31 Thread via cfe-commits
amane-ame wrote: cc @efriedma-quic @tbaederr. Could anyone please review this? https://github.com/llvm/llvm-project/pull/119563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor reopened https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
vbvictor wrote: > I think that this check is one that we don't want to emit fixes for, at least > not in the main diagnostic, but maybe as a fixit attached to a note > What do others think? https://github.com/llvm/llvm-project/pull/121291 ___ cfe-c

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + +// MIPS extensions +//===--===// + +let Pre

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro updated https://github.com/llvm/llvm-project/pull/121394 >From f833498eb48595cc6b2bd5dd0c1b05d941313877 Mon Sep 17 00:00:00 2001 From: Djordje Todorovic Date: Thu, 26 Dec 2024 09:09:24 +0100 Subject: [PATCH] [RISCV] Add MIPS extensions Adding two extensions for MIPS

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -426,6 +426,12 @@ The current vendor extensions supported are: ``Xwchc`` LLVM implements `the custom compressed opcodes present in some QingKe cores` by WCH / Nanjing Qinheng Microelectronics. The vendor refers to these opcodes by the name "XW". +``xmipscmove``

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -367,6 +372,16 @@ class RISCVPassConfig : public TargetPassConfig { DAG->addMutation(createStoreClusterDAGMutation( DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true)); } + +const RISCVSubtarget &ST = C->MF->getSubtarget(); +if (!ST.getMacroFusi

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -62,6 +62,20 @@ static cl::opt RISCVMinimumJumpTableEntries( "riscv-min-jump-table-entries", cl::Hidden, cl::desc("Set minimum number of entries to use a jump table on RISCV")); +static cl::opt djtodoro wrote: Well, I do not think so. https://gith

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -1447,6 +1447,23 @@ def TuneConditionalCompressedMoveFusion def HasConditionalMoveFusion : Predicate<"Subtarget->hasConditionalMoveFusion()">; def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion()">; +def TuneMIPSP8700 +: SubtargetFeature<"m

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2710,6 +2713,45 @@ MachineInstr *RISCVInstrInfo::emitLdStWithAddr(MachineInstr &MemI, .setMemRefs(MemI.memoperands()) .setMIFlags(MemI.getFlags()); } +bool RISCVInstrInfo::isPairableLdStInstOpc(unsigned Opc) { + switch (Opc) { + default: +return false; +

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -1447,6 +1447,23 @@ def TuneConditionalCompressedMoveFusion def HasConditionalMoveFusion : Predicate<"Subtarget->hasConditionalMoveFusion()">; def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion()">; +def TuneMIPSP8700 +: SubtargetFeature<"m

[clang] 6279d2e - AArch64ABIInfo::passAsAggregateType - don't directly dereference getAs<> result. NFC.

2024-12-31 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-12-31T14:34:14Z New Revision: 6279d2e0f33ed1aa686aace48da6ccf912ab4b28 URL: https://github.com/llvm/llvm-project/commit/6279d2e0f33ed1aa686aace48da6ccf912ab4b28 DIFF: https://github.com/llvm/llvm-project/commit/6279d2e0f33ed1aa686aace48da6ccf912ab4b28.diff LOG:

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + +// MIPS extensions +//===--===// + +let Pre

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + djtodoro wrote: Addressed in https://github.com/llvm/llvm-project/pull/121394 https://github.

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -514,6 +514,78 @@ class RVInstJhttps://github.com/llvm/llvm-project/pull/121394 https://github.com/llvm/llvm-project/pull/117865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -298,6 +298,15 @@ class RISCVInstrInfo : public RISCVGenInstrInfo { unsigned getTailDuplicateSize(CodeGenOptLevel OptLevel) const override; + /// Return true if pairing the given load or store may be paired with another. + static bool isPairableLdStInstOpc(unsigned Op

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1d5154663509b6200038a2f0b0ac958ea556fa9e a2e1fd5ffab4fe64a160571a9dffaacc3f22c32d --e

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96 K

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96 KiB, tru

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro created https://github.com/llvm/llvm-project/pull/121394 Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 >From a2e1fd5ffab4fe64a160571a9dffaa

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 057dfa5d362257632a88b65e537df0b4fe806fe8 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2024-12-31 Thread via cfe-commits
https://github.com/aalhwc edited https://github.com/llvm/llvm-project/pull/121332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2024-12-31 Thread via cfe-commits
@@ -4782,6 +4782,30 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Function *F = CGM.getIntrinsic(Intrinsic::frameaddress, AllocaInt8PtrTy); return RValue::get(Builder.CreateCall(F, Depth)); } + case Builtin::BI__builtin_stack_ad

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 79d2ed6ece54a9c1c7acd785156b5ffe10eb2ec7 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From ac31b0da02dac47e4099788d75f60970919c854f Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -1032,6 +1033,21 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, isFloat = true; continue; // Success. +// C++23 5.13.4 [lex.fcon] +case 'b': +case 'B': + if (!isFPConstant) +break; // Error for integer constant. +

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -7444,9 +7444,11 @@ isArithmeticArgumentPromotion(Sema &S, const ImplicitCastExpr *ICE) { From = VecTy->getElementType(); if (const auto *VecTy = To->getAs()) To = VecTy->getElementType(); - // It's a floating promotion if the source type is a lower rank. - retu

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -453,8 +453,12 @@ static void InitializeStandardPredefinedMacros(const TargetInfo &TI, if (LangOpts.CPlusPlus26) // FIXME: Use correct value for C++26. Builder.defineMacro("__cplusplus", "202400L"); -else if (LangOpts.CPlusPlus23) +else if (LangOpts.

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -4446,6 +4455,73 @@ CompareStandardConversionSequences(Sema &S, SourceLocation Loc, ? ImplicitConversionSequence::Better : ImplicitConversionSequence::Worse; + // C++23 12.2.4.3p4: cor3ntin wrote: Can you add the stable labe

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks for working on this. I made a few comments (my review is a bit shallow as floating point isn't really my area of expertise...) Can you add - Tests to check template arguments deduction works properly - Tests that check the behavior on platforms t

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -2289,6 +2289,33 @@ bool Type::isFloatingType() const { return false; } +bool Type::isCXX23StandardFloatingPointType(const ASTContext &Ctx) const { + if (!Ctx.getLangOpts().CPlusPlus23) +return false; + if (const auto *BT = dyn_cast(CanonicalType)) +return BT->g

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 2aaa66fe42e10b968cfe259bfca721645d97b49c Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

[clang] [clang][bytecode] Check memove/memcpy for available elements (PR #121383)

2024-12-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/10997 Here is the relevant piec

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 9677fc64da8fa1bea56e6cee337f9fa90f6b7101 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

  1   2   >