https://github.com/cor3ntin commented:

Thanks for working on this.
I made a few comments (my review is a bit shallow as floating point isn't 
really my area of expertise...)

Can you add 
 - Tests to check template arguments deduction works properly
 - Tests that check the behavior on platforms that do not support these types

https://github.com/llvm/llvm-project/pull/78503
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to