[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

brad created this revision. brad added reviewers: dim, emaste. brad added a project: clang. Herald added subscribers: krytarowski, arichardson. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. With the last diff as I was simplifying some bits

[PATCH] D144772: [Sema] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType to prevent crashing on RISC-V.

craig.topper created this revision. craig.topper added reviewers: reames, asb, kito-cheng, eopXD, c-rhodes, frasercrmck, rogfer01. Herald added subscribers: luke, VincentWu, ctetreau, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edwa

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

galapoz1996 added a comment. Herald added subscribers: steakhal, MaskRay. Herald added a reviewer: NoQ. Herald added a project: All. I used to think that therapy was only for people with "real" problems, but I couldn't have been more wrong. Seeking help for my anxiety and depression has been one

[PATCH] D140992: clang: Add __builtin_elementwise_fma

arsenm closed this revision. arsenm added a comment. 8709bcacfb3a06847b47bb6b47e8556db43f3a43 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 __

[clang] 8709bca - clang: Add __builtin_elementwise_fma

Author: Matt Arsenault Date: 2023-02-24T21:55:08-04:00 New Revision: 8709bcacfb3a06847b47bb6b47e8556db43f3a43 URL: https://github.com/llvm/llvm-project/commit/8709bcacfb3a06847b47bb6b47e8556db43f3a43 DIFF: https://github.com/llvm/llvm-project/commit/8709bcacfb3a06847b47bb6b47e8556db43f3a43.diff

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added inline comments. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} thetruestblue wrote: > Can you explain the motivation here? > > RTAsan_static object

[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

galapoz1996 added a comment. Herald added a subscriber: mgehre. Herald added a project: All. Indeed, I recognize that completely. I had a small business nearby as well, and within a year, several of my neighbors started doing the same. Hence, our town has grown considerably. Nevertheless, since

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:88 +/// so cannot be dependent. +UncommonValue, + erichkeane wrote: > I definitely hate the name here... Just `Value` makes a bit more sense, but > isn't perfectly accurate.

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CodeGenCXX/template-arguments.cpp:4 + +template CONSTEXPR T id(T v) { return v; } +template auto value = id(V); I don't see any tests covering unions or enums. Comment at: clang/test/SemaTemp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1.cpp:204 +#if __cplusplus == 201703L + // cxx17-error@-3 {{non-type template argument refers to subobject '(int *)1'}} +#endif Shouldn't this be an error b/c it is a tempo

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a comment. > Highlight by me. That is not acceptable, running the output of `clang-format` > through `clang-format` shall not result in any change. In that case it's > better to not touch it in any way. That is no longer an issue in the latest patch. Repository: rG

[PATCH] D140925: [CMake] Use Clang to infer the target triple

MaskRay added a comment. In D140925#4151524 , @smeenai wrote: > Ping @ldionne, would you be able to take a look at this soon (or are you okay > waiving the libc++ blocking requirement for it)? This is really useful for > Android armv7, where the triple

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. > As long as you don't need the library (which, if you have a preprocessed file > or a test, should absolutely not be necessary), you can just do the -cc1 > option of -triple , or the non- -cc1 option of -target . > > Both use basically the same options list, and that

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 500299. isuckatcs added a comment. Fixed the timed out test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tid

[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai added a comment. Ping @ldionne, would you be able to take a look at this soon (or are you okay waiving the libc++ blocking requirement for it)? This is really useful for Android armv7, where the triple is traditionally spelled armv7-none-linux-androideabi but normalized to arvm7-none-li

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { doru1004 wrote: > jhuber6 wrote: > > doru1004 wrote:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 500298. qiongsiwu1 added a comment. > This accepts -mno-roptr for other platforms despite having no semantic > functionality (e.g., it does not move variables to a different section for > ELF codegen). Thanks for catching this @hubert.reinterpretcast !!

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { jhuber6 wrote: > doru1004 wrote: > > jhuber6 wrote:

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { doru1004 wrote: > jhuber6 wrote: > > Why does this ha

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { jhuber6 wrote: > Why does this handling need to be d

[PATCH] D144709: [clang-format] Improve west to east const

HazardyKnusperkeks added a comment. In D144709#4149737 , @AlexanderHederstaf wrote: > I tried to refactor QualifierAlignmentFixer to handle more types, notably > removing the *,&,&& requirement as e.g. const Foo did not work. To avoid > moving qualifie

[clang] 44b391f - LanguageExtensions.rst: fix a typo in the `#pragma clang deprecated` example

Author: Fangrui Song Date: 2023-02-24T12:41:49-08:00 New Revision: 44b391fc473c3ea8ce5d6cefeac6c781060b398f URL: https://github.com/llvm/llvm-project/commit/44b391fc473c3ea8ce5d6cefeac6c781060b398f DIFF: https://github.com/llvm/llvm-project/commit/44b391fc473c3ea8ce5d6cefeac6c781060b398f.diff

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 500274. PiotrZSL added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModu

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan abandoned this revision. leonardchan added a comment. This was landed in https://reviews.llvm.org/rG4308166403b4c28b6db7094a4e202e42da6e28a8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589 __

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5251 + if (Args.hasFlag(options::OPT_mroptr, options::OPT_mno_roptr, false)

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169 +should be provided. If an exception type name in the list is caught in an +empty catch statement, no warning will be raised. Default value: `` (empty

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169 +should be provided. If an exception type name in the list is caught in an +empty catch statement, no warning will be raised. Default value: `` (empty). ---

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

thetruestblue added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} Can you explain the motivation here? RTAsan_static o

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:77 +void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) { + + auto AllowedNamedExceptionDecl = Excessive newline. Comment at:

[PATCH] D143560: clang-format.el: fix warnings

HazardyKnusperkeks added a comment. In D143560#4149733 , @phst wrote: > I'm not super familiar with the process either, but IIRC @sammccall or > @djasper have to merge this. Anyone with commit access can do that. In D143560#4147918

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

erichkeane added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; aganea wrote: > erichkeane wrote: > > This patch seems to caus

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

erichkeane added a comment. In D135495#4151238 , @isuckatcs wrote: > I'm not sure if I can run clang targetting AArch64 on an X86 machine but I > tried it regardless and I get compiler errors on startup, so I can't debug > this issue at the moment. > B

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

aganea added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; erichkeane wrote: > This patch seems to cause a self-build Werror

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. I'm not sure if I can run clang targetting AArch64 on an X86 machine but I tried it regardless and I get compiler errors on startup, so I can't debug this issue at the moment. Besided that I don't know why it times out on that buildbot. The build job that is performe

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500264. mysterymath marked an inline comment as done. mysterymath added a comment. Update condition; move release note to AVR section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://revie

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43-45 +- The definition of ``USHRT_MAX`` in the freestanding no longer + overflows on AVR (where ``sizeof(unsigned int) == sizeof(unsigned short)``). + The type of ``USHRT_MAX`` on AVR is now ``unsi

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

erichkeane added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; This patch seems to cause a self-build Werror regression. The

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a subscriber: reames. leonardchan added a comment. @reames let's continue the discussion here. What specific bits with the optimizer does this break? I'm not too familiar with SVEC. Prior to this, one thing I tried was instead just doing `Ops.push_back(GA)` and `getSCEV(GA)` bu

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6a8d52d645: [clang-tidy] improve readability-identifier-naming hungarian options test (authored by amurzeau, committed by PiotrZSL). Repository:

[clang-tools-extra] 3f6a8d5 - [clang-tidy] improve readability-identifier-naming hungarian options test

Author: Alexis Murzeau Date: 2023-02-24T19:17:56Z New Revision: 3f6a8d52d64553239aade3a425a5f56ebe88bc9e URL: https://github.com/llvm/llvm-project/commit/3f6a8d52d64553239aade3a425a5f56ebe88bc9e DIFF: https://github.com/llvm/llvm-project/commit/3f6a8d52d64553239aade3a425a5f56ebe88bc9e.diff LOG

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG898c673e0835: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144196/new/

[clang] 898c673 - [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

Author: Aaron Ballman Date: 2023-02-24T13:52:41-05:00 New Revision: 898c673e0835a2df395dd2476ac8ee8972d6380b URL: https://github.com/llvm/llvm-project/commit/898c673e0835a2df395dd2476ac8ee8972d6380b DIFF: https://github.com/llvm/llvm-project/commit/898c673e0835a2df395dd2476ac8ee8972d6380b.diff

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau updated this revision to Diff 500256. amurzeau added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144510/new/ https://reviews.llvm.org/D144510 Files: clang-tools-extra/test/clang-tidy/checkers/readability/Inp

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

tahonermann added a comment. The changes made (from what I've seen, I haven't reviewed every line) make sense to me. The amount of change does make me a bit nervous though. In D143142#4142212 , @aaron.ballman wrote: > In terms of whether to use `unsign

[PATCH] D132398: Allow constant static members to be used with 'this'

aaron.ballman added a comment. In D132398#4150851 , @cor3ntin wrote: > Given this has not made progress in a while, I think we should try to > implement > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead > of this approach,

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4150848 , @bolshakov-a wrote: >> Should this also update the status in clang/www/cxx_status.html? > > I'm not sure. There still remains an issue with template parameters of > reference type, which was tried to b

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe419e22ff6fd: [CodeGen] Stop storing alignment information into pointers in Address (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[clang] e419e22 - [CodeGen] Stop storing alignment information into pointers in Address

Author: Akira Hatanaka Date: 2023-02-24T10:33:10-08:00 New Revision: e419e22ff6fdff97191d132555ded7811c3f5b05 URL: https://github.com/llvm/llvm-project/commit/e419e22ff6fdff97191d132555ded7811c3f5b05 DIFF: https://github.com/llvm/llvm-project/commit/e419e22ff6fdff97191d132555ded7811c3f5b05.diff

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { Why does this handling need to be different between C

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects and suggests ad

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/test/OpenMP/amdgpu_target_with_aligned_attribute.c:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex "__omp_offloading_

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. Seems like the `EmbedBitcodePass` comes straight from D130777 . It may make more sense to drop that part of the patch here, and rebase on top of it. On the downside, from what I can see this patch and D130777

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address (authored by aeubanks). Repository: rG LLVM Github Monor

[clang] dc07867 - [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

Author: Arthur Eubanks Date: 2023-02-24T09:28:10-08:00 New Revision: dc07867dc9991c982bd3441da19d6fcc16ea54d6 URL: https://github.com/llvm/llvm-project/commit/dc07867dc9991c982bd3441da19d6fcc16ea54d6 DIFF: https://github.com/llvm/llvm-project/commit/dc07867dc9991c982bd3441da19d6fcc16ea54d6.diff

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should add a release note as well. Comment at: clang/lib/Sema/SemaExprMember.cpp:164-167 if (CXXMethodDecl *MD = dyn_cast(DC)) contextC

[PATCH] D132398: Allow constant static members to be used with 'this'

cor3ntin added a comment. Herald added a subscriber: ChuanqiXu. Given this has not made progress in a while, I think we should try to implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead of this approach, as I'm not sure if that's strictly conforming, and a mor

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a subscriber: mizvekov. bolshakov-a added a comment. Thanks for the review! I definitely can try to answer questions and fix issues, but I just want to note that I'm not the original author, and these changes already were upstream. (Maybe, @rsmith will find some time for taking

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Sorry it took me a while to reply to you. I think you convinced me this is fine as-is! Thanks Comment at: clang/lib/Headers/stdatomic.h:50 + in C2x mode; switch to the

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL updated this revision to Diff 500232. PiotrZSL added a comment. Rebase + Used existing matcher instead of creating new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144217/new/ https://reviews.llvm.org/D144217 Files: clang-tools-ext

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

cor3ntin added a comment. @aaron.ballman I think we should close this change as it's superseeded by https://reviews.llvm.org/D144218 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 ___ cfe-commits m

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. If it helps, the bot I linked is pretty vanilla. You can find all the details in the buildbot UI but just in case: cmake -G Ninja ../llvm/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=True '-DLLVM_LIT_ARGS='"'"'-v'"'"'' -DCMAKE_INSTALL_PREFIX=../stag

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. The test was timing out on Arm/AArch64 bots so I have reverted this change. I think because there were other test failures on the initial run, that obscured the time out. This is one of the first builds to include this change: https://lab.llvm.org/buildbot/#/build

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

erichkeane added a comment. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a few stages. 1) Add the > new general functionality, 2) Replacing the existing implementation of > keyword attributes with th

[clang-tools-extra] 8ae5e9e - Revert "[clang-tidy] handle exceptions properly in `ExceptionAnalyzer`"

Author: David Spickett Date: 2023-02-24T16:37:14Z New Revision: 8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 URL: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 DIFF: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826.diff LOG

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a comment. One thing that might also help is to split this into a few stages. 1) Add the new general functionality, 2) Replacing the existing implementation of keyword attributes with the new functionality where possible, 3) Add new attributes using the new functionality. It

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500225. AlexanderHederstaf added a comment. Add test with advanced type that would not work before. Add pointer to member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.ll

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +}

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak updated this revision to Diff 500222. ahatanak added a comment. Remove AddressImpl altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144686/new/ https://reviews.llvm.org/D144686 Files: clang/lib/CodeGen/Address.h Index: clang/l

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4150724 , @vedgy wrote: > In D143418#4150360 , @aaron.ballman > wrote: > >> So my intuition is that the current behavior works well enough and I doubt >> anyone's going

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. I wanted to share this to get some initial thoughts as we'd discussed debuggability a while ago. As mentioned I'd at least want to get a reasonable HTML report before moving forward with it though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +} ---

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. In D143803#4150624 , @0xdc03 wrote: > In D143803#4150423 , @aaron.ballman > wrote: > >> Btw, these changes should come with a release note as well. > > Are all functional changes lo

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4150360 , @aaron.ballman wrote: > So my intuition is that the current behavior works well enough and I doubt > anyone's going to propose changes to it in the future. So adding the `GlobalOptions` member to `CXIndexOpti

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Roping in Erich as the attributes code owner. In general, I think this is going in roughly the right direction. One concern I have is that the distinction between a keyword spelling for an attribute is now a bit harder. W

[PATCH] D143704: [Flang] Part one of Feature List action

jdoerfert added a comment. can we have a test? Comment at: flang/examples/FeatureList/FeatureList.cpp:605 + template bool Pre(const std::variant &) { return true; } + template void Post(const std::variant &) {} +}; Can you record the features we missed so

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500215. AlexanderHederstaf added a comment. Fixed the const/volatile placement. Added a few tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files:

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. I will try to come up with a better diagnostic for this issue and will try and update the patch as soon as I can. In D143803#4150423 , @aaron.ballman wrote: > Btw, these changes should come with a release note as well. Are all

[clang] 0140283 - [clang-format] Add simple macro replacements in formatting.

Author: Manuel Klimek Date: 2023-02-24T15:44:24Z New Revision: 01402831aaae76e9c61595f9aa81a506b0d926eb URL: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb DIFF: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb.diff LOG:

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01402831aaae: [clang-format] Add simple macro replacements in formatting. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:456 - class ArrayOrMatrixSubscriptExprBitfields { + class AMTSubscriptExprBitfields { friend class ArraySubscriptExpr; I am not ce

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added a comment. Generally LGTM with a few comments sprinkled around. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} pmatos wrote:

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4592 + !Macros.hasArity(ID->TokenText, Args->size())) { +// The macro is overloaded to be both object-like and function-like, +// but none of the function-like arities matc

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500191. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. Still LG Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || klimek wrote: > sammccall wrote: > > this assert

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman edited reviewers, added: erichkeane, royjacobson, clang-language-wg; removed: mizvekov. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D140996#4125177 , @bolshakov-a wrote: > @aaron.ballman, @rsmith, @mizveko

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added a comment. >> which confuses me because an extern "C" block is not supposed to mangle any >> names, right? Appreciate any inputs on this. That IS strange, that has internal linkage, but so the 'extern "C"' doesn't do anything to it, so we choose to just mangle it. I guess ther

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. Btw, these changes should come with a release note as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 ___ cfe-commits maili

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as he's more familiar with ifunc and friends. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:345 + const llvm::GlobalValue *&GV, +

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || sammccall wrote: > this assertion failure isn't going to

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500181. klimek marked 5 inline comments as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/includ

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

erichkeane added a comment. That looks reasonable to me, though I fear all the libcxx failures are going to be related to this, please make sure to check them out! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 __

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4148003 , @vedgy wrote: > In D143418#4147578 , @aaron.ballman > wrote: > >> In D143418#4131156 , @vedgy wrote: >> >>> On second

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500172. sammccall added a comment. Fix colors, log source Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/Fl

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. Example textual log (though better with colors): === Beginning data flow analysis === int target(int x) { while (x > 0) { --x; } return x + 1; } FunctionDecl 0x2a9a300 line:1:5 target 'int (int)' |-ParmVarDecl

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500166. sammccall added a comment. A little more docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/FlowSe

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a comment. In D143524#4150289 , @v.g.vassilev wrote: > In D143524#4150286 , @aaron.ballman > wrote: > >> In D143524#4148024 , @v.g.vassilev >> wrote

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall created this revision. Herald added a subscriber: wenlei. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a draft and a starting point, and needs mo

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. In D144115#4148026 , @Endill wrote: > Despite having a dozen of `#pragma __debug` directives, none of them are > tested neither mentioned in any kind of documentation, including release > notes. Are you sure about this? If

  1   2   >