doru1004 added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274
+ if (!IsByRef) {
+ if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) ||
+ (Ctx.getTargetInfo().getTriple().isNVPTX())) {
----------------
jhuber6 wrote:
> Why does this handling need to be different between CPU and GPU offloading?
> Strictly speaking, I'm not sure why we need the alignment type here since
> we'd only get improper alignment on primitive types. So I figured that it
> should only care about the alignment of the type itself in all cases. Maybe
> someone can correct me on that.
Are you saying that the previous check was not correct?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144569/new/
https://reviews.llvm.org/D144569
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
