erichkeane added inline comments.
================ Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE0000000 | EX_IOERR)) + return; ---------------- aganea wrote: > erichkeane wrote: > > This patch seems to cause a self-build Werror regression. The mask here is > > large enough to cause the RHS of this to be unsigned, so the comparison > > hits `-Wsign-compare`. See the example here https://godbolt.org/z/fa5q889jh > Please see rG1d0a5f11c04e6ac4dab578b81d02eabb83b31428 Wonderful, thanks! Looks like our build system didn't get to that yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142224/new/ https://reviews.llvm.org/D142224 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
