[PATCH] D61174: [clang-format] Fix documentation for FixNamespaceComments

owenpan created this revision. owenpan added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR40409 . Repository: rC Clang https://reviews.llvm.org/D61174 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Forma

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

a_sidorin accepted this revision. a_sidorin added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D59725: Additions to creduce script

lebedev.ri added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + akhuang wrote: > lebedev.ri wrote: > > akhuang wrote: > > > lebedev.ri

[PATCH] D61173: [BPF] do not generate predefined macro bpf

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. shipit Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/

[PATCH] D61173: [BPF] do not generate predefined macro bpf

yonghong-song updated this revision to Diff 196799. yonghong-song edited the summary of this revision. yonghong-song added a comment. remove __bpf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/ https://reviews.llvm.org/D61173 Files: lib/Basic/Target

[PATCH] D61173: [BPF] do not generate predefined macro bpf

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder &Builder) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); + Builder.defin

[PATCH] D61173: [BPF] do not generate predefined macro bpf

ast added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder &Builder) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); + Builder.defineMacro("__bpf__"); I don't think anyone i

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. In D61147#1479940 , @erik.pilkington wrote: > In D61147#1479932 , @rjmccall wrote: > > > I do not think the ObjC version of this diagnostic is useful as it's been > > explained here, and

[PATCH] D61173: [BPF] do not generate predefined macro bpf

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added a project: clang. Herald added a subscriber: cfe-commits. "DefineStd(Builder, "bpf", Opts)" generates the following three macros: bpf __bpf __bpf__ and the macro "bpf" is due to the fact that the target

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. In D61147#1479932 , @rjmccall wrote: > I do not think the ObjC version of this diagnostic is useful as it's been > explained here, and I would strongly recommend just not including such a > warning for the time being. W

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1474715 , @jdenny wrote: > Does the following match what you have in mind? > > $prefix/ > include/ > c++/ > v1/ > limits.h > ... > openmp/ > v1/ <-- I don't think o

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. Are you sure these are the right semantics for `nodestroy`? I think there's a reasonable argument that we should not destroy previous elements of a `nodestroy` array just because an element constructor throws. It's basically academic for true globals because the exce

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

pnappa updated this revision to Diff 196795. pnappa added a comment. Apologies for taking a while, I'm afraid I hadn't had a moment of spare time over the past few weeks. I believe I've applied the requested changes, bar one that I'm unsure about: @alexfh to be sure, would adding an Option to

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. I do not think the ObjC version of this diagnostic is useful as it's been explained here, and I would strongly recommend just not including such a warning for the time being. I would also recommend that you go fix the warning to never fire on virtual C++ methods. Re

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge edited reviewers, added: ilya-biryukov; removed: hokein. nridge added a comment. Changing reviewers as I understand @hokein is on vacation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 _

[PATCH] D59407: [clangd] Add RelationSlab

nridge planned changes to this revision. nridge added a comment. In D59407#1478794 , @sammccall wrote: > So if you can stomach it, I think > > > **Approach 2: Add a RelationSlab storing (subject, predicate, object) > > triples, intended for sparse relatio

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

ruiu added a comment. I don't have any particular comment, and I'll give an LGTM soon as people seem to generally happy about this. If you are not happy about this patch or the feature itself, please shout. This feature is about to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington abandoned this revision. erik.pilkington added a comment. Herald added a subscriber: jkorous. Looks like @rsmith fixed this in r359266. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52521/new/ https://reviews.llvm.org/D52521 ___

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

ahatanak added a comment. Yes, I guess we can make `-Wunused-parameter ` cover unused parameters of pure @implementation methods too since users can probably just remove them to silence the warning. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek updated this revision to Diff 196791. phosek marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61040/new/ https://reviews.llvm.org/D61040 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonA

r359266 - PR41607: Don't forget to substitute outer template arguments into a

Author: rsmith Date: Thu Apr 25 19:11:23 2019 New Revision: 359266 URL: http://llvm.org/viewvc/llvm-project?rev=359266&view=rev Log: PR41607: Don't forget to substitute outer template arguments into a class-scope explicit specialization of a class template. Modified: cfe/trunk/include/clang/A

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359264: [analyzer] RetainCount: Add a suppression for "the Matching rule". (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61161?vs=196764&id=196782#toc Repos

[PATCH] D60991: [analyzer] RetainCount: Allow offsets in return values.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359263: [analyzer] RetainCount: Allow offsets in return values. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60991?vs=196170&id=196781#toc Repository: rC

[PATCH] D60988: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359262: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60988?vs=196161&id=196780#to

r359263 - [analyzer] RetainCount: Allow offsets in return values.

Author: dergachev Date: Thu Apr 25 19:05:15 2019 New Revision: 359263 URL: http://llvm.org/viewvc/llvm-project?rev=359263&view=rev Log: [analyzer] RetainCount: Allow offsets in return values. Because RetainCountChecker has custom "local" reasoning about escapes, it has a separate facility to deal

r359262 - [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil.

Author: dergachev Date: Thu Apr 25 19:05:12 2019 New Revision: 359262 URL: http://llvm.org/viewvc/llvm-project?rev=359262&view=rev Log: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil. the assertion is in fact incorrect: there is a cornercase in Objective-C++ in which a

r359264 - [analyzer] RetainCount: Add a suppression for "the Matching rule".

Author: dergachev Date: Thu Apr 25 19:05:18 2019 New Revision: 359264 URL: http://llvm.org/viewvc/llvm-project?rev=359264&view=rev Log: [analyzer] RetainCount: Add a suppression for "the Matching rule". In the OSObject universe there appears to be another slightly popular contract, apart from "cr

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1078 +return true; + if (RD->hasUserDeclaredConstructor()) +return true; Like I mentioned before, the rule says "user-provided", not "user-declared". Comment a

r359260 - C++ DR2387: a variable template declared wtih (or instantiated with) a

Author: rsmith Date: Thu Apr 25 18:51:08 2019 New Revision: 359260 URL: http://llvm.org/viewvc/llvm-project?rev=359260&view=rev Log: C++ DR2387: a variable template declared wtih (or instantiated with) a const-qualified type is not implicitly given internal linkage. But a variable template declare

r359261 - [www] Rebuild cxx_dr_status.

Author: rsmith Date: Thu Apr 25 18:51:08 2019 New Revision: 359261 URL: http://llvm.org/viewvc/llvm-project?rev=359261&view=rev Log: [www] Rebuild cxx_dr_status. Modified: cfe/trunk/test/CXX/drs/dr17xx.cpp cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/test/CXX/drs/dr17xx.cpp URL:

r359259 - Add missing diagnostic for explicit instantiation declarations naming

Author: rsmith Date: Thu Apr 25 18:51:07 2019 New Revision: 359259 URL: http://llvm.org/viewvc/llvm-project?rev=359259&view=rev Log: Add missing diagnostic for explicit instantiation declarations naming internal linkage entities. Such constructs are ill-formed by [temp.explicit]p13. We make a spe

r359258 - Revert lib/Header: Fix Visual Studio builds

Author: tstellar Date: Thu Apr 25 18:43:59 2019 New Revision: 359258 URL: http://llvm.org/viewvc/llvm-project?rev=359258&view=rev Log: Revert lib/Header: Fix Visual Studio builds This reverts r359257 (git commit 00d9789509a4c573a48f60893b95314a119edd42) This broke check-clang. Modified: cfe

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196774. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDe

r359257 - lib/Header: Fix Visual Studio builds

Author: tstellar Date: Thu Apr 25 18:18:59 2019 New Revision: 359257 URL: http://llvm.org/viewvc/llvm-project?rev=359257&view=rev Log: lib/Header: Fix Visual Studio builds Summary: This is a follow up to r355253, which inadvertently broke Visual Studio builds by trying to copy files from CMAKE_CF

[PATCH] D61054: lib/Header: Fix Visual Studio builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC359257: lib/Header: Fix Visual Studio builds (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D61054?vs=196373&id=196771#toc Repository: rC Clang CHANGES SINC

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, rsmith, jfb. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Previously, we didn't mark an array's element type's destructor referenced when it was annotated with no_destroy. This is no

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Why would you convert the actual format, which is already using YAML, to the yaml2obj format? That seems to have zero gain to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D6097

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1479467 , @jakehehrlich wrote: > As an example, .tbe and .tbd files use YAML but in a very specific well > defined structure. yaml2obj also uses a specific format which is actually > well defined, it just doesn't map on

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. Huh, okay. I guess there are two separate bugs that are conspiring to crash the compiler here: we shouldn't correct a TypoExpr more than once, and we shouldn't correct a Typo

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. > Could you provide some more details on why NotPod is HFA, according to AAPCS? In general, computing whether a composite type is a "homogeneous aggregate" according to section 4.3.5 depends only on the "fundamental data types". It looks through "aggregates" (C struct

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

NoQ updated this revision to Diff 196764. NoQ added a comment. Fix whitespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61161/new/ https://reviews.llvm.org/D61161 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Analysis/osobject-retain-release.cpp Index: clang/

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

NoQ updated this revision to Diff 196763. NoQ added a comment. Make tests more C++-y. They still test the C function case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61161/new/ https://reviews.llvm.org/D61161 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Analysis

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61161/new/ https://reviews.llvm.org/D61161 ___

[PATCH] D55229: [COFF] Statically link certain runtime library functions

jfb added a comment. Looks like this might have broken bots: /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/tools/clang/test/CodeGenCXX/runtime-dllstorage.cpp:121:26: error: CHECK-IA-DAG: expected string not found in input // CHECK-DYNAMIC-IA-DAG: declare dllimpo

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm added a comment. I am keen to keep this moving. I think there are a few things outstanding: 1. Need to resolve concerns w.r.t the design. 2. I need to find out whether I should be doing validation when reading the metadata in LLVM. 3. The LLD side needs a more detailed review. @jykn

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. In the OSObject universe there appears to be another slight

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

shafik updated this revision to Diff 196757. shafik added a comment. Added test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140 Files: lib/AST/ASTImporter.cpp test/Import/cxx-record-flags/Inputs/F.cpp test/Import/cxx-record-flags/test.cpp

r359251 - Revert [COFF] Statically link certain runtime library functions

Author: rnk Date: Thu Apr 25 16:30:41 2019 New Revision: 359251 URL: http://llvm.org/viewvc/llvm-project?rev=359251&view=rev Log: Revert [COFF] Statically link certain runtime library functions This reverts r359250 (git commit 4730604bd3a361c68b92b18bf73a5daa15afe9f4) The newly added test should

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

TomTan added a comment. In D60349#1479604 , @efriedma wrote: > > Return info for HFA and HVA is updated > > That's helpful, but not really sufficient; according to the AAPCS rules, both > "Pod" and "NotPod" from my testcase are HFAs. Could you provide s

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

rnk added a comment. In D60283#1456497 , @thakis wrote: > See > http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 > for a "is same file" example. I'm not sure adding a bool to PresumedLoc is > worth it for this. @thaki

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. > Return info for HFA and HVA is updated That's helpful, but not really sufficient; according to the AAPCS rules, both "Pod" and "NotPod" from my testcase are HFAs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 __

[PATCH] D55229: [COFF] Statically link certain runtime library functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL359250: [COFF] Statically link certain runtime library functions (authored by rnk, committed by ). Herald added a project:

r359250 - [COFF] Statically link certain runtime library functions

Author: rnk Date: Thu Apr 25 16:04:20 2019 New Revision: 359250 URL: http://llvm.org/viewvc/llvm-project?rev=359250&view=rev Log: [COFF] Statically link certain runtime library functions Statically link certain runtime library functions for MSVC/GNU Windows environments. This is consistent with M

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Some cleanups and simplifications, but LGTM with those applied. Thank you! Comment at: docs/LanguageExtensions.rst:2335 + +When the built

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous added a comment. Also, IIUC the test case that I deleted wasn't actually supposed to produce any diagnostics and the fact that it did was a bug. We could keep it as a regression test but I think it has a rather low value. WDYT? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6110

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous updated this revision to Diff 196744. jkorous added a comment. - clang-format - comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61103/new/ https://reviews.llvm.org/D61103 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaDe

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous marked 5 inline comments as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:494 + // Explicitly not calling ExternalSource->ReadComments() as we're not + // interested in those. + ArrayRef RawComments = Comments.getComments();

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

a_sidorin added a comment. Hello Shafik! The patch itself is fine, but, as other reviewers pointed, tests are appreciated. I suggest to add a test into ASTImporterTests.cpp - you will find several ways to write tests of different complexity here. I think this change can be tested even with the

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. In D61147#1479530 , @ahatanak wrote: > In D61147#1479468 , @erik.pilkington > wrote: > > > > Yeah, I tend to think we should just suppress this unconditionally in > > > Objective-C

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

ahatanak added a comment. In D61147#1479468 , @erik.pilkington wrote: > > Yeah, I tend to think we should just suppress this unconditionally in > > Objective-C. > > IMO this warning still makes sense for normal functions, or methods that are > only decl

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359248: [CUDA] Implemented _[bi]mma* builtins. (authored by tra, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60

r359248 - [CUDA] Implemented _[bi]mma* builtins.

Author: tra Date: Thu Apr 25 15:28:09 2019 New Revision: 359248 URL: http://llvm.org/viewvc/llvm-project?rev=359248&view=rev Log: [CUDA] Implemented _[bi]mma* builtins. These builtins provide access to the new integer and sub-integer variants of MMA (matrix multiply-accumulate) instructions provi

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

TomTan added a comment. In D60349#140 , @TomTan wrote: > In D60349#1477183 , @efriedma wrote: > > > > For NotPod, it is aggregate which is specific in the document > > > > Yes, it's an aggregate which is returne

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. Sorry, yes, I meant in Objective-C methods, of course, not unconditionally even in C-like code whenever Objective-C is enabled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 196733. NoQ marked 4 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h clang/include/clang/StaticAnalyzer/Core/PathS

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4684 + if (size() <= 3) +return true; + Szelethus wrote: > What are the cases for the size being 2 or 1? Empty function? Is a size of 1 > even possible? Can we enforce something here with ass

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59725: Additions to creduce script

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + lebedev.ri wrote: > akhuang wro

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits wrote: > Do I just edit the HTML file directly? > Or is it generated by something? Just edit the HTML file directly. > On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote: >> >> Thanks! Can you update cxx_status.html to mark P0595R2 as

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. > Yeah, I tend to think we should just suppress this unconditionally in > Objective-C. IMO this warning still makes sense for normal functions, or methods that are only declared in an @implementation. Adding a fix-it to cast to void in the function/method body

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. As an example, .tbe and .tbd files use YAML but in a very specific well defined structure. yaml2obj also uses a specific format which is actually well defined, it just doesn't map on very well here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. There seems to be some confusion about the term "format" here. There's the YAML format but within that there are specific YAML formats. My proposal will be to have a specific YAML format that just isn't the one used by yaml2obj. YAML isn't the issue, it's the struc

[PATCH] D58033: Add option for emitting dbg info for call site parameters

vsk added a comment. I think a small extension to `test/CodeGenCXX/dbg-info-all-calls-described.cpp` for the 'Supported: DWARF4 + -femit_param_entry_values' case would be appropriate here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. Upon further investigation, this still seems to be okay. This is not a bug-finding checker, but rather a tool to enforce the idiom of every non-trivial object should be fully initialized after construction. From what I've seen, `ATOMIC_VAR_INIT` should be used here, b

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

NoQ added a comment. Aha, yup, thx! Do you plan to centralize other code paths on which you conjure symbols? 'Cause i still believe that given that we now support C++ (our prvalues are now properly materialized) (most of the time), you should be able to remove support for symbol-like iterators

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. Yeah, I tend to think we should just suppress this unconditionally in Objective-C. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147 ___ cfe-commits m

r359241 - [PGO] Fix buildbot failure in 359215

Author: xur Date: Thu Apr 25 14:16:41 2019 New Revision: 359241 URL: http://llvm.org/viewvc/llvm-project?rev=359241&view=rev Log: [PGO] Fix buildbot failure in 359215 Revert the part of changes in r359215 that failing in some platforms. I will re-enable them later. Modified: cfe/trunk/test/P

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. In D61106#1479336 , @jfb wrote: > Have you checked what the C and C++ standards say about `_Atomic` / > `std::atomic` initialization, and how they should actually be initialized by > developers? No, I have not, I'll admit. Di

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 196725. gtbercea added a comment. - Update patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp lib/Dr

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. > but don't want to annotate each unused ObjC method parameters with > `__attribute__((unused))` or insert `(void)unused_param` into the body of the > method to silence the warning since, unlike C/C++ functions, it's not > possible to comment out the unused para

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated > expl

[PATCH] D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx, this is safer! Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:566 const auto *InstCall = dyn_cast(&Call); if (Func->getParamDecl(0)->getType()->isRV

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

ahatanak created this revision. ahatanak added reviewers: erik.pilkington, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. The new warning `-Wunused-parameter-non-objc-method` works exactly the same as `-Wunused-parameter ` except for unused parameters of

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

jfb added a comment. Have you checked what the C and C++ standards say about `_Atomic` / `std::atomic` initialization, and how they should actually be initialized by developers? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61106/new/ https://reviews.llvm.org/D

r359237 - [analyzer] Add FIXMEs for alpha.unix.cstring.OutOfBounds false positives.

Author: dergachev Date: Thu Apr 25 13:30:14 2019 New Revision: 359237 URL: http://llvm.org/viewvc/llvm-project?rev=359237&view=rev Log: [analyzer] Add FIXMEs for alpha.unix.cstring.OutOfBounds false positives. Caused by incorrect strlcat() modeling in r332303, cf. https://bugs.llvm.org/show_bug.c

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479298 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel @

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated > expl

[PATCH] D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359235: Skip type units/type uniquing when we know we're only emitting the type once… (authored by dblaikie, committed by

r359235 - Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

Author: dblaikie Date: Thu Apr 25 13:05:47 2019 New Revision: 359235 URL: http://llvm.org/viewvc/llvm-project?rev=359235&view=rev Log: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

This revision was automatically updated to reflect the committed changes. Closed by commit rL359233: [Windows] Separate elements in -print-search-dirs with semicolons (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

r359233 - [Windows] Separate elements in -print-search-dirs with semicolons

Author: mstorsjo Date: Thu Apr 25 13:03:20 2019 New Revision: 359233 URL: http://llvm.org/viewvc/llvm-project?rev=359233&view=rev Log: [Windows] Separate elements in -print-search-dirs with semicolons Path lists on windows should always be separated by semicolons, not colons. Reuse llvm::sys::Env

[PATCH] D48292: use modern type trait implementations when available

rsmith added a comment. In D48292#1478617 , @ldionne wrote: > I think this broke the C++03 bots: > http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Thanks, should b

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

This revision was automatically updated to reflect the committed changes. Closed by commit rC359230: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61106

r359230 - [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Author: szelethus Date: Thu Apr 25 13:00:51 2019 New Revision: 359230 URL: http://llvm.org/viewvc/llvm-project?rev=359230&view=rev Log: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive https://bugs.llvm.org/show_bug.cgi?id=41590 For the following code snippet, U

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

mstorsjo updated this revision to Diff 196704. mstorsjo edited the summary of this revision. mstorsjo added a comment. Adjusted the patch to not warn if there is no previous declaration of the instantiation, allowing the dllexport attribute on the definition in that case. CHANGES SINCE LAST ACT

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added a comment. I'm okay with this, but give @aprantl a chance to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) +return true; + return false; richard.townsend.arm wrote: > richard.townsend.arm wrote: > > Should this function also check for user-prov

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. Sorry, that test case actually was a bit too complicated. This seems to work: diff --git a/clang/test/Import/cxx-record-flags/Inputs/F.cpp b/clang/test/Import/cxx-record-flags/Inputs/F.cpp new file mode 100644 index 000..1294c67f68d --- /dev/null +++

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 196699. Quuxplusone added a comment. Add tests that `LIBCPP_ASSERT_NOEXCEPT` the `options` and `upstream_resource` accessors. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 F

  1   2   3   >