efriedma added inline comments.
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1078 + return true; + if (RD->hasUserDeclaredConstructor()) + return true; ---------------- Like I mentioned before, the rule says "user-provided", not "user-declared". ================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1080 + return true; + if (RD->hasUserDeclaredDestructor()) + return true; ---------------- The rule says "trivial" not "user-declared". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
