efriedma added inline comments.
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) + return true; + return false; ---------------- richard.townsend.arm wrote: > richard.townsend.arm wrote: > > Should this function also check for user-provided constructors? > I think it should: I speculatively added these two lines > > if (RD->hasUserDeclaredConstructor()) > return true; > > and it resolved the problem with `std::setw` I mentioned in the bug tracker > (which means Electron could start). The comment says it's supposed to check for user-provided constructors, but there isn't any code to perform that check, yes. hasUserDeclaredConstructor() isn't precisely correct; from the C++ standard, "A function is user-provided if it is user-declared and not explicitly defaulted or deleted on its first declaration." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
